ning2008wisc commented on pull request #7577:
URL: https://github.com/apache/kafka/pull/7577#issuecomment-632527159
@ryannedolan @mimaison I added the Integration tests for testing this
automated consumer offset sync in MM 2.0. When available, I am appreciated for
your first pass of review
tombentley commented on a change in pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#discussion_r429081838
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/PredicatedTransformation.java
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the A
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429082038
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##
@@ -261,6 +261,43 @@ public void
shouldNo
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429082487
##
File path:
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
##
@@ -1155,12 +1192,15 @@ class PlaintextAdminIntegrationTe
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429083674
##
File path:
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
##
@@ -1017,47 +1017,70 @@ class PlaintextAdminIntegrationTe
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429083564
##
File path:
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
##
@@ -1138,7 +1165,7 @@ class PlaintextAdminIntegrationTest
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429083960
##
File path:
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
##
@@ -1075,13 +1098,17 @@ class PlaintextAdminIntegrationTe
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429084559
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -2411,6 +2411,50 @@ public void testRemoveMembersFrom
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429084219
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -186,9 +190,15 @@ private void validateNoActiveConsumers(final String
groupId,
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429084786
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupOptions.java
##
@@ -37,7 +37,15 @@ public
RemoveMember
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429087051
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3621,24 +3640,31 @@ public RemoveMembersFromConsumerGrou
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429086933
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java
##
@@ -46,26 +46,42 @@
* If not, the
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429087492
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3612,6 +3611,26 @@ private boolean dependsOnSpecificNode
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429087282
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3612,6 +3611,26 @@ private boolean dependsOnSpecificNode
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429087133
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3621,24 +3640,31 @@ public RemoveMembersFromConsumerGrou
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429087216
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3621,24 +3640,31 @@ public RemoveMembersFromConsumerGrou
jiameixie opened a new pull request #8711:
URL: https://github.com/apache/kafka/pull/8711
When applicable, use of ThreadLocalRandom rather
than shared Random objects in concurrent programs
will typically encounter much less overhead and
contention.
Change-Id: Idf56adc8cbb4c61
tombentley commented on pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#issuecomment-632551475
@C0urante thanks for the review, some excellent points there! I think an
integration test is a great idea, which I'll work on next. I've addressed all
your other comments.
-
chia7712 commented on pull request #8711:
URL: https://github.com/apache/kafka/pull/8711#issuecomment-632552331
Is this PR different from #8531?
This is an automated message from the Apache Git Service.
To respond to the mess
chia7712 commented on a change in pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#discussion_r429100323
##
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##
@@ -1742,6 +1746,12 @@ class SocketServerTest {
selector = Some(
jiameixie commented on pull request #8711:
URL: https://github.com/apache/kafka/pull/8711#issuecomment-632558263
> Is this PR different from #8531?
@chia7712 It's the same issue. #8531 has wrong spell for KAFKA. And I
didn't see any PR about this issue in
https://issues.apache.org/
jiameixie closed pull request #8711:
URL: https://github.com/apache/kafka/pull/8711
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-10006:
-
Assignee: Luke Chen
> Streams should not attempt to create internal topics that may exist
> ---
mimaison commented on a change in pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#discussion_r429131002
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupsOptions.java
##
@@ -26,4 +31,34 @@
*/
@InterfaceStability.Evolving
mimaison commented on a change in pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#discussion_r429133529
##
File path: clients/src/main/resources/common/message/ListGroupsRequest.json
##
@@ -20,8 +20,14 @@
// Version 1 and 2 are the same as version 0.
//
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429133442
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java
##
@@ -46,26 +46,42 @@
* If not, the
mimaison commented on a change in pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#discussion_r429136058
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupsOptions.java
##
@@ -26,4 +31,34 @@
*/
@InterfaceStability.Evolving
mimaison commented on pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#issuecomment-632591659
Thanks @hachikuji for the feedback. You brought some interesting points that
overall simplify the KIP/logic a bit.
While initially, it seemed a perfect use case for tagged fie
kowshik commented on a change in pull request #8680:
URL: https://github.com/apache/kafka/pull/8680#discussion_r428573407
##
File path:
clients/src/main/java/org/apache/kafka/common/feature/BaseVersionRange.java
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foun
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429145185
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3660,7 +3686,7 @@ void handleResponse(AbstractResponse a
jiamei xie created KAFKA-10031:
--
Summary: Exist client create wrong topic automatically for a
total-fresh restarted Kafka cluster
Key: KAFKA-10031
URL: https://issues.apache.org/jira/browse/KAFKA-10031
[
https://issues.apache.org/jira/browse/KAFKA-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiamei xie updated KAFKA-10031:
---
Summary: Exist client automatically create wrong topic for a total-fresh
restarted Kafka cluster (
[
https://issues.apache.org/jira/browse/KAFKA-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiamei xie updated KAFKA-10031:
---
Summary: Exist client create wrong topic for a total-fresh restarted Kafka
cluster automatically (
[
https://issues.apache.org/jira/browse/KAFKA-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiamei xie updated KAFKA-10031:
---
Summary: Exist client automatically create wrong topic for a total-fresh
restarted Kafka cluster
showuon opened a new pull request #8712:
URL: https://github.com/apache/kafka/pull/8712
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
cadonna commented on a change in pull request #8697:
URL: https://github.com/apache/kafka/pull/8697#discussion_r429158357
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##
@@ -642,6 +642,30 @@ public static void
mimaison commented on pull request #8312:
URL: https://github.com/apache/kafka/pull/8312#issuecomment-632632500
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/KAFKA-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113958#comment-17113958
]
Bruno Cadonna commented on KAFKA-9173:
--
The issue that all 10 tasks are assigned to
[
https://issues.apache.org/jira/browse/KAFKA-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-9173.
--
Fix Version/s: 2.6.0
Resolution: Fixed
> StreamsPartitionAssignor assigns partitions to
cadonna commented on a change in pull request #8696:
URL: https://github.com/apache/kafka/pull/8696#discussion_r429196241
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java
##
@@ -132,22 +132,97 @@ static boolean assig
mimaison commented on a change in pull request #8312:
URL: https://github.com/apache/kafka/pull/8312#discussion_r429211490
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/DescribeConfigsResponse.java
##
@@ -174,19 +97,25 @@ public boolean isReadOnly() {
rnpridgeon commented on a change in pull request #8691:
URL: https://github.com/apache/kafka/pull/8691#discussion_r429216813
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/ConnectUtils.java
##
@@ -16,19 +16,24 @@
*/
package org.apache.kafka.connec
rnpridgeon commented on a change in pull request #8691:
URL: https://github.com/apache/kafka/pull/8691#discussion_r429216813
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/ConnectUtils.java
##
@@ -16,19 +16,24 @@
*/
package org.apache.kafka.connec
cadonna commented on pull request #8713:
URL: https://github.com/apache/kafka/pull/8713#issuecomment-632676433
Call for review: @ableegoldman @vvcephei
This is an automated message from the Apache Git Service.
To respond to
cadonna opened a new pull request #8713:
URL: https://github.com/apache/kafka/pull/8713
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
ijuma opened a new pull request #8714:
URL: https://github.com/apache/kafka/pull/8714
It was previously:
> INFO Registered broker 0 at path /brokers/ids/0 with addresses:
ArraySeq(EndPoint(localhost,9092,ListenerName(PLAINTEXT),PLAINTEXT),EndPoint(localhost,9093,ListenerName(SSL),SSL
Antonio Pires created KAFKA-10032:
-
Summary: Response to ApiVersionRequest returns wrong Produce(0)
version
Key: KAFKA-10032
URL: https://issues.apache.org/jira/browse/KAFKA-10032
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-10032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Pires updated KAFKA-10032:
--
Description:
The response to {{ApiVersionRequest}} returns incorrect information for the
Prod
[
https://issues.apache.org/jira/browse/KAFKA-10032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Pires updated KAFKA-10032:
--
Description:
The response to {{ApiVersionRequest}} returns incorrect information for the
Prod
Gregory Koshelev created KAFKA-10033:
Summary: AdminClient should throw UnknownTopicOrPartitionException
instead of UnknownServerException if altering configs of non-existing topic
Key: KAFKA-10033
URL: https:
showuon commented on a change in pull request #8712:
URL: https://github.com/apache/kafka/pull/8712#discussion_r429276664
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -157,16 +161,16 @@ public InternalTopicMan
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429276600
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java
##
@@ -51,9 +52,21 @@
if (thro
feyman2016 commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-632722266
@abbccdda Updated and req for review agian.. really appreciated your help to
pick out so much style violations, also wondering if we can use some format
tool like `scalafmt` to
gnkoshelev opened a new pull request #8715:
URL: https://github.com/apache/kafka/pull/8715
Fixes KAFKA-10033.
Replace AdminOperationException with UnknownTopicOrPartitionException if
topic does not exists when validating altering configs of topic in
AdminZkClient.
feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429276600
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java
##
@@ -51,9 +52,21 @@
if (thro
ijuma commented on a change in pull request #8714:
URL: https://github.com/apache/kafka/pull/8714#discussion_r429285942
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1694,9 +1694,10 @@ class Log(@volatile private var _dir: File,
private def deleteOldSegments(p
showuon commented on a change in pull request #8712:
URL: https://github.com/apache/kafka/pull/8712#discussion_r429288449
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java
##
@@ -330,6 +331,12 @@ synchronized public DescribeTopicsResult
d
showuon commented on a change in pull request #8712:
URL: https://github.com/apache/kafka/pull/8712#discussion_r429288449
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java
##
@@ -330,6 +331,12 @@ synchronized public DescribeTopicsResult
d
showuon commented on a change in pull request #8712:
URL: https://github.com/apache/kafka/pull/8712#discussion_r429289380
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -247,11 +261,19 @@ public InternalTopicMan
showuon commented on pull request #8712:
URL: https://github.com/apache/kafka/pull/8712#issuecomment-632729141
Hi @ableegoldman , could you review this PR? Thanks.
This is an automated message from the Apache Git Service.
To
mjsax commented on pull request #8697:
URL: https://github.com/apache/kafka/pull/8697#issuecomment-632758838
Build failed with checkstyle:
```
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/clients/src/main/java/org/apache/kafka/common/metrics/
mjsax commented on pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#issuecomment-632759415
Java 8 and Java 11 passed.
Java 14:
```
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
```
mjsax merged pull request #8679:
URL: https://github.com/apache/kafka/pull/8679
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-10003.
-
Fix Version/s: 2.6.0
Resolution: Fixed
> Deprecate KStream#through in favor of KS
[
https://issues.apache.org/jira/browse/KAFKA-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brian Byrne reassigned KAFKA-10033:
---
Assignee: Brian Byrne
> AdminClient should throw UnknownTopicOrPartitionException instead o
mumrah commented on a change in pull request #8376:
URL: https://github.com/apache/kafka/pull/8376#discussion_r429323395
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
##
@@ -422,8 +427,29 @@ public synchronized void posi
mumrah commented on a change in pull request #8376:
URL: https://github.com/apache/kafka/pull/8376#discussion_r429325049
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
##
@@ -422,8 +427,29 @@ public synchronized void posi
hachikuji commented on a change in pull request #8702:
URL: https://github.com/apache/kafka/pull/8702#discussion_r429325325
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -565,8 +566,8 @@ private void recordRebala
hachikuji commented on a change in pull request #8702:
URL: https://github.com/apache/kafka/pull/8702#discussion_r429327443
##
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##
@@ -502,14 +502,8 @@ private void doSend(ClientRequest clientRequest, b
hachikuji commented on a change in pull request #8702:
URL: https://github.com/apache/kafka/pull/8702#discussion_r429327946
##
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##
@@ -839,20 +833,22 @@ private void handleCompletedReceives(List
respon
hachikuji commented on a change in pull request #8702:
URL: https://github.com/apache/kafka/pull/8702#discussion_r429328416
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java
##
@@ -312,8 +313,27 @@ public void testJoin
hachikuji commented on a change in pull request #8702:
URL: https://github.com/apache/kafka/pull/8702#discussion_r429327946
##
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##
@@ -839,20 +833,22 @@ private void handleCompletedReceives(List
respon
hachikuji commented on a change in pull request #8702:
URL: https://github.com/apache/kafka/pull/8702#discussion_r429327946
##
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##
@@ -839,20 +833,22 @@ private void handleCompletedReceives(List
respon
abbccdda commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r42955
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -379,6 +379,22 @@ private static MetadataResponse
prep
vvcephei commented on pull request #8713:
URL: https://github.com/apache/kafka/pull/8713#issuecomment-632787649
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on a change in pull request #8696:
URL: https://github.com/apache/kafka/pull/8696#discussion_r429346085
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java
##
@@ -57,14 +59,42 @@ publi
vvcephei commented on a change in pull request #8696:
URL: https://github.com/apache/kafka/pull/8696#discussion_r429346417
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java
##
@@ -132,22 +132,97 @@ static boolean assi
vvcephei commented on pull request #8696:
URL: https://github.com/apache/kafka/pull/8696#issuecomment-632791703
Hey @cadonna , thanks for the feedback! I think I'll go ahead and merge this
because I've already fixed the "max warmup" thing in a separate bugfix PR,
which builds on this one.
vvcephei merged pull request #8696:
URL: https://github.com/apache/kafka/pull/8696
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vvcephei opened a new pull request #8716:
URL: https://github.com/apache/kafka/pull/8716
Also fixes a system test by configuring the HATA to perform a one-shot
balanced assignment
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [
bdbyrne opened a new pull request #8717:
URL: https://github.com/apache/kafka/pull/8717
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade not
bdbyrne commented on pull request #8715:
URL: https://github.com/apache/kafka/pull/8715#issuecomment-632799086
Hi @gnkoshelev - it's assumed the topic has been validated by the time it
attempts to alter its config via AdminZKClient. I've posted the proper fix at
https://github.com/apache/k
bdbyrne commented on pull request #8717:
URL: https://github.com/apache/kafka/pull/8717#issuecomment-632799858
@cmccabe this is ready for review.
The test location doesn't quite fit as it's in the module test dynamic
config changes on the broker, but it's "near" the old error. Any id
guozhangwang commented on a change in pull request #8702:
URL: https://github.com/apache/kafka/pull/8702#discussion_r429352451
##
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##
@@ -502,14 +502,8 @@ private void doSend(ClientRequest clientRequest
vvcephei commented on a change in pull request #8716:
URL: https://github.com/apache/kafka/pull/8716#discussion_r429352759
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##
@@ -334,6 +334,7 @@ public String toString
xvrl commented on a change in pull request #8691:
URL: https://github.com/apache/kafka/pull/8691#discussion_r429366836
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetricsContext.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Found
wj1918 closed pull request #8612:
URL: https://github.com/apache/kafka/pull/8612
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wj1918 commented on pull request #8612:
URL: https://github.com/apache/kafka/pull/8612#issuecomment-632819461
@kkonstantine thanks for the comment. understood, will close this PR and
create separate PRs when ready.
This is a
rnpridgeon commented on a change in pull request #8691:
URL: https://github.com/apache/kafka/pull/8691#discussion_r429370889
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetricsContext.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software
kkonstantine commented on pull request #8612:
URL: https://github.com/apache/kafka/pull/8612#issuecomment-632820983
Thanks @wj1918 !
Happy to review after they are ready.
This is an automated message from the Apache Git S
rhauch commented on pull request #8663:
URL: https://github.com/apache/kafka/pull/8663#issuecomment-632824180
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
rhauch removed a comment on pull request #8630:
URL: https://github.com/apache/kafka/pull/8630#issuecomment-632824360
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
rhauch commented on pull request #8630:
URL: https://github.com/apache/kafka/pull/8630#issuecomment-632824360
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
rhauch commented on pull request #8630:
URL: https://github.com/apache/kafka/pull/8630#issuecomment-632824461
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/KAFKA-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reassigned KAFKA-10005:
-
Assignee: (was: Guozhang Wang)
> Decouple RestoreListener from RestoreCallback and
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114291#comment-17114291
]
Guozhang Wang commented on KAFKA-9168:
--
Just add a reference that this feature is on
[
https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114309#comment-17114309
]
Ryanne Dolan commented on KAFKA-7500:
-
[~qq619618919] I usually recommend using a loa
rhauch opened a new pull request #8718:
URL: https://github.com/apache/kafka/pull/8718
DO NOT MERGE
Debugging build failures
This is an automated message from the Apache Git Service.
To respond to the message, plea
ableegoldman commented on a change in pull request #8697:
URL: https://github.com/apache/kafka/pull/8697#discussion_r429396524
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -137,6 +138,7 @@ public StreamTask(final TaskId
rhauch opened a new pull request #8719:
URL: https://github.com/apache/kafka/pull/8719
DO NOT MERGE
Debugging build failures
See #8718
This is an automated message from the Apache Git Service.
To respond to the
1 - 100 of 192 matches
Mail list logo
