chia7712 commented on a change in pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#discussion_r429100323
##########
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##########
@@ -1742,6 +1746,12 @@ class SocketServerTest {
selector = Some(testableSelector)
testableSelector
}
+
+ override private[network] def processException(errorMessage: String,
throwable: Throwable, isUncaught: Boolean): Unit = {
Review comment:
```isUncaught``` is used by testing only so it is a bit awkward to
production code. Could you check the ```errorMessage``` instead of adding new
argument? for example:
```scala
if (errorMessage == "Processor got uncaught exception.") uncaughtExceptions
+= 1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
