Re: [PR] MINOR: Use readable interface to parse requests [kafka]

jsancio merged PR #19163: URL: https://github.com/apache/kafka/pull/19163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

soondenana commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r2012740807 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first,

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

jsancio commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r2012339800 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first,

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

soondenana commented on PR #19163: URL: https://github.com/apache/kafka/pull/19163#issuecomment-2723117303 > BTW, while we're on it, why don't we do a similar refactoring for the `AbstractResponse.parseResponse` (the second overload)? Maybe in a separate PR. We should also modify the

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

artemlivshits commented on PR #19163: URL: https://github.com/apache/kafka/pull/19163#issuecomment-2719177262 BTW, while we're on it, why don't we do a similar refactoring for the `AbstractResponse.parseResponse` (the second overload)? -- This is an automated message from the Apache Git S

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

ijuma commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1985765879 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first, }

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

soondenana commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1988107211 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java: ## @@ -168,190 +175,194 @@ public Map errorCounts(Throwable e) { * Factory meth

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

soondenana commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1989669227 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first,

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

artemlivshits commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1987985812 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java: ## @@ -122,8 +124,8 @@ public final ByteBuffer serializeWithHeader(RequestHeader

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

artemlivshits commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1988203221 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first,

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

soondenana commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1988106394 ## clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java: ## @@ -1923,9 +1922,9 @@ private void checkRequest(AbstractRequest req) {

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

soondenana commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1985891433 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java: ## @@ -122,8 +124,8 @@ public final ByteBuffer serializeWithHeader(RequestHeader hea

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

artemlivshits commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1985871102 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java: ## @@ -122,8 +124,8 @@ public final ByteBuffer serializeWithHeader(RequestHeader

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

ijuma commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1985768753 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first, }