Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-21 Thread via GitHub
ijuma commented on PR #18954: URL: https://github.com/apache/kafka/pull/18954#issuecomment-2674861637 Interesting, the flaky test looks related to #18845, I added a comment to the JIRA ticket too. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-21 Thread via GitHub
dajac merged PR #18954: URL: https://github.com/apache/kafka/pull/18954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-21 Thread via GitHub
dajac commented on PR #18954: URL: https://github.com/apache/kafka/pull/18954#issuecomment-2674815425 Merged to trunk and to 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-21 Thread via GitHub
dajac commented on PR #18954: URL: https://github.com/apache/kafka/pull/18954#issuecomment-2674684248 > QuorumControllerTest > testBalancePartitionLeaders() This test (Java 23) failed but it passes locally. Looking at the [history](https://develocity.apache.org/scans/tests?search.rela

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-20 Thread via GitHub
cmccabe commented on PR #18954: URL: https://github.com/apache/kafka/pull/18954#issuecomment-2672719747 @CalvinConfluent please add a test case to FormatterTest of someone turning on ELR for formatting when MV = 4.0-IV1. Also add a test case that fails with ELR = 1 and MV = 3.9-IV0 (or othe

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-19 Thread via GitHub
cmccabe commented on PR #18954: URL: https://github.com/apache/kafka/pull/18954#issuecomment-2669387382 @dajac I commented that this is probably not the right approach. We probably need some kind of custom logic for what you are trying to do since the framework treats the associated MV of

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
CalvinConfluent commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960765911 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
dajac commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960533479 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion implement

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
cmccabe commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960530407 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion impleme

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
cmccabe commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960529339 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion impleme

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
cmccabe commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960529339 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion impleme