ijuma commented on PR #18954:
URL: https://github.com/apache/kafka/pull/18954#issuecomment-2674861637
Interesting, the flaky test looks related to #18845, I added a comment to
the JIRA ticket too.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
dajac merged PR #18954:
URL: https://github.com/apache/kafka/pull/18954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #18954:
URL: https://github.com/apache/kafka/pull/18954#issuecomment-2674815425
Merged to trunk and to 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dajac commented on PR #18954:
URL: https://github.com/apache/kafka/pull/18954#issuecomment-2674684248
> QuorumControllerTest > testBalancePartitionLeaders()
This test (Java 23) failed but it passes locally. Looking at the
[history](https://develocity.apache.org/scans/tests?search.rela
cmccabe commented on PR #18954:
URL: https://github.com/apache/kafka/pull/18954#issuecomment-2672719747
@CalvinConfluent please add a test case to FormatterTest of someone turning
on ELR for formatting when MV = 4.0-IV1. Also add a test case that fails with
ELR = 1 and MV = 3.9-IV0 (or othe
cmccabe commented on PR #18954:
URL: https://github.com/apache/kafka/pull/18954#issuecomment-2669387382
@dajac I commented that this is probably not the right approach. We
probably need some kind of custom logic for what you are trying to do since the
framework treats the associated MV of
CalvinConfluent commented on code in PR #18954:
URL: https://github.com/apache/kafka/pull/18954#discussion_r1960765911
##
server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java:
##
@@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion
dajac commented on code in PR #18954:
URL: https://github.com/apache/kafka/pull/18954#discussion_r1960533479
##
server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java:
##
@@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion implement
cmccabe commented on code in PR #18954:
URL: https://github.com/apache/kafka/pull/18954#discussion_r1960530407
##
server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java:
##
@@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion impleme
cmccabe commented on code in PR #18954:
URL: https://github.com/apache/kafka/pull/18954#discussion_r1960529339
##
server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java:
##
@@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion impleme
cmccabe commented on code in PR #18954:
URL: https://github.com/apache/kafka/pull/18954#discussion_r1960529339
##
server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java:
##
@@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion impleme
11 matches
Mail list logo