cmccabe commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960529339
########## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ########## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion implements FeatureVersion { ELRV_0(0, MetadataVersion.MINIMUM_KRAFT_VERSION, Collections.emptyMap()), // Version 1 enables the ELR (KIP-966). - ELRV_1(1, MetadataVersion.IBP_4_0_IV1, Collections.emptyMap()); + ELRV_1(1, MetadataVersion.IBP_4_1_IV0, Collections.emptyMap()); Review Comment: I think the comment should be something like "enables ELR by default for new clusters" ########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -130,7 +130,7 @@ public enum MetadataVersion { // Please move this comment when updating the LATEST_PRODUCTION constant. // - // Not used by anything yet. + // The default version to enable ELR (KIP-966). IBP_4_1_IV0(26, "4.1", "IV0", false); Review Comment: I think the comment should be something like "enables ELR by default for new clusters" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org