mjsax commented on PR #19359:
URL: https://github.com/apache/kafka/pull/19359#issuecomment-2784963186
> Also, according to KIP-1071, the request shutdown of the whole application
should be available only if the member epoch is equal to leave epoch. Hence,
should we check the flag in the str
lucasbru commented on PR #19359:
URL: https://github.com/apache/kafka/pull/19359#issuecomment-2782759530
> @lucasbru Out of curiosity, it seems the soft-state flag is used to add
more logs on both client-side and server-side. Is that expected?
Yes. There was logging associated with th
lucasbru merged PR #19359:
URL: https://github.com/apache/kafka/pull/19359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2030885666
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupTest.java:
##
@@ -1106,4 +1106,33 @@ public void testIsSubscribedToTopic() {
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2030885033
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2226,6 +2224,16 @@ private CoordinatorResult stream
chia7712 commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2030221993
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2226,6 +2224,16 @@ private CoordinatorResult stream
jeffkbkim commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2029386900
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupTest.java:
##
@@ -1106,4 +1106,33 @@ public void testIsSubscribedToTopic() {
jeffkbkim commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2027417821
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupTest.java:
##
@@ -1106,4 +1106,32 @@ public void testIsSubscribedToTopic() {
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2028433315
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##
@@ -197,6 +197,13 @@ public static class DeadlineAndEpoch {
*
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2028446631
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupTest.java:
##
@@ -1106,4 +1106,32 @@ public void testIsSubscribedToTopic() {
lucasbru commented on PR #19359:
URL: https://github.com/apache/kafka/pull/19359#issuecomment-2778072098
@mjsax @jeffkbkim Thanks for the comments! All addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2028446403
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -16233,6 +16233,97 @@ public void
testStreamsGroupMemberJoi
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2028433315
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##
@@ -197,6 +197,13 @@ public static class DeadlineAndEpoch {
*
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2028433315
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##
@@ -197,6 +197,13 @@ public static class DeadlineAndEpoch {
*
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2028429508
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2070,8 +2067,6 @@ private CoordinatorResult stream
Str
mjsax commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2028004070
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -16233,6 +16233,97 @@ public void
testStreamsGroupMemberJoinin
16 matches
Mail list logo