mimaison merged PR #19050:
URL: https://github.com/apache/kafka/pull/19050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2044525835
##
metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java:
##
@@ -207,4 +216,45 @@ static AuthorizationResult getDefaultResult(Map
config
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2044524561
##
server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
chia7712 commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2044367536
##
server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
chia7712 commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2044022395
##
metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java:
##
@@ -207,4 +216,45 @@ static AuthorizationResult getDefaultResult(Map
config
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2044183839
##
metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java:
##
@@ -207,4 +216,45 @@ static AuthorizationResult getDefaultResult(Map
config
mimaison commented on PR #19050:
URL: https://github.com/apache/kafka/pull/19050#issuecomment-2804287543
@chia7712 If you have time, can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2041847685
##
clients/src/main/java/org/apache/kafka/common/internals/Plugin.java:
##
@@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics)
{
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2041168550
##
clients/src/main/java/org/apache/kafka/common/internals/Plugin.java:
##
@@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics)
{
m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2041145949
##
clients/src/main/java/org/apache/kafka/common/internals/Plugin.java:
##
@@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics)
{
th
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2041137804
##
clients/src/main/java/org/apache/kafka/common/internals/Plugin.java:
##
@@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics)
{
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2041137300
##
clients/src/main/java/org/apache/kafka/common/internals/Plugin.java:
##
@@ -60,6 +99,13 @@ private static Map tags(String key, T
instance) {
return tags;
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2041136887
##
clients/src/main/java/org/apache/kafka/common/internals/Plugin.java:
##
@@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics)
{
m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2041132013
##
clients/src/main/java/org/apache/kafka/common/internals/Plugin.java:
##
@@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics)
{
th
m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2041132665
##
clients/src/main/java/org/apache/kafka/common/internals/Plugin.java:
##
@@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics)
{
th
mimaison commented on PR #19050:
URL: https://github.com/apache/kafka/pull/19050#issuecomment-2797321585
> Overall LGTM. Will you be addressing [#19068
(comment)](https://github.com/apache/kafka/pull/19068#discussion_r2033623742)
in this PR?
I pushed a commit to address it.
--
Th
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2031382775
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3284,7 +3285,7 @@ private boolean maybeUpdateRegularExpressions
m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2031390658
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3284,7 +3285,7 @@ private boolean maybeUpdateRegularExpressions(
m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2031317020
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3284,7 +3285,7 @@ private boolean maybeUpdateRegularExpressions(
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2031012460
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java:
##
@@ -103,6 +105,9 @@ public void onMetadataUpdate(MetadataDelta delta,
MetadataImag
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2030840916
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java:
##
@@ -505,8 +506,8 @@ public Builder
withShareGroupAssign
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2030844573
##
server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2030836809
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -250,7 +251,7 @@ public GroupCoordinatorShard build() {
TaiJuWu commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2028375807
##
metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java:
##
@@ -103,6 +105,9 @@ public void onMetadataUpdate(MetadataDelta delta,
MetadataImage
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2028335989
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/metadata/KRaftMetadataRequestBenchmark.java:
##
@@ -94,8 +94,8 @@
@State(Scope.Benchmark)
@Fork(value = 1)
-@W
m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2028015016
##
server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
m1a2st commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2027327151
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -766,7 +766,7 @@ class BrokerServer(
CoreUtils.swallow(dataPlaneRequestHandlerPool.shutdown(), thi
TaiJuWu commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2027209374
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2654,7 +2655,7 @@ class ReplicaManager(val config: KafkaConfig,
config.replicaSelectorClassName.ma
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2027138995
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2654,7 +2655,7 @@ class ReplicaManager(val config: KafkaConfig,
config.replicaSelectorClassName.m
mimaison commented on PR #19050:
URL: https://github.com/apache/kafka/pull/19050#issuecomment-2775985730
@Yunyung Sorry the PR was not fully complete. I updated the javadoc and
added an integration test. It should be ready to review now.
--
This is an automated message from the Apache Git
30 matches
Mail list logo
