FrankYang0529 commented on PR #18801:
URL: https://github.com/apache/kafka/pull/18801#issuecomment-2716624266
Hi @chia7712, I addressed all comments. Could you review this when you have
time? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
chia7712 commented on code in PR #18801:
URL: https://github.com/apache/kafka/pull/18801#discussion_r197530
##
metadata/src/main/java/org/apache/kafka/metadata/MetadataCache.java:
##
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
chia7712 commented on code in PR #18801:
URL: https://github.com/apache/kafka/pull/18801#discussion_r1973109296
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -345,68 +352,75 @@ class KRaftMetadataCache(
Option(_currentImage.cluster.broker(bro
FrankYang0529 commented on PR #18801:
URL: https://github.com/apache/kafka/pull/18801#issuecomment-2685571786
@mumrah I update benchmark to PR description. The result is a little
different from yours. The difference between trunk and branch results on my
laptop is close, so I think the resu
FrankYang0529 commented on PR #18801:
URL: https://github.com/apache/kafka/pull/18801#issuecomment-2682397445
@mumrah, thanks for the suggestion and review. I will do benchmark and fix
the conflict tomorrow. Appreciate it!
--
This is an automated message from the Apache Git Service.
To re
mumrah commented on PR #18801:
URL: https://github.com/apache/kafka/pull/18801#issuecomment-2682316716
I ran one of the benchmarks and there actually seems to be a slight
improvement! cc @ijuma
benchmark:
```
./jmh.sh -f 2 -i 2 -wi 2
org.apache.kafka.jmh.server.CheckpointBench
mumrah commented on code in PR #18801:
URL: https://github.com/apache/kafka/pull/18801#discussion_r1969879516
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1192,17 +1192,18 @@ class KafkaApis(val requestChannel: RequestChannel,
if (topicMetadata.head.error
FrankYang0529 commented on PR #18801:
URL: https://github.com/apache/kafka/pull/18801#issuecomment-2680667964
Hi @mumrah, thanks for the review. I addressed all comments. For benchmark,
I think we can do it in https://issues.apache.org/jira/browse/KAFKA-17573 when
we migrate `KRaftMetadataC
mumrah commented on code in PR #18801:
URL: https://github.com/apache/kafka/pull/18801#discussion_r1965712115
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -821,17 +821,19 @@ object TestUtils extends Logging {
waitUntilTrue(
() => brokers.forall { br
chia7712 commented on PR #18801:
URL: https://github.com/apache/kafka/pull/18801#issuecomment-2657861038
@FrankYang0529 please fix the conflicts, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
10 matches
Mail list logo
