mumrah commented on PR #18801: URL: https://github.com/apache/kafka/pull/18801#issuecomment-2682316716
I ran one of the benchmarks and there actually seems to be a slight improvement! cc @ijuma benchmark: ``` ./jmh.sh -f 2 -i 2 -wi 2 org.apache.kafka.jmh.server.CheckpointBench.measureCheckpointHighWatermarks ``` trunk: ``` Benchmark (numPartitions) (numTopics) Mode Cnt Score Error Units CheckpointBench.measureCheckpointHighWatermarks 3 100 thrpt 4 0.154 ± 0.010 ops/ms CheckpointBench.measureCheckpointHighWatermarks 3 1000 thrpt 4 0.101 ± 0.032 ops/ms CheckpointBench.measureCheckpointHighWatermarks 3 2000 thrpt 4 0.091 ± 0.019 ops/ms JMH benchmarks done ``` this PR: ``` Benchmark (numPartitions) (numTopics) Mode Cnt Score Error Units CheckpointBench.measureCheckpointHighWatermarks 3 100 thrpt 4 0.153 ± 0.109 ops/ms CheckpointBench.measureCheckpointHighWatermarks 3 1000 thrpt 4 0.141 ± 0.031 ops/ms CheckpointBench.measureCheckpointHighWatermarks 3 2000 thrpt 4 0.129 ± 0.033 ops/ms ``` @FrankYang0529 now I definitely think you should run the benchmarks for this PR so you can take credit for the performance improvement 😁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
