Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-04-02 Thread via GitHub
junrao commented on PR #18140: URL: https://github.com/apache/kafka/pull/18140#issuecomment-2773915601 Filed https://issues.apache.org/jira/browse/KAFKA-19080 to track this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-03-27 Thread via GitHub
junrao commented on PR #18140: URL: https://github.com/apache/kafka/pull/18140#issuecomment-2758776560 @jayteej : Thanks for the PR and sorry for chiming in late. The KIP https://cwiki.apache.org/confluence/display/KAFKA/KIP-1030%3A+Change+constraints+and+default+values+for+various+configura

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-16 Thread via GitHub
ijuma commented on PR #18140: URL: https://github.com/apache/kafka/pull/18140#issuecomment-2596875075 Was there any increase in test time due to requiring larger segments? We could make it possible for tests to set it lower. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-16 Thread via GitHub
divijvaidya commented on PR #18140: URL: https://github.com/apache/kafka/pull/18140#issuecomment-2595972187 The `ClientIdQuotaTest` have known flaky failure in trunk - https://ge.apache.org/scans/tests?search.rootProjectNames=kafka&search.tags=trunk&search.timeZoneId=Europe%2FBerlin&tests.co

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-16 Thread via GitHub
divijvaidya merged PR #18140: URL: https://github.com/apache/kafka/pull/18140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-16 Thread via GitHub
jayteej commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1918186537 ## core/src/test/java/kafka/admin/DeleteTopicTest.java: ## @@ -239,7 +239,7 @@ public void testDeleteNonExistingTopic(ClusterInstance cluster) throws Exception @C

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-16 Thread via GitHub
divijvaidya commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1918156206 ## core/src/test/java/kafka/admin/DeleteTopicTest.java: ## @@ -239,7 +239,7 @@ public void testDeleteNonExistingTopic(ClusterInstance cluster) throws Exception

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-15 Thread via GitHub
jayteej commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1917209846 ## core/src/test/java/kafka/admin/DeleteTopicTest.java: ## @@ -239,7 +239,7 @@ public void testDeleteNonExistingTopic(ClusterInstance cluster) throws Exception @C

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-15 Thread via GitHub
divijvaidya commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1917060814 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1188,7 +1188,7 @@ class KafkaConfigTest { case TopicConfig.COMPRESSION_ZSTD_LEVEL_CO

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-15 Thread via GitHub
divijvaidya commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1917061349 ## core/src/test/java/kafka/admin/DeleteTopicTest.java: ## @@ -239,7 +239,7 @@ public void testDeleteNonExistingTopic(ClusterInstance cluster) throws Exception

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-15 Thread via GitHub
divijvaidya commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1916734948 ## core/src/test/scala/unit/kafka/server/LogOffsetTest.scala: ## @@ -52,7 +52,7 @@ class LogOffsetTest extends BaseRequestTest { props.put("num.partitions", "2

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-01-15 Thread via GitHub
divijvaidya commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1916346187 ## core/src/test/java/kafka/admin/DeleteTopicTest.java: ## @@ -239,7 +239,7 @@ public void testDeleteNonExistingTopic(ClusterInstance cluster) throws Exception

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2024-12-13 Thread via GitHub
jayteej commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1884176073 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -625,7 +626,7 @@ class DynamicBrokerReconfigurationTest extends QuorumTes

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2024-12-13 Thread via GitHub
jayteej commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1884176073 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -625,7 +626,7 @@ class DynamicBrokerReconfigurationTest extends QuorumTes

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2024-12-13 Thread via GitHub
jayteej commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1884175051 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1188,7 +1188,7 @@ class KafkaConfigTest { case TopicConfig.COMPRESSION_ZSTD_LEVEL_CONFIG

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2024-12-13 Thread via GitHub
jayteej commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1883814714 ## core/src/test/scala/unit/kafka/server/LogOffsetTest.scala: ## @@ -224,14 +224,14 @@ class LogOffsetTest extends BaseRequestTest { val now = Time.SYSTEM.millisec

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2024-12-11 Thread via GitHub
divijvaidya commented on code in PR #18140: URL: https://github.com/apache/kafka/pull/18140#discussion_r1880421924 ## core/src/test/java/kafka/admin/DeleteTopicTest.java: ## @@ -239,7 +239,7 @@ public void testDeleteNonExistingTopic(ClusterInstance cluster) throws Exception

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2024-12-11 Thread via GitHub
jayteej commented on PR #18140: URL: https://github.com/apache/kafka/pull/18140#issuecomment-2536032865 @divijvaidya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns