jayteej commented on code in PR #18140:
URL: https://github.com/apache/kafka/pull/18140#discussion_r1883814714
##########
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala:
##########
@@ -224,14 +224,14 @@ class LogOffsetTest extends BaseRequestTest {
val now = Time.SYSTEM.milliseconds + 30000 // pretend it is the future to
avoid race conditions with the fs
val offsets = log.legacyFetchOffsetsBefore(now, 15)
- assertEquals(Seq(20L, 18L, 16L, 14L, 12L, 10L, 8L, 6L, 4L, 2L, 0L),
offsets)
+ assertEquals(Seq(20L, 0L), offsets)
TestUtils.waitUntilTrue(() => isLeaderLocalOnBroker(topic,
topicPartition.partition, broker),
"Leader should be elected")
val request = ListOffsetsRequest.Builder.forReplica(0, 0)
.setTargetTimes(buildTargetTimes(topicPartition, now, 15).asJava).build()
val consumerOffsets =
findPartition(sendListOffsetsRequest(request).topics.asScala,
topicPartition).oldStyleOffsets.asScala
- assertEquals(Seq(20L, 18L, 16L, 14L, 12L, 10L, 8L, 6L, 4L, 2L, 0L),
consumerOffsets)
Review Comment:
Because we increased the segment size, there is now one segment and
therefore less offsets returned by the API call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
