Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on PR #17022: URL: https://github.com/apache/kafka/pull/17022#issuecomment-2981743810 Ok -- I'm back. I think the thing that wasn't sitting right for me, and what I realized from our discussion with the producer ID overflow is whether this is the right place to make the ch

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

mjsax commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2152880201 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -790,14 +790,34 @@ public synchronized void maybeTransitionToErrorSta

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on PR #17022: URL: https://github.com/apache/kafka/pull/17022#issuecomment-2981092997 Hey thanks. I took a step back and I'm wondering if this is the right approach. Let me try to get back to you on this -- I need to get a better idea of the whole flow. The discussions on

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2151075013 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on PR #17022: URL: https://github.com/apache/kafka/pull/17022#issuecomment-2978134097 @jolshan @mjsax—Another ping to check if we can merge... Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2143291551 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -790,14 +790,34 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2143261652 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2143175834 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

mjsax commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2141308186 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorSta

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

mjsax commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2141309397 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -790,14 +790,34 @@ public synchronized void maybeTransitionToErrorSta

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on PR #17022: URL: https://github.com/apache/kafka/pull/17022#issuecomment-2963868532 @jolshan @mjsax—Anything else we need to check before we can merge? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2138442177 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2138447310 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2136374381 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2133083297 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2133081835 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2133080898 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2133073450 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2122375192 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2122305073 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2116253746 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2116253121 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2116240713 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2112903427 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2112901807 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2112722933 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,25 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2112721563 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,21 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

k-raina commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2054686862 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

k-raina commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2054686862 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

k-raina commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2054686862 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,25 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2052656744 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,21 @@ public synchronized void maybeTransitionToErrorS

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2051355805 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,25 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2051351665 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,21 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2051350718 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -772,6 +779,14 @@ synchronized void handleFailedBatch(ProducerBatch

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2051330115 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -772,6 +779,14 @@ synchronized void handleFailedBatch(ProducerBatch

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2051328782 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -737,14 +737,21 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

mjsax commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2048203504 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -772,6 +779,14 @@ synchronized void handleFailedBatch(ProducerBatch ba