kirktrue commented on code in PR #17022:
URL: https://github.com/apache/kafka/pull/17022#discussion_r2051351665
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -737,14 +737,21 @@ public synchronized void
maybeTransitionToErrorState(RuntimeException exception)
}
synchronized void handleFailedBatch(ProducerBatch batch, RuntimeException
exception, boolean adjustSequenceNumbers) {
- maybeTransitionToErrorState(exception);
+ if (!isStaleBatch(batch) && !hasFatalError())
Review Comment:
> I will add another unit test or two to make sure this is a valid concern.
Turns out I already had a unit test for that:
`testBatchesReceivedAfterFatalError()`. If I remove the `!hasFatalError()`
condition that test fails:
```
TransactionalId foobar: Invalid transition attempted from state FATAL_ERROR
to state ABORTABLE_ERROR
java.lang.IllegalStateException: TransactionalId foobar: Invalid transition
attempted from state FATAL_ERROR to state ABORTABLE_ERROR
at
org.apache.kafka.clients.producer.internals.TransactionManager.transitionTo(TransactionManager.java:1082)
at
org.apache.kafka.clients.producer.internals.TransactionManager.transitionToAbortableError(TransactionManager.java:498)
at
org.apache.kafka.clients.producer.internals.TransactionManager.maybeTransitionToErrorState(TransactionManager.java:735)
at
org.apache.kafka.clients.producer.internals.TransactionManager.handleFailedBatch(TransactionManager.java:745)
at
org.apache.kafka.clients.producer.internals.TransactionManagerTest.testBatchesReceivedAfterFatalError(TransactionManagerTest.java:3987)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
