mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2718586479
They don't seem related. They are already flaky on trunk:
- [OffloadAndTxnConsumeFromLeaderTest >
executeTieredStorageTest](https://develocity.apache.org/scans/tests?search.relativeSta
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1991245995
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2298 @@ public class UnifiedLog {
public static final String STR
chia7712 commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1990521269
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2298 @@ public class UnifiedLog {
public static final String STR
chia7712 commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1990503354
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2298 @@ public class UnifiedLog {
public static final String STR
junrao commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1990203655
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2298 @@ public class UnifiedLog {
public static final String STRAY
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1990045638
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2298 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1990022562
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2298 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1983053004
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -200,8 +200,8 @@ public Optional latestEntry() {
* Returns the
chia7712 commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1989982292
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2298 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1989820203
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2298 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1987971699
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2292 @@ public class UnifiedLog {
public static final String STR
junrao commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1989729707
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -1038,7 +1040,7 @@ private[log] class Cleaner(val id: Int,
map: OffsetMap,
mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2714174251
I ran a few benchmarks on my laptop. For both trunk and my branch I ran a
single broker in combined mode with all default settings. All topics have a
single partition with all default se
junrao commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2711372677
Also, could you run some more perf tests like kafka-producer-perf-test.sh
and kafka-consumer-perf-test.sh to make sure there is no regression?
--
This is an automated message from the Ap
mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2711890242
> Also, could you run some more perf tests like kafka-producer-perf-test.sh
and kafka-consumer-perf-test.sh to make sure there is no regression?
Yes once we're happy with the rewri
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1988055534
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2302 @@ public class UnifiedLog {
public static final String STR
mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2708369200
Rebased on trunk and ported
https://github.com/apache/kafka/commit/40db001588047201a406ebe969d1d7d2d5eefd57
--
This is an automated message from the Apache Git Service.
To respond to t
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1986107143
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
junrao commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1985886395
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STRAY
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1983039558
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2292 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1982930003
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2292 @@ public class UnifiedLog {
public static final String STR
mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2701378571
No worries this happens :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
lucasbru commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2701372613
@mimaison The broken commit was reverted on trunk, sorry for that. For some
reason CI didn't run and I didn't notice.
--
This is an automated message from the Apache Git Service.
To re
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1981604968
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2701304492
The CI failure is caused by an issue in trunk, there's a PR to fix it:
https://github.com/apache/kafka/pull/19115
I'll rekick the CI, once #19115 is merged.
--
This is an automa
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1981276951
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1981230458
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1981225722
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1981217329
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1981152506
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1981166972
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1981156216
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1977414279
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -16,44 +16,2351 @@
*/
package org.apache.kafka.storage.internals.log;
+impo
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1977414967
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -16,44 +16,2351 @@
*/
package org.apache.kafka.storage.internals.log;
+impo
mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2694168281
Thanks @chia7712 for the review! I pushed an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1977352466
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -16,44 +16,2351 @@
*/
package org.apache.kafka.storage.internals.log;
+impo
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1977276265
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -16,44 +16,2351 @@
*/
package org.apache.kafka.storage.internals.log;
+impo
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1970379536
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -109,14 +103,17 @@ final class KafkaMetadataLog private (
}
private def handleAndConvertLogAppe
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1970379536
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -109,14 +103,17 @@ final class KafkaMetadataLog private (
}
private def handleAndConvertLogAppe
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1970374846
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -16,44 +16,2260 @@
*/
package org.apache.kafka.storage.internals.log;
+impo
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1970373181
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -16,44 +16,2260 @@
*/
package org.apache.kafka.storage.internals.log;
+impo
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1970373181
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -16,44 +16,2260 @@
*/
package org.apache.kafka.storage.internals.log;
+impo
42 matches
Mail list logo
