AndrewJSchofield merged PR #18500:
URL: https://github.com/apache/kafka/pull/18500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
sjhajharia commented on PR #18500:
URL: https://github.com/apache/kafka/pull/18500#issuecomment-2589206725
@AndrewJSchofield I fixed the comment. The build is not green, but the tests
look unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
AndrewJSchofield commented on code in PR #18500:
URL: https://github.com/apache/kafka/pull/18500#discussion_r1913816942
##
core/src/test/scala/unit/kafka/server/RequestQuotaTest.scala:
##
@@ -868,7 +871,7 @@ object RequestQuotaTest {
val SaslActions = Set(ApiKeys.SASL_HANDSHA
sjhajharia commented on PR #18500:
URL: https://github.com/apache/kafka/pull/18500#issuecomment-2587944692
I pushed a fix for the failing tests and it passed locally. In case the
build fails, I will take another look tomorrow.
--
This is an automated message from the Apache Git Service.
T
AndrewJSchofield commented on PR #18500:
URL: https://github.com/apache/kafka/pull/18500#issuecomment-2587588516
@sjhajharia I suspect some of the test failures are related to this PR.
Please investigate.
--
This is an automated message from the Apache Git Service.
To respond to the messa
apoorvmittal10 commented on code in PR #18500:
URL: https://github.com/apache/kafka/pull/18500#discussion_r1913225760
##
clients/src/main/java/org/apache/kafka/common/requests/DescribeShareGroupOffsetsResponse.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Fou
sjhajharia commented on code in PR #18500:
URL: https://github.com/apache/kafka/pull/18500#discussion_r1913198532
##
server/src/main/java/org/apache/kafka/network/RequestConvertToJson.java:
##
@@ -577,6 +581,8 @@ public static JsonNode request(AbstractRequest request) {
apoorvmittal10 commented on code in PR #18500:
URL: https://github.com/apache/kafka/pull/18500#discussion_r1913155988
##
server/src/main/java/org/apache/kafka/network/RequestConvertToJson.java:
##
@@ -577,6 +581,8 @@ public static JsonNode request(AbstractRequest request) {
sjhajharia commented on code in PR #18500:
URL: https://github.com/apache/kafka/pull/18500#discussion_r1912897983
##
clients/src/main/resources/common/message/DescribeShareGroupOffsetsRequest.json:
##
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under on
AndrewJSchofield commented on code in PR #18500:
URL: https://github.com/apache/kafka/pull/18500#discussion_r1912867262
##
clients/src/main/resources/common/message/DescribeShareGroupOffsetsRequest.json:
##
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) un
10 matches
Mail list logo
