apoorvmittal10 commented on code in PR #18500:
URL: https://github.com/apache/kafka/pull/18500#discussion_r1913155988
##########
server/src/main/java/org/apache/kafka/network/RequestConvertToJson.java:
##########
@@ -577,6 +581,8 @@ public static JsonNode request(AbstractRequest request) {
return
RemoveRaftVoterRequestDataJsonConverter.write(((RemoveRaftVoterRequest)
request).data(), request.version());
case UPDATE_RAFT_VOTER:
return
UpdateRaftVoterRequestDataJsonConverter.write(((UpdateRaftVoterRequest)
request).data(), request.version());
+ case DESCRIBE_SHARE_GROUP_OFFSETS:
+ return
DescribeShareGroupOffsetsRequestDataJsonConverter.write(((DescribeShareGroupOffsetsRequest)
request).data(), request.version());
Review Comment:
nit: This class generally follows order by name. Though it was messed
recently with above RAFT_VOTER related changes, shall we fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
