chia7712 commented on code in PR #17949:
URL: https://github.com/apache/kafka/pull/17949#discussion_r1861411178
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -106,13 +115,13 @@ public void setUp(TestInfo testInfo)
chia7712 merged PR #17949:
URL: https://github.com/apache/kafka/pull/17949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
cmccabe commented on PR #17949:
URL: https://github.com/apache/kafka/pull/17949#issuecomment-2504509772
- Removed modifications to
`core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala` and removed it
from the PR description
- Added reference to
`core/src/test/scala/integration/
cmccabe commented on code in PR #17949:
URL: https://github.com/apache/kafka/pull/17949#discussion_r1861069280
##
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala:
##
@@ -191,8 +182,9 @@ class AddPartitionsTest extends BaseRequestTest {
assertEquals(Set(0, 1), r
peterxcli commented on code in PR #17949:
URL: https://github.com/apache/kafka/pull/17949#discussion_r1860482737
##
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala:
##
@@ -191,8 +182,9 @@ class AddPartitionsTest extends BaseRequestTest {
assertEquals(Set(0, 1),
peterxcli commented on code in PR #17949:
URL: https://github.com/apache/kafka/pull/17949#discussion_r1860482737
##
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala:
##
@@ -191,8 +182,9 @@ class AddPartitionsTest extends BaseRequestTest {
assertEquals(Set(0, 1),
chia7712 commented on code in PR #17949:
URL: https://github.com/apache/kafka/pull/17949#discussion_r1860428172
##
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala:
##
@@ -217,8 +209,9 @@ class AddPartitionsTest extends BaseRequestTest {
validateLeaderAndReplica
cmccabe opened a new pull request, #17949:
URL: https://github.com/apache/kafka/pull/17949
Remove ZK from
- core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala
- core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala
- core/src/test/scala/unit/kafka/server/
