chia7712 commented on code in PR #17949:
URL: https://github.com/apache/kafka/pull/17949#discussion_r1860428172
##########
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala:
##########
@@ -217,8 +209,9 @@ class AddPartitionsTest extends BaseRequestTest {
validateLeaderAndReplicas(topicMetadata, 6, 0, Set(0, 1, 2, 3))
}
+ @Disabled
@ParameterizedTest
- @ValueSource(strings = Array("zk")) // TODO: add kraft support
+ @ValueSource(strings = Array("kraft")) // TODO: add kraft support
Review Comment:
ditto
##########
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala:
##########
@@ -191,8 +182,9 @@ class AddPartitionsTest extends BaseRequestTest {
assertEquals(Set(0, 1), replicas.asScala.toSet)
}
+ @Disabled
@ParameterizedTest
- @ValueSource(strings = Array("zk")) // TODO: add kraft support
+ @ValueSource(strings = Array("kraft")) // TODO: add kraft support
Review Comment:
We need to revisit this test to make it stable under KRaft. I've opened Jira
https://issues.apache.org/jira/browse/KAFKA-18098 to address it. Could you
please revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
