Re: [PR] MINOR: Disallow unused local variables [kafka]

lucasbru merged PR #18963: URL: https://github.com/apache/kafka/pull/18963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Disallow unused local variables [kafka]

mumrah commented on PR #18963: URL: https://github.com/apache/kafka/pull/18963#issuecomment-2707170074 @lucasbru yea, I think we gave enough time for any concerned parties to chime in :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Disallow unused local variables [kafka]

lucasbru commented on PR #18963: URL: https://github.com/apache/kafka/pull/18963#issuecomment-270647 @mumrah I have addressed all comments. Should we just go forward with this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Disallow unused local variables [kafka]

lucasbru commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1977199932 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -397,7 +397,7 @@ public void testStressfulSituation() throws Exc

Re: [PR] MINOR: Disallow unused local variables [kafka]

mjsax commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1976505917 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -397,7 +397,7 @@ public void testStressfulSituation() throws Except

Re: [PR] MINOR: Disallow unused local variables [kafka]

AndrewJSchofield commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1973200080 ## tools/src/main/java/org/apache/kafka/tools/ShareConsumerPerformance.java: ## @@ -79,7 +79,8 @@ public static void main(String[] args) { sha

Re: [PR] MINOR: Disallow unused local variables [kafka]

mumrah commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1971693097 ## tools/src/main/java/org/apache/kafka/tools/ShareConsumerPerformance.java: ## @@ -79,7 +79,8 @@ public static void main(String[] args) { shareConsumer

Re: [PR] MINOR: Disallow unused local variables [kafka]

lucasbru commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1971544479 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -885,7 +885,8 @@ public Set drainRestoredActiveTasks(final Durat

Re: [PR] MINOR: Disallow unused local variables [kafka]

lucasbru commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1971542987 ## tools/src/main/java/org/apache/kafka/tools/ShareConsumerPerformance.java: ## @@ -79,7 +79,8 @@ public static void main(String[] args) { shareConsum

Re: [PR] MINOR: Disallow unused local variables [kafka]

cadonna commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1971354797 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -885,7 +885,8 @@ public Set drainRestoredActiveTasks(final Durati

Re: [PR] MINOR: Disallow unused local variables [kafka]

mumrah commented on PR #18963: URL: https://github.com/apache/kafka/pull/18963#issuecomment-2683609144 @lucasbru try updating this PR with trunk. That should fix the build scan errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Disallow unused local variables [kafka]

lucasbru commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1970571792 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -885,7 +885,8 @@ public Set drainRestoredActiveTasks(final Durat

Re: [PR] MINOR: Disallow unused local variables [kafka]

lucasbru commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1970569977 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -2881,7 +2881,7 @@ private void verifySessionPartitions() {

Re: [PR] MINOR: Disallow unused local variables [kafka]

lucasbru commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1970569660 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/MonitorableSinkConnector.java: ## @@ -60,7 +60,7 @@ public void start(Map props) { @Over

Re: [PR] MINOR: Disallow unused local variables [kafka]

mumrah commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1970287405 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogLoader.java: ## @@ -169,6 +169,7 @@ public LoadedLogOffsets load() throws IOException {

Re: [PR] MINOR: Disallow unused local variables [kafka]

lucasbru commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1970132884 ## generator/src/main/java/org/apache/kafka/message/checker/EvolutionVerifier.java: ## @@ -74,7 +74,7 @@ static void verifyVersionsMatchTopLevelMessage( v