lucasbru commented on code in PR #18963:
URL: https://github.com/apache/kafka/pull/18963#discussion_r1971544479
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -885,7 +885,8 @@ public Set<StreamTask> drainRestoredActiveTasks(final
Duration timeout) {
restoredActiveTasksLock.lock();
try {
while (restoredActiveTasks.isEmpty() && now <= deadline) {
- final boolean elapsed =
restoredActiveTasksCondition.await(deadline - now, TimeUnit.MILLISECONDS);
+ @SuppressWarnings("UnusedLocalVariable")
+ final boolean ignored =
restoredActiveTasksCondition.await(deadline - now, TimeUnit.MILLISECONDS);
Review Comment:
I had to revert this. Spotbugs actually requires handling the return value
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
