Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe merged PR #18148: URL: https://github.com/apache/kafka/pull/18148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1927283540 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1558,12 +1562,12 @@ private QuorumController( setLogContext(log

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1926117043 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -165,7 +164,8 @@ private ConfigurationControlManager(LogContext logContext

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1926118367 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1558,12 +1562,12 @@ private QuorumController( setLogContext(logContext)

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1926117043 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -165,7 +164,8 @@ private ConfigurationControlManager(LogContext logContext

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1911783684 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -158,4 +158,9 @@ BrokersToIsrs.PartitionsOnReplicaIterator partitionsWithBroker

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1911567192 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -158,4 +158,9 @@ BrokersToIsrs.PartitionsOnReplicaIterator partitionsWithBrokerInElr(in

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #18148: URL: https://github.com/apache/kafka/pull/18148#discussion_r1911575014 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -352,6 +367,71 @@ private ApiError validateAlterConfig( return Ap

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

github-actions[bot] commented on PR #18148: URL: https://github.com/apache/kafka/pull/18148#issuecomment-2581657192 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

github-actions[bot] commented on PR #18148: URL: https://github.com/apache/kafka/pull/18148#issuecomment-2552708504 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on PR #15702: URL: https://github.com/apache/kafka/pull/15702#issuecomment-2537299181 Close this PR for https://github.com/apache/kafka/pull/18148 because there are too many things since this PR was opened. -- This is an automated message from the Apache Git Serv

[PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent opened a new pull request, #18148: URL: https://github.com/apache/kafka/pull/18148 https://issues.apache.org/jira/browse/KAFKA-16540 If the min isr config is changed, we need to update the partitions with ELR if possible. -- This is an automated message from the Apache

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent closed pull request #15702: Kafka-16540: Update partitions if min isr config is changed. URL: https://github.com/apache/kafka/pull/15702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1838830695 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -159,4 +160,12 @@ BrokersToIsrs.PartitionsOnReplicaIterator partitionsWithBrokerInElr(i

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

mumrah commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1672784230 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2225,9 +2250,14 @@ private void listReassigningTopic(ListPartitionReassignm

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

mumrah commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1672730022 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -500,9 +631,26 @@ boolean uncleanLeaderElectionEnabledForTopic(String name)

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

mumrah commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1671034456 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -309,6 +331,54 @@ private ApiError validateAlterConfig(ConfigResource conf

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1616598075 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -443,9 +525,33 @@ Map getConfigs(ConfigResource configResource) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614174475 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +330,48 @@ private ApiError validateAlterConfig(ConfigResou

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614174475 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +330,48 @@ private ApiError validateAlterConfig(ConfigResou

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614169536 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +330,48 @@ private ApiError validateAlterConfig(ConfigResou

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614159525 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResource con

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614158684 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +330,48 @@ private ApiError validateAlterConfig(ConfigResource con

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614157582 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -443,9 +525,33 @@ Map getConfigs(ConfigResource configResource) { *

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

cmccabe commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1614156696 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +330,48 @@ private ApiError validateAlterConfig(ConfigResource con

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1583446833 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResou

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1583424779 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResou

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1583423622 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -260,6 +279,7 @@ private ApiError incrementalAlterConfigResource(

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1583422586 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -159,4 +160,14 @@ BrokersToIsrs.PartitionsOnReplicaIterator partitionsWithBroke

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579894472 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -66,6 +69,7 @@ public class ConfigurationControlManager { private fin

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579888146 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResource con

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579886194 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -308,6 +328,48 @@ private ApiError validateAlterConfig(ConfigResource con

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579880592 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -260,6 +279,7 @@ private ApiError incrementalAlterConfigResource(

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1579872828 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java: ## @@ -159,4 +160,14 @@ BrokersToIsrs.PartitionsOnReplicaIterator partitionsWithBrokerInElr(i

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1569269269 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2117,6 +2117,20 @@ ListPartitionReassignmentsResponseData listPartitionRea

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1569214320 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2117,6 +2117,20 @@ ListPartitionReassignmentsResponseData listPart

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1569210550 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1568044239 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) { void ha

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1568084297 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2117,6 +2117,20 @@ ListPartitionReassignmentsResponseData listPartitionRea

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1568044239 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) { void ha

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566471100 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566455070 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566242343 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1566242343 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1564110479 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1563199330 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) { void ha

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1563195256 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) { l

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

splett2 commented on code in PR #15702: URL: https://github.com/apache/kafka/pull/15702#discussion_r1563193794 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -423,6 +441,17 @@ public void replay(ConfigRecord record) { l

Re: [PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent commented on PR #15702: URL: https://github.com/apache/kafka/pull/15702#issuecomment-2052041676 @mumrah Can you help take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

CalvinConfluent opened a new pull request, #15702: URL: https://github.com/apache/kafka/pull/15702 https://issues.apache.org/jira/browse/KAFKA-16540 If the min isr config is changed, we need to update the partitions with ELR if possible. -- This is an automated message from the Apache