mumrah commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1672784230
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -2225,9 +2250,14 @@ private void
listReassigningTopic(ListPartitionReassignmentsResponseData respons
}
// Visible to test.
- int getTopicEffectiveMinIsr(String topicName) {
+ int getTopicEffectiveMinIsr(String topicName, Function<String, String>
getTopicMinIsrConfig) {
int currentMinIsr = defaultMinIsr;
- String minIsrConfig = configurationControl.getTopicConfig(topicName,
MIN_IN_SYNC_REPLICAS_CONFIG);
+ String minIsrConfig;
+ if (getTopicMinIsrConfig == null) {
Review Comment:
Can we split the method into two signatures instead of having the null?
E.g., `int getTopicEffectiveMinIsr(String topicName)` and `int
getTopicEffectiveMinIsr(String topicName, Function<String, String>
getTopicMinIsrConfig)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
