Re: [PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

2025-04-07 Thread via GitHub
AndrewJSchofield merged PR #19369: URL: https://github.com/apache/kafka/pull/19369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

2025-04-06 Thread via GitHub
ShivsundarR commented on code in PR #19369: URL: https://github.com/apache/kafka/pull/19369#discussion_r2030220644 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -937,7 +938,7 @@ private void sendAcknowledgementsAndLeaveGroup(f

Re: [PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

2025-04-06 Thread via GitHub
ShivsundarR commented on code in PR #19369: URL: https://github.com/apache/kafka/pull/19369#discussion_r2030220618 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -971,9 +971,11 @@ private void handlePartitionError(Sha

Re: [PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

2025-04-05 Thread via GitHub
smjn commented on code in PR #19369: URL: https://github.com/apache/kafka/pull/19369#discussion_r2028490277 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -971,9 +971,11 @@ private void handlePartitionError(ShareAckno

[PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

2025-04-04 Thread via GitHub
ShivsundarR opened a new pull request, #19369: URL: https://github.com/apache/kafka/pull/19369 *What* Currently for ShareConsumers, if we receive an `UNKNOWN_TOPIC_OR_PARTITION` error code in the `ShareAcknowledgeResponse`, then we retry sending the acknowledgements until the timer expir