chia7712 commented on PR #18988:
URL: https://github.com/apache/kafka/pull/18988#issuecomment-2702645351
> Seems we can simplify the docker build and cleanup some more code as
follow up.
open https://issues.apache.org/jira/browse/KAFKA-18927
--
This is an automated message from the
mjsax commented on PR #18988:
URL: https://github.com/apache/kafka/pull/18988#issuecomment-2683785351
Merged to `trunk` and cherry-picked to `4.0` release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1970835148
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code upgrade
mjsax merged PR #18988:
URL: https://github.com/apache/kafka/pull/18988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ableegoldman commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1970784603
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code
mjsax commented on PR #18988:
URL: https://github.com/apache/kafka/pull/18988#issuecomment-2682606848
System test passed
http://ducktape-open-source-results.confluent.io.s3-website-us-west-2.amazonaws.com/confluent-open-source-kafka-branch-builder-system-test-results/?prefix=trunk/2025-02-25
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1968629610
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code upgrade
FrankYang0529 commented on PR #18988:
URL: https://github.com/apache/kafka/pull/18988#issuecomment-2678791165
> I think this change means we can also revert all the changes introduced
via
[d1952e8](https://github.com/apache/kafka/commit/d1952e854202c574c1c19a48b17cc00e9d2eccd5)
Yes,
ijuma commented on PR #18988:
URL: https://github.com/apache/kafka/pull/18988#issuecomment-2677116274
I think this change means we can also revert all the changes introduced via
https://github.com/apache/kafka/commit/d1952e854202c574c1c19a48b17cc00e9d2eccd5
cc @FrankYang0529
--
This is
ableegoldman commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964829107
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code
ableegoldman commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964830589
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -33,8 +33,7 @@
str(LATEST_3_3), str(LATEST_3_4), str(LATEST_3_5),
str(
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964810607
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code upgrade
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964810607
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code upgrade
ableegoldman commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964782789
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRe
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964759422
##
tests/kafkatest/tests/streams/streams_cooperative_rebalance_upgrade_test.py:
##
@@ -43,7 +43,10 @@ class StreamsCooperativeRebalanceUpgradeTest(Test):
second_boun
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964741210
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRejectZer
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964741210
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRejectZer
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964739710
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java:
##
@@ -108,106 +110,20 @@ public RebalanceProtocol rebalanceP
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964730450
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRejectZer
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964730450
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRejectZer
mjsax commented on PR #18988:
URL: https://github.com/apache/kafka/pull/18988#issuecomment-2673268004
\cc @dajac for visibility -- we want to get this into `4.0` release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964721171
##
tests/kafkatest/tests/streams/streams_cooperative_rebalance_upgrade_test.py:
##
@@ -43,7 +43,10 @@ class StreamsCooperativeRebalanceUpgradeTest(Test):
second_boun
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964718367
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -23,19 +23,18 @@
from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964718367
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -23,19 +23,18 @@
from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964718367
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -23,19 +23,18 @@
from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5
ableegoldman commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964714406
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRe
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964712710
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRejectZer
ableegoldman commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964711785
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRe
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964709874
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRejectZer
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964711072
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java:
##
@@ -54,30 +54,25 @@ public void configsShouldRejectZer
ableegoldman commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964709058
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java:
##
@@ -108,106 +110,20 @@ public RebalanceProtocol reb
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964708632
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java:
##
@@ -108,106 +110,20 @@ public RebalanceProtocol rebalanceP
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964705263
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code upgrade
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964656765
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java:
##
@@ -108,106 +111,19 @@ public RebalanceProtocol rebalanceP
mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964656500
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java:
##
@@ -108,106 +111,19 @@ public RebalanceProtocol rebalanceP
35 matches
Mail list logo
