AndrewJSchofield commented on code in PR #18521:
URL: https://github.com/apache/kafka/pull/18521#discussion_r1916190950
##
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##
@@ -1974,7 +1974,7 @@ private void warmup() throws InterruptedException {
}
}
-
smjn commented on PR #18521:
URL: https://github.com/apache/kafka/pull/18521#issuecomment-2591651340
> I also had a failure locally in `testConsumerCloseInGroupSequential`
because the number of records was incorrect. I expect it's unpredictable for
the more complex tests.
Then maybe
AndrewJSchofield commented on PR #18521:
URL: https://github.com/apache/kafka/pull/18521#issuecomment-2591243922
I also had a failure locally in `testConsumerCloseInGroupSequential` because
the number of records was incorrect. I expect it's unpredictable for the more
complex tests.
--
Th
smjn commented on PR #18521:
URL: https://github.com/apache/kafka/pull/18521#issuecomment-2590573714
> It seems to me that `testMultipleConsumersInGroupSequentialConsumption` is
flaky with this PR.
It appears that occasionally this error is happening
```
[2025-01-14 22:23:21,456
smjn commented on PR #18521:
URL: https://github.com/apache/kafka/pull/18521#issuecomment-2590526080
> It seems to me that `testMultipleConsumersInGroupSequentialConsumption` is
flaky with this PR.
No, it isn't flaky. I had written the verification condition incorrectly -
rectified
smjn commented on code in PR #18521:
URL: https://github.com/apache/kafka/pull/18521#discussion_r1914781299
##
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##
@@ -1922,6 +1930,40 @@ private void warmup() throws InterruptedException {
}
}
+private
smjn commented on code in PR #18521:
URL: https://github.com/apache/kafka/pull/18521#discussion_r1914781299
##
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##
@@ -1922,6 +1930,40 @@ private void warmup() throws InterruptedException {
}
}
+private
smjn commented on code in PR #18521:
URL: https://github.com/apache/kafka/pull/18521#discussion_r1914748449
##
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##
@@ -1922,6 +1930,40 @@ private void warmup() throws InterruptedException {
}
}
+private
AndrewJSchofield commented on code in PR #18521:
URL: https://github.com/apache/kafka/pull/18521#discussion_r1914742821
##
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##
@@ -1922,6 +1930,40 @@ private void warmup() throws InterruptedException {
}
}
smjn commented on code in PR #18521:
URL: https://github.com/apache/kafka/pull/18521#discussion_r1914637924
##
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##
@@ -1922,6 +1930,40 @@ private void warmup() throws InterruptedException {
}
}
+private
smjn commented on code in PR #18521:
URL: https://github.com/apache/kafka/pull/18521#discussion_r1914632045
##
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##
@@ -1922,6 +1930,40 @@ private void warmup() throws InterruptedException {
}
}
+private
AndrewJSchofield commented on code in PR #18521:
URL: https://github.com/apache/kafka/pull/18521#discussion_r1914571923
##
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##
@@ -1922,6 +1930,40 @@ private void warmup() throws InterruptedException {
}
}
smjn opened a new pull request, #18521:
URL: https://github.com/apache/kafka/pull/18521
- Currently, the tests using DefaultStatePersister do not perform any
validations on the __share_group_state topic to verify
the records.
- In this PR, we have added a small util method to do the sa
13 matches
Mail list logo
