AndrewJSchofield commented on code in PR #18521: URL: https://github.com/apache/kafka/pull/18521#discussion_r1916190950
########## core/src/test/java/kafka/test/api/ShareConsumerTest.java: ########## @@ -1974,7 +1974,7 @@ private void warmup() throws InterruptedException { } } - private void maybeVerifyShareGroupStateTopicRecordCount(String persister, int messageCount) { + private void maybeVerifyShareGroupStateTopicRecordCount(String persister) { Review Comment: The method name now seems redundant. I suggest `verifyShareGroupStateTopicRecordsProduced`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org