Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

github-actions[bot] commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-3134773632 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

jeffkbkim commented on code in PR #17981: URL: https://github.com/apache/kafka/pull/17981#discussion_r2029393164 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataStore.java: ## @@ -0,0 +1,688 @@ +/* + * Licensed to the Apache Software Foundation

[PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

aliehsaeedii opened a new pull request, #17981: URL: https://github.com/apache/kafka/pull/17981 This PR and the future following ones aim to refactor the big `GroupMetadataManager` class and split it into multiple classes. This PR specifically introduces the `GroupStore` class, which contai

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

github-actions[bot] closed pull request #17981: KAFKA-1826 [1/N]: Introducing GroupStore URL: https://github.com/apache/kafka/pull/17981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

github-actions[bot] commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-2774400276 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

github-actions[bot] commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-2696100790 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

aliehsaeedii commented on code in PR #17981: URL: https://github.com/apache/kafka/pull/17981#discussion_r1867833556 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupStore.java: ## @@ -0,0 +1,307 @@ +/* Review Comment: Thanks, @dajac, for the concept

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

lucasbru commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-2512029744 > > * Could we already make use of `GroupStore`, i.e. remove the corresponding functionality from `GroupMetadataManager` > > Thanks, @lucasbru. To remove the current `GroupStore` f

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

lucasbru commented on code in PR #17981: URL: https://github.com/apache/kafka/pull/17981#discussion_r1867399836 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupStore.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

dajac commented on code in PR #17981: URL: https://github.com/apache/kafka/pull/17981#discussion_r1867428898 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupStore.java: ## @@ -0,0 +1,307 @@ +/* Review Comment: @aliehsaeedii Thanks for working on th

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

aliehsaeedii commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-2514051943 > > > * Could we already make use of `GroupStore`, i.e. remove the corresponding functionality from `GroupMetadataManager` > > > > > > Thanks, @lucasbru. To remove the curr

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

aliehsaeedii commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-2511103283 > * Could we already make use of `GroupStore`, i.e. remove the corresponding functionality from `GroupMetadataManager` Thanks, @lucasbru. To remove the current `GroupStore` fu

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

aliehsaeedii commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-2511056058 Thanks, @dajac. I updated the PR description with a brief description of the high level design. [This closed PR](https://github.com/apache/kafka/pull/17941), contains all the changes

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

dajac commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-2508422020 Thanks @aliehsaeedii! I will definitely review it next week. Would it be possible to describe the high level design that you're aiming for? I would like to ensure that we are on the same pa

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

aliehsaeedii commented on code in PR #17981: URL: https://github.com/apache/kafka/pull/17981#discussion_r1863574816 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupStore.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software Foundation (ASF