lucasbru commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-2512029744
> > * Could we already make use of `GroupStore`, i.e. remove the corresponding functionality from `GroupMetadataManager` > > Thanks, @lucasbru. To remove the current `GroupStore` functionalities from the `GroupMetadataManager`, significant changes are required in several other classes, including `OffsetMetadataManager` and `GroupCoordinatorShard`. Additionally, their corresponding unit tests (and possibly integration tests?) will need to be updated. Given that these changes are not final and may be altered by subsequent pull requests, it does not seem practical to modify these classes at this stage. WDYT? Okay, I see. The point of replacing the functionality immediately would be that it is easier to track that all unit tests are being ported from the old to the new structure, since the unit tests are the only thing that stop us from breaking things here. But if you think it's too complicated, from my side it's okay to do it this way. Please take extra care retainingthe test coverage. I will give this a more detailed look tomorrow, but on a high level the approach looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
