jsancio merged PR #18240:
URL: https://github.com/apache/kafka/pull/18240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1919031445
##
checkstyle/suppressions.xml:
##
@@ -187,6 +187,9 @@
+
+
Review Comment:
Got it. Thanks.
--
This is an automated message from the Apache Git Servi
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1919024139
##
checkstyle/suppressions.xml:
##
@@ -187,6 +187,9 @@
+
+
Review Comment:
CI doesn't like the change either :(
```
Execution failed for task ':
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1919002962
##
checkstyle/suppressions.xml:
##
@@ -187,6 +187,9 @@
+
+
Review Comment:
locally, checkstyle seems to take issue w/ this particular check. I'll give
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1918980033
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -882,7 +921,15 @@ private boolean handleVoteResponse(
int remoteNodeId = responseMetad
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1918852989
##
raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java:
##
@@ -154,6 +155,163 @@ private ReplicaKey replicaKey(int id, boolean
withDirectoryId) {
re
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1918761915
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -562,6 +656,25 @@ public void transitionToCandidate() {
));
}
+private void chec
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1918935598
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -562,6 +656,25 @@ public void transitionToCandidate() {
));
}
+private void che
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1918931718
##
raft/src/main/java/org/apache/kafka/raft/ProspectiveState.java:
##
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1918748224
##
raft/src/main/java/org/apache/kafka/raft/ProspectiveState.java:
##
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917541053
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -1824,71 +1933,74 @@ UpdateRaftVoterResponseData updateVoterResponse(
}
priva
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917539718
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -197,9 +198,24 @@ public Builder(OptionalInt localId, Uuid localDirectoryId)
{
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917525983
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -972,21 +973,22 @@ public void
testProspectiveWithLeaderTransitionsToFollower(
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917526506
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -197,9 +198,24 @@ public Builder(OptionalInt localId, Uuid localDirectoryId)
{
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917512126
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -86,186 +99,249 @@ public void
testHandlePreVoteRequestAsFollowerWithElectedLeader(
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917518120
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -430,46 +531,57 @@ public void testLeaderAcceptPreVoteFromObserver() throws
Exceptio
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917398669
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -1824,71 +1933,74 @@ UpdateRaftVoterResponseData updateVoterResponse(
}
privat
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917512126
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -86,186 +99,249 @@ public void
testHandlePreVoteRequestAsFollowerWithElectedLeader(
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917512126
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -86,186 +99,249 @@ public void
testHandlePreVoteRequestAsFollowerWithElectedLeader(
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917459804
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -323,9 +324,21 @@ public void
testInitializeAsResignedAndBecomeCandidate(boolean withKip85
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917456559
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -323,9 +324,21 @@ public void
testInitializeAsResignedAndBecomeCandidate(boolean withKip85
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917454524
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -573,4 +700,450 @@ public void testRejectPreVoteIfRemoteLogIsNotUpToDate()
throws E
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917434854
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -573,4 +700,450 @@ public void testRejectPreVoteIfRemoteLogIsNotUpToDate()
throws E
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917424027
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -430,46 +531,57 @@ public void testLeaderAcceptPreVoteFromObserver() throws
Excepti
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917424027
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -430,46 +531,57 @@ public void testLeaderAcceptPreVoteFromObserver() throws
Excepti
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917419710
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -86,186 +99,249 @@ public void
testHandlePreVoteRequestAsFollowerWithElectedLeader(
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917177912
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -573,4 +700,450 @@ public void testRejectPreVoteIfRemoteLogIsNotUpToDate()
throws Ex
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917404175
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -197,9 +198,24 @@ public Builder(OptionalInt localId, Uuid localDirectoryId)
{
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917401126
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -1824,71 +1933,74 @@ UpdateRaftVoterResponseData updateVoterResponse(
}
privat
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917398687
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##
@@ -86,186 +99,249 @@ public void
testHandlePreVoteRequestAsFollowerWithElectedLeader(
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917398669
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -1824,71 +1933,74 @@ UpdateRaftVoterResponseData updateVoterResponse(
}
privat
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917380871
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -1824,71 +1933,74 @@ UpdateRaftVoterResponseData updateVoterResponse(
}
priva
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917376912
##
raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java:
##
@@ -154,6 +155,163 @@ private ReplicaKey replicaKey(int id, boolean
withDirectoryId) {
r
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917365519
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -629,40 +681,67 @@ void pollUntilRequest() throws InterruptedException {
}
vo
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917357351
##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -292,8 +308,16 @@ Builder
withBootstrapServers(Optional> bootstrapServers)
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917352224
##
raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java:
##
@@ -162,16 +218,18 @@ public void shouldRecordVoterQuorumState(KRaftVersion
kraftV
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1915429555
##
raft/src/test/java/org/apache/kafka/raft/UnattachedStateTest.java:
##
@@ -77,72 +84,134 @@ public void testElectionTimeout() {
@ParameterizedTest
@Value
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1915345255
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -305,7 +305,66 @@ void leadershipWillNotChangeIfMajorityIsReachable(
Cluster cl
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1902116235
##
raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java:
##
@@ -162,16 +218,18 @@ public void shouldRecordVoterQuorumState(KRaftVersion
kraftV
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1902114352
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -302,7 +303,7 @@ public void testGrantVotesWhenShuttingDown(boolean
withKip853Rpc) throws
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1902113084
##
raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java:
##
@@ -154,6 +155,163 @@ private ReplicaKey replicaKey(int id, boolean
withDirectoryId) {
r
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1901142655
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -550,9 +550,10 @@ public void initialize(
onBecomeFollower(currentTimeMs);
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1901142655
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -550,9 +550,10 @@ public void initialize(
onBecomeFollower(currentTimeMs);
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1901235462
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -667,7 +668,8 @@ private boolean maybeTransitionToLeader(CandidateState
state, long currentTim
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1901142655
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -550,9 +550,10 @@ public void initialize(
onBecomeFollower(currentTimeMs);
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1901117479
##
raft/src/main/java/org/apache/kafka/raft/NomineeState.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1901113187
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -985,36 +982,54 @@ private boolean handleVoteResponse(
maybeTransitionForwa
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900951176
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -667,7 +668,8 @@ private boolean maybeTransitionToLeader(CandidateState
state, long currentTime
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900648700
##
raft/src/main/java/org/apache/kafka/raft/NomineeState.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900621199
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -562,6 +653,26 @@ public void transitionToCandidate() {
));
}
+private void che
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900621199
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -562,6 +653,26 @@ public void transitionToCandidate() {
));
}
+private void che
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900614259
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -562,6 +653,26 @@ public void transitionToCandidate() {
));
}
+private void che
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900606997
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -249,7 +246,7 @@ public void initialize(OffsetAndEpoch logEndOffsetAndEpoch)
throws IllegalStateE
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900583739
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -529,26 +592,54 @@ public void transitionToFollower(int epoch, int leaderId,
Endpoints endpoints)
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900583739
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -529,26 +592,54 @@ public void transitionToFollower(int epoch, int leaderId,
Endpoints endpoints)
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900580715
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3026,20 +3099,51 @@ private long pollCandidate(long currentTimeMs) {
return Math.
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900571487
##
raft/src/main/java/org/apache/kafka/raft/FollowerState.java:
##
@@ -75,7 +79,7 @@ public FollowerState(
@Override
public ElectionState election() {
-
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900546362
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -985,36 +982,54 @@ private boolean handleVoteResponse(
maybeTransitionForw
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900541138
##
raft/src/main/java/org/apache/kafka/raft/internals/EpochElection.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1900540449
##
raft/src/main/java/org/apache/kafka/raft/internals/EpochElection.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899778973
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -985,36 +982,54 @@ private boolean handleVoteResponse(
maybeTransitionForwa
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899774561
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -957,13 +998,33 @@ private boolean handleVoteResponse(
}
}
+private void may
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899774561
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -957,13 +998,33 @@ private boolean handleVoteResponse(
}
}
+private void may
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899773951
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) {
}
/**
- * Grant
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899727021
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) {
}
/**
- * Grant
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899726857
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) {
}
/**
- * Grant
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899726228
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2935,14 +3014,18 @@ private long pollResigned(long currentTimeMs) {
// until eith
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899633981
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2935,14 +3014,18 @@ private long pollResigned(long currentTimeMs) {
// until eithe
ahuang98 commented on PR #18240:
URL: https://github.com/apache/kafka/pull/18240#issuecomment-2565744411
> It makes sense to me that after the resign state the replica should always
increase its epoch. The replica resigned from leadership at epoch X so
eventually the epoch will be at least
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899579689
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -39,40 +39,47 @@
* how they are triggered:
*
* Resigned transitions to:
- *Unattached: Aft
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1896952514
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -926,29 +978,18 @@ private boolean handleVoteResponse(
if (quorum.isLeader()) {
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1896953461
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3026,20 +3088,46 @@ private long pollCandidate(long currentTimeMs) {
return Math.m
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1890534655
##
raft/src/main/java/org/apache/kafka/raft/EpochElection.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * cont
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899071006
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -926,29 +978,18 @@ private boolean handleVoteResponse(
if (quorum.isLeader()) {
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899044657
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2442,10 +2503,10 @@ private void maybeTransition(
" and epoch " + epoch + " w
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899341945
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2935,14 +3014,18 @@ private long pollResigned(long currentTimeMs) {
// until eith
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899341945
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2935,14 +3014,18 @@ private long pollResigned(long currentTimeMs) {
// until eith
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899341945
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2935,14 +3014,18 @@ private long pollResigned(long currentTimeMs) {
// until eith
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899077542
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -957,13 +998,33 @@ private boolean handleVoteResponse(
}
}
+private void ma
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899076157
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -957,13 +998,33 @@ private boolean handleVoteResponse(
}
}
+private void ma
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899074463
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) {
}
/**
- * Grant
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899074255
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) {
}
/**
- * Grant
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899072269
##
raft/src/main/java/org/apache/kafka/raft/ProspectiveState.java:
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899071006
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -926,29 +978,18 @@ private boolean handleVoteResponse(
if (quorum.isLeader()) {
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899071006
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -926,29 +978,18 @@ private boolean handleVoteResponse(
if (quorum.isLeader()) {
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1899044657
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2442,10 +2503,10 @@ private void maybeTransition(
" and epoch " + epoch + " w
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1897014715
##
raft/src/main/java/org/apache/kafka/raft/UnattachedState.java:
##
@@ -71,13 +73,7 @@ public UnattachedState(
@Override
public ElectionState election() {
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1897014715
##
raft/src/main/java/org/apache/kafka/raft/UnattachedState.java:
##
@@ -71,13 +73,7 @@ public UnattachedState(
@Override
public ElectionState election() {
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1897013977
##
raft/src/main/java/org/apache/kafka/raft/UnattachedState.java:
##
@@ -71,13 +73,7 @@ public UnattachedState(
@Override
public ElectionState election() {
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1897013977
##
raft/src/main/java/org/apache/kafka/raft/UnattachedState.java:
##
@@ -71,13 +73,7 @@ public UnattachedState(
@Override
public ElectionState election() {
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1897006321
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) {
}
/**
- * Grant
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1896920647
##
raft/src/main/java/org/apache/kafka/raft/CandidateState.java:
##
@@ -299,13 +205,12 @@ public boolean canGrantVote(
@Override
public String toString() {
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1895926505
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -39,40 +39,47 @@
* how they are triggered:
*
* Resigned transitions to:
- *Unattached: Af
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1895926505
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -39,40 +39,47 @@
* how they are triggered:
*
* Resigned transitions to:
- *Unattached: Af
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1895898210
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -657,14 +657,40 @@ private void flushLeaderLog(LeaderState state, long
currentTimeMs) {
}
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1894260795
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -226,7 +221,7 @@ public void initialize(OffsetAndEpoch logEndOffsetAndEpoch)
throws IllegalStateE
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1890678659
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -883,6 +923,13 @@ private boolean handleVoteResponse(
VoteResponseData response = (Vote
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1890660800
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -883,6 +923,13 @@ private boolean handleVoteResponse(
VoteResponseData response = (Vot
ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1890660800
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -883,6 +923,13 @@ private boolean handleVoteResponse(
VoteResponseData response = (Vot
jsancio commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1890554341
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -926,29 +973,16 @@ private boolean handleVoteResponse(
if (quorum.isLeader()) {
1 - 100 of 101 matches
Mail list logo
