ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917512126
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientPreVoteTest.java:
##########
@@ -86,186 +99,249 @@ public void
testHandlePreVoteRequestAsFollowerWithElectedLeader(boolean hasFetch
assertTrue(context.client.quorum().isUnattachedNotVoted());
}
- @Test
- public void testHandlePreVoteRequestAsCandidate() throws Exception {
+ @ParameterizedTest
+ @EnumSource(value = KRaftVersion.class)
+ public void
testHandlePreVoteRequestAsFollowerWithVotedCandidate(KRaftVersion kraftVersion)
throws Exception {
+ int localId = randomReplicaId();
+ int epoch = 2;
+ ReplicaKey localKey = replicaKey(localId, true);
+ ReplicaKey otherNodeKey = replicaKey(localId + 1, true);
+ ReplicaKey votedCandidateKey = replicaKey(localId + 2, true);
+ VoterSet voters = VoterSetTest.voterSet(Stream.of(localKey,
otherNodeKey, votedCandidateKey));
+
+ RaftClientTestContext context = new
RaftClientTestContext.Builder(localKey, voters, kraftVersion)
+ .withVotedCandidate(epoch, votedCandidateKey)
+ .withRaftProtocol(KIP_996_PROTOCOL)
+ .build();
+ context.pollUntilRequest();
+ context.assertSentFetchRequest();
Review Comment:
ah, this actually clears the mock send queue (otherwise the following check
`RaftRequest.Outbound fetchRequest = context.assertSentFetchRequest();` fails
due to unexpected number of requests in send queue)
it works to remove the poll and clear the expected fetch later in the test,
so I'll do that instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
