Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
mumrah commented on PR #18602: URL: https://github.com/apache/kafka/pull/18602#issuecomment-2599523365 @chia7712 I think this commit should fix the initialization issue. Since SPI is being used, it loads the extension for all tests. We need some additional filtering to not apply the Cluster

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
mumrah commented on code in PR #18602: URL: https://github.com/apache/kafka/pull/18602#discussion_r1920952622 ## test-common/test-common-api/src/main/java/org/apache/kafka/common/test/api/README.md: ## @@ -79,7 +79,7 @@ a JUnit extension called `ClusterTestExtensions` which know

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
mumrah commented on code in PR #18602: URL: https://github.com/apache/kafka/pull/18602#discussion_r1920951057 ## core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala: ## @@ -19,13 +19,15 @@ package kafka.server import kafka.api.{KafkaSasl, SaslSetup} import k

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
mumrah commented on code in PR #18602: URL: https://github.com/apache/kafka/pull/18602#discussion_r1920950898 ## build.gradle: ## @@ -1364,6 +1365,9 @@ project(':metadata') { testImplementation project(':raft').sourceSets.test.output testImplementation project(':server

Re: [PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
chia7712 commented on code in PR #18602: URL: https://github.com/apache/kafka/pull/18602#discussion_r1920938027 ## build.gradle: ## @@ -1364,6 +1365,9 @@ project(':metadata') { testImplementation project(':raft').sourceSets.test.output testImplementation project(':serv

[PR] KAFKA-17587 Refactor test infrastructure [kafka]

2025-01-17 Thread via GitHub
mumrah opened a new pull request, #18602: URL: https://github.com/apache/kafka/pull/18602 This patch reorganizes our test infrastructure into three Gradle modules: ":test-common:test-common-api" is now a minimal dependency which exposes interfaces and annotations only. It has one proj