Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-03-05 Thread via GitHub
mingdaoy commented on code in PR #19082: URL: https://github.com/apache/kafka/pull/19082#discussion_r1982210800 ## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java: ## @@ -190,7 +190,7 @@ private void setState(State state) { priv

Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-03-05 Thread via GitHub
mingdaoy commented on code in PR #19082: URL: https://github.com/apache/kafka/pull/19082#discussion_r1982214194 ## metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java: ## @@ -173,7 +173,8 @@ byte[] saltedPassword(byte[] salt, int iterations) throws Excepti

Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-03-05 Thread via GitHub
mingdaoy commented on code in PR #19082: URL: https://github.com/apache/kafka/pull/19082#discussion_r198021 ## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java: ## @@ -190,7 +190,7 @@ private void setState(State state) { priv

Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-03-05 Thread via GitHub
mingdaoy commented on code in PR #19082: URL: https://github.com/apache/kafka/pull/19082#discussion_r1982207332 ## metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java: ## @@ -173,7 +173,9 @@ byte[] saltedPassword(byte[] salt, int iterations) throws Excepti

Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-03-05 Thread via GitHub
mingdaoy commented on code in PR #19082: URL: https://github.com/apache/kafka/pull/19082#discussion_r1982216871 ## core/src/main/scala/kafka/server/DelegationTokenManager.scala: ## @@ -100,13 +100,13 @@ class DelegationTokenManager(val config: KafkaConfig, } /** - * @p

Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-03-05 Thread via GitHub
mingdaoy commented on code in PR #19082: URL: https://github.com/apache/kafka/pull/19082#discussion_r1982214194 ## metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java: ## @@ -173,7 +173,8 @@ byte[] saltedPassword(byte[] salt, int iterations) throws Excepti

Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-03-05 Thread via GitHub
szetszwo commented on code in PR #19082: URL: https://github.com/apache/kafka/pull/19082#discussion_r1981829797 ## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java: ## @@ -190,7 +190,7 @@ private void setState(State state) { priv

[PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

2025-03-03 Thread via GitHub
mingdaoy opened a new pull request, #19082: URL: https://github.com/apache/kafka/pull/19082 https://issues.apache.org/jira/browse/KAFKA-17014 Update `saltedPassword`, `generateCredential`, and `normalize` to use `char[]` for password handling ``` Gradle Test Run :clients:tes