chia7712 merged PR #15897:
URL: https://github.com/apache/kafka/pull/15897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 commented on PR #15897:
URL: https://github.com/apache/kafka/pull/15897#issuecomment-2105938682
> @FrankYang0529 Could you please rebase code to trigger QA again?
Yes, rebased it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the me
chia7712 commented on PR #15897:
URL: https://github.com/apache/kafka/pull/15897#issuecomment-2105932005
@FrankYang0529 Could you please rebase code to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1597349032
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.extension.ExtendWith
class ApiVersionsRequest
lianetm commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1596833496
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -33,7 +33,7 @@
@Retention(RUNTIME)
@TestTemplate
public @interface ClusterTest {
-Type cluste
FrankYang0529 commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1596463798
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -33,7 +33,7 @@
@Retention(RUNTIME)
@TestTemplate
public @interface ClusterTest {
-Type
chia7712 commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1596459155
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -33,7 +33,7 @@
@Retention(RUNTIME)
@TestTemplate
public @interface ClusterTest {
-Type clust
chia7712 commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1596178459
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -33,7 +33,7 @@
@Retention(RUNTIME)
@TestTemplate
public @interface ClusterTest {
-Type clust
chia7712 commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1596176943
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -219,8 +221,8 @@ public static class Builder {
private Builder() {}
-public Builder set
lianetm commented on PR #15897:
URL: https://github.com/apache/kafka/pull/15897#issuecomment-2103291571
Thanks for the patch @FrankYang0529, nice twist. Left some comments. Also
there are examples for the `ClusterTest` annotation in the [core README
file](https://github.com/apache/kafka/blo
lianetm commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1595878217
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -33,7 +33,7 @@
@Retention(RUNTIME)
@TestTemplate
public @interface ClusterTest {
-Type cluste
lianetm commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1595878217
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -33,7 +33,7 @@
@Retention(RUNTIME)
@TestTemplate
public @interface ClusterTest {
-Type cluste
lianetm commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1595849504
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -219,8 +221,8 @@ public static class Builder {
private Builder() {}
-public Builder setT
chia7712 commented on PR #15897:
URL: https://github.com/apache/kafka/pull/15897#issuecomment-2102437430
> We may need a new attribute in ClusterInstance, so we can know whether the
cluster is CO_KRAFT or KRAFT.
you are right.
--
This is an automated message from the Apache Git Ser
FrankYang0529 commented on PR #15897:
URL: https://github.com/apache/kafka/pull/15897#issuecomment-2102406354
Hi @chia7712, I change `List` to `Set`.
For merging `ClusterTest` in `MetadataQuorumCommandTest.java`. I think it
can't work, because `cluster.config().clusterTypes().contains
chia7712 commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1594892743
##
tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java:
##
@@ -73,7 +74,7 @@ public void testDescribeQuorumReplicationSuccessful() throws
Interr
FrankYang0529 opened a new pull request, #15897:
URL: https://github.com/apache/kafka/pull/15897
Both ClusterType#ALL and ClusterType#DEFAULT are a kind of "tag" instead of
true "type". It seems to me they can be removed by using Array. For example:
ClusterType#ALL -> {Type.ZK, Type.K
17 matches
Mail list logo
