chia7712 commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1596178459
##########
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##########
@@ -33,7 +33,7 @@
@Retention(RUNTIME)
@TestTemplate
public @interface ClusterTest {
- Type clusterType() default Type.DEFAULT;
+ Type[] clusterTypes() default {};
Review Comment:
> so wonder if having the full list as default here would be a good
complementary change?
> It would mean that we have well defined ClusterTypes as introduced by this
PR, but every test running on ClusterTest would run for all types, unless
specified. That removes lots of clusterTypes = {Type.ZK, Type.KRAFT,
Type.CO_KRAFT}, it's probably the default behaviour we want for a test so that
no ones accidentally forgets to run on any specific cluster type, and makes it
easier to maintain (keeping the full list only in this single place, not on
every test). Thoughts?
I love this idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
