jeqo opened a new pull request, #19331:
URL: https://github.com/apache/kafka/pull/19331
Backports f24945b519005c0bc7a28db2db7aae6cec158927 to 4.0
Instead of reopening the transaction index, it cancels the RemoteFetchTask
without interrupting it--avoiding to close the TransactionIndex
jeqo commented on PR #19150:
URL: https://github.com/apache/kafka/pull/19150#issuecomment-2768303521
Opened https://github.com/apache/kafka/pull/19331 for 4.0 backport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
junrao merged PR #19331:
URL: https://github.com/apache/kafka/pull/19331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
junrao commented on PR #19331:
URL: https://github.com/apache/kafka/pull/19331#issuecomment-2770893528
@jeqo : Thanks for triaging the test failure. Merging the PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
jeqo commented on PR #19331:
URL: https://github.com/apache/kafka/pull/19331#issuecomment-2770831246
@junrao No. All flaky tests that when run locally are passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
junrao commented on PR #19150:
URL: https://github.com/apache/kafka/pull/19150#issuecomment-2770691900
@jeqo : Thanks for the reply. Merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
junrao merged PR #19150:
URL: https://github.com/apache/kafka/pull/19150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
jeqo commented on PR #19150:
URL: https://github.com/apache/kafka/pull/19150#issuecomment-2768268590
The test failure seem unrelated, yes. Tested all failing tests locally and
they passed:
- TransactionsWithTieredStoreTest
- ConsumerBounceTest
- PurgeRepartitionTopicIntegrationT
junrao commented on PR #19150:
URL: https://github.com/apache/kafka/pull/19150#issuecomment-2766546135
Also, do you plan to do a cherry-pick for 4.0 too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jeqo commented on PR #19150:
URL: https://github.com/apache/kafka/pull/19150#issuecomment-2760932180
@junrao I've updated the PR with the latest fix. PTAL, many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
junrao merged PR #19197:
URL: https://github.com/apache/kafka/pull/19197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
jeqo commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r2005443165
##
core/src/main/scala/kafka/server/DelayedRemoteFetch.scala:
##
@@ -88,8 +90,9 @@ class DelayedRemoteFetch(remoteFetchTask: Future[Void],
override def onExpiration()
junrao commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r2003759304
##
core/src/main/scala/kafka/server/DelayedRemoteFetch.scala:
##
@@ -88,8 +90,9 @@ class DelayedRemoteFetch(remoteFetchTask: Future[Void],
override def onExpiration
jeqo commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r2002944925
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1558,7 +1559,7 @@ class ReplicaManager(val config: KafkaConfig,
}
val remoteFetchMaxWaitMs =
junrao commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r2002060469
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1558,7 +1559,7 @@ class ReplicaManager(val config: KafkaConfig,
}
val remoteFetchMaxWaitMs =
jeqo commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r2001529749
##
core/src/main/java/kafka/log/remote/RemoteLogReader.java:
##
@@ -57,8 +59,18 @@ public RemoteLogReader(RemoteStorageFetchInfo fetchInfo,
this.remoteReadTimer =
jeqo commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r2001527540
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1544,12 +1544,14 @@ class ReplicaManager(val config: KafkaConfig,
fetchP
jeqo commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r2001498693
##
core/src/main/scala/kafka/server/DelayedRemoteFetch.scala:
##
@@ -119,6 +118,9 @@ class DelayedRemoteFetch(remoteFetchTask: Future[Void],
false)
}
junrao commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r1995965819
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1544,12 +1544,14 @@ class ReplicaManager(val config: KafkaConfig,
fetc
jeqo commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r1994541530
##
core/src/main/java/kafka/log/remote/RemoteLogReader.java:
##
@@ -57,8 +59,18 @@ public RemoteLogReader(RemoteStorageFetchInfo fetchInfo,
this.remoteReadTimer =
junrao commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r1994095620
##
core/src/main/scala/kafka/server/DelayedRemoteFetch.scala:
##
@@ -88,8 +90,9 @@ class DelayedRemoteFetch(remoteFetchTask: Future[Void],
override def onExpiration
jeqo opened a new pull request, #19197:
URL: https://github.com/apache/kafka/pull/19197
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some comment
22 matches
Mail list logo
