junrao commented on code in PR #19197:
URL: https://github.com/apache/kafka/pull/19197#discussion_r2002060469
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1558,7 +1559,7 @@ class ReplicaManager(val config: KafkaConfig,
}
val remoteFetchMaxWaitMs =
config.remoteLogManagerConfig.remoteFetchMaxWaitMs().toLong
- val remoteFetch = new DelayedRemoteFetch(remoteFetchTask,
remoteFetchResult, remoteFetchInfo, remoteFetchMaxWaitMs,
+ val remoteFetch = new DelayedRemoteFetch(remoteFetchFuture,
remoteFetchInfo, remoteFetchMaxWaitMs,
Review Comment:
Since we only need to pass in `remoteFetchTask` and `remoteFetchResult`, it
seems that it's simpler to just pass them in separately as before, instead of
wrapping them under `RemoteFetchFuture`.
##########
core/src/main/scala/kafka/server/DelayedRemoteFetch.scala:
##########
@@ -18,6 +18,7 @@
package kafka.server
import com.yammer.metrics.core.Meter
+import kafka.log.remote.RemoteLogReader
Review Comment:
unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
