tisonkun commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1625260173
##
clients/src/main/resources/common/message/BrokerHeartbeatRequest.json:
##
@@ -30,6 +30,8 @@
{ "name": "WantFence", "type": "bool", "versions": "0+",
"ab
aiven-anton commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1417450738
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -14,14 +14,16 @@
// limitations under the License.
// Version 1 adds Zk broke
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1417380722
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -14,14 +14,16 @@
// limitations under the License.
// Version 1 adds Zk broker epo
aiven-anton commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1415703531
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -14,14 +14,16 @@
// limitations under the License.
// Version 1 adds Zk broke
rondagostino commented on PR #14290:
URL: https://github.com/apache/kafka/pull/14290#issuecomment-1790802078
Should have included the below information as additional description in the
commit to `trunk` -- I forgot to. Damn.
Schema changes in API messages and metadata records for
[K
rondagostino merged PR #14290:
URL: https://github.com/apache/kafka/pull/14290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
rondagostino commented on PR #14290:
URL: https://github.com/apache/kafka/pull/14290#issuecomment-1790759618
Failing tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1379053726
##
metadata/src/main/java/org/apache/kafka/common/errors/InvalidReplicaDirectoriesException.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation
pprovenzano commented on PR #14290:
URL: https://github.com/apache/kafka/pull/14290#issuecomment-1789220297
LGTM too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1378929413
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -102,6 +112,8 @@ public Builder setPartitionEpoch(Integer partitionEpoch) {
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1378018066
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -16,55 +16,166 @@
*/
package org.apache.kafka.common;
+import java.util.ArrayList;
+i
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1377982321
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -16,55 +16,166 @@
*/
package org.apache.kafka.common;
+import java.util.ArrayList;
+
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1377451178
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -16,55 +16,166 @@
*/
package org.apache.kafka.common;
+import java.util.ArrayList;
+i
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1377451454
##
clients/src/main/java/org/apache/kafka/common/errors/InvalidMetadataException.java:
##
@@ -19,7 +19,7 @@
/**
* An exception that may indicate the client's metadata
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376808429
##
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##
@@ -47,6 +47,8 @@
"about": "The eligible leader replicas of this partition." },
{ "n
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376807529
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -16,55 +16,166 @@
*/
package org.apache.kafka.common;
+import java.util.ArrayList;
+
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376805476
##
clients/src/main/java/org/apache/kafka/common/errors/InvalidMetadataException.java:
##
@@ -19,7 +19,7 @@
/**
* An exception that may indicate the client's metadat
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376787884
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -310,11 +337,22 @@ public ApiMessageAndVersion toRecord(Uuid topicId, int
partitio
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376787569
##
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##
@@ -49,12 +51,15 @@
import static org.junit.jupiter.api.Assertions.assertFalse
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376787303
##
clients/src/main/java/org/apache/kafka/common/errors/InvalidMetadataException.java:
##
@@ -19,7 +19,7 @@
/**
* An exception that may indicate the client's metadata
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376334060
##
clients/src/main/java/org/apache/kafka/common/errors/InvalidMetadataException.java:
##
@@ -19,7 +19,7 @@
/**
* An exception that may indicate the client's me
soarez commented on PR #14290:
URL: https://github.com/apache/kafka/pull/14290#issuecomment-1784190438
Thanks for the review @cmccabe. Sorry it took me a bit longer to update
this.
> do you want one of us to jump in and fix these comments like we talked
about earlier
I'm not
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1375490118
##
clients/src/main/resources/common/message/AssignReplicasToDirsRequest.json:
##
@@ -0,0 +1,40 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1375440261
##
clients/src/main/resources/common/message/AssignReplicasToDirsRequest.json:
##
@@ -0,0 +1,40 @@
+// Licensed to the Apache Software Foundation (ASF) under one o
cmccabe commented on PR #14290:
URL: https://github.com/apache/kafka/pull/14290#issuecomment-1783251459
Thanks for the PR, @soarez ! Do you have revisions ready for this one or do
you want one of us to jump in and fix these comments like we talked about
earlier? I feel like it's really clos
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1374843847
##
clients/src/main/resources/common/message/AssignReplicasToDirsRequest.json:
##
@@ -0,0 +1,40 @@
+// Licensed to the Apache Software Foundation (ASF) under one or mor
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1371865719
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -54,6 +54,7 @@ public static boolean
changeRecordIsNoOp(PartitionChangeRe
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1371825053
##
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##
@@ -47,6 +47,13 @@
"about": "The eligible leader replicas of this partition." },
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1371390386
##
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##
@@ -47,6 +47,13 @@
"about": "The eligible leader replicas of this partition." },
{ "n
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1371372722
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -54,6 +54,7 @@ public static boolean
changeRecordIsNoOp(PartitionChangeRecord r
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1368928056
##
metadata/src/main/resources/common/metadata/BrokerRegistrationChangeRecord.json:
##
@@ -13,11 +13,12 @@
// See the License for the specific language governing
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1368454022
##
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##
@@ -47,6 +47,13 @@
"about": "The eligible leader replicas of this partition." },
{ "n
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1367992020
##
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##
@@ -17,9 +17,9 @@
"apiKey": 3,
"type": "metadata",
"name": "PartitionRecord",
- "
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1367993770
##
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##
@@ -47,6 +47,13 @@
"about": "The eligible leader replicas of this partition." },
clolov commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1360381987
##
clients/src/main/resources/common/message/BrokerHeartbeatRequest.json:
##
@@ -18,7 +18,7 @@
"type": "request",
"listeners": ["controller"],
"name": "BrokerHe
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1358495702
##
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##
@@ -411,7 +420,7 @@ public void testUncleanLeaderElection() {
clolov commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1358366617
##
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##
@@ -411,7 +420,7 @@ public void testUncleanLeaderElection() {
clolov commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1358368612
##
metadata/src/main/resources/common/metadata/PartitionChangeRecord.json:
##
@@ -40,6 +41,14 @@
"versions": "0+", "nullableVersions": "0+", "taggedVersions": "0+
soarez commented on PR #14290:
URL: https://github.com/apache/kafka/pull/14290#issuecomment-1761603067
Thanks for the review @clolov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1358332456
##
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##
@@ -1170,6 +1174,71 @@ private ConsumerGroupDescribeResponse
createConsumerGroupD
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1358325661
##
metadata/src/main/resources/common/metadata/PartitionChangeRecord.json:
##
@@ -40,6 +41,14 @@
"versions": "0+", "nullableVersions": "0+", "taggedVersions": "0+
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1358322899
##
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##
@@ -411,7 +420,7 @@ public void testUncleanLeaderElection() {
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1358318177
##
clients/src/main/resources/common/message/BrokerHeartbeatRequest.json:
##
@@ -18,7 +18,7 @@
"type": "request",
"listeners": ["controller"],
"name": "BrokerHe
clolov commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1357906933
##
metadata/src/main/resources/common/metadata/PartitionChangeRecord.json:
##
@@ -40,6 +41,14 @@
"versions": "0+", "nullableVersions": "0+", "taggedVersions": "0+
clolov commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1356485990
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1355927097
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions
clolov commented on PR #14290:
URL: https://github.com/apache/kafka/pull/14290#issuecomment-1755706472
I am putting myself as a reviewer because I would like to keep up to date
with these changes. I will aim to provide my review tomorrow!
--
This is an automated message from the Apache Gi
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1349439010
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1348135503
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1347691779
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1346091394
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVer
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1345336375
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1344800706
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -53,6 +53,8 @@
{ "name": "Rack", "type": "string", "versions": "0+", "nullableVe
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1344799188
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1344732697
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -53,6 +53,8 @@
{ "name": "Rack", "type": "string", "versions": "0+", "nulla
55 matches
Mail list logo
