aiven-anton commented on code in PR #14290: URL: https://github.com/apache/kafka/pull/14290#discussion_r1415703531
########## clients/src/main/resources/common/message/BrokerRegistrationRequest.json: ########## @@ -14,14 +14,16 @@ // limitations under the License. // Version 1 adds Zk broker epoch to the request if the broker is migrating from Zk mode to KRaft mode. -// + // Version 2 adds the PreviousBrokerEpoch for the KIP-966 + +// Version 3 adds LogDirs for KIP-858 { "apiKey":62, "type": "request", "listeners": ["controller"], "name": "BrokerRegistrationRequest", - "validVersions": "0-2", + "validVersions": "0-3", Review Comment: What's the reasoning behind doing two bumps of this API version within the same Kafka release? 3.6 is currently on `"validVersions": "0-3"`, so it looks like Kafka 3.7.0 will introduce both versions 2 and 3 of this API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org