Re: [PR] [MINOR] Clean up group-coordinator [kafka]

2025-03-01 Thread via GitHub
chia7712 merged PR #19008: URL: https://github.com/apache/kafka/pull/19008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] [MINOR] Clean up group-coordinator [kafka]

2025-03-01 Thread via GitHub
sjhajharia commented on code in PR #19008: URL: https://github.com/apache/kafka/pull/19008#discussion_r1976438007 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ConfiguredInternalTopic.java: ## @@ -62,7 +61,7 @@ public StreamsGroupDescribeRe

Re: [PR] [MINOR] Clean up group-coordinator [kafka]

2025-03-01 Thread via GitHub
chia7712 commented on code in PR #19008: URL: https://github.com/apache/kafka/pull/19008#discussion_r1976408532 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ConfiguredInternalTopic.java: ## @@ -62,7 +61,7 @@ public StreamsGroupDescribeResp

Re: [PR] [MINOR] Clean up group-coordinator [kafka]

2025-02-27 Thread via GitHub
sjhajharia commented on PR #19008: URL: https://github.com/apache/kafka/pull/19008#issuecomment-2687360738 hey @chia7712 Can you please take a look at this PR too. TIA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] [MINOR] Clean up group-coordinator [kafka]

2025-02-22 Thread via GitHub
sjhajharia opened a new pull request, #19008: URL: https://github.com/apache/kafka/pull/19008 Given that now we support Java 17 on our brokers, this PR replace the use of : - `Collections.singletonList()` and `Collections.emptyList()` with `List.of()` - `Collections.singletonMap()` an