chia7712 commented on code in PR #19008: URL: https://github.com/apache/kafka/pull/19008#discussion_r1976408532
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ConfiguredInternalTopic.java: ########## @@ -62,7 +61,7 @@ public StreamsGroupDescribeResponseData.TopicInfo asStreamsGroupDescribeTopicInf y -> new StreamsGroupDescribeResponseData.KeyValue() .setKey(y.getKey()) .setValue(y.getValue()) - ).collect(Collectors.toList()) : null Review Comment: `topicConfigs` is never null, so could you please remove the null check. Also, according the schema, `StreamsGroupDescribeResponseData` can't accept null `topicConfigs`. cc @lucasbru -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org