Re: [PR] Feature/openj9 integration [kafka]

2025-07-25 Thread via GitHub
github-actions[bot] commented on PR #20197: URL: https://github.com/apache/kafka/pull/20197#issuecomment-3121125126 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR:Extract public code [kafka]

2025-07-25 Thread via GitHub
github-actions[bot] commented on PR #20198: URL: https://github.com/apache/kafka/pull/20198#issuecomment-3121125094 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Created] (KAFKA-19550) Integration test for Streams-related Admin APIs[1/N]

2025-07-25 Thread Lucy Liu (Jira)
Lucy Liu created KAFKA-19550: Summary: Integration test for Streams-related Admin APIs[1/N] Key: KAFKA-19550 URL: https://issues.apache.org/jira/browse/KAFKA-19550 Project: Kafka Issue Type: Tes

[jira] [Assigned] (KAFKA-19550) Integration test for Streams-related Admin APIs[1/N]

2025-07-25 Thread Lucy Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucy Liu reassigned KAFKA-19550: Assignee: Lucy Liu > Integration test for Streams-related Admin APIs[1/N] >

[PR] KSTREAMS-7427 Integration test for Streams-related Admin APIs[1/N] [kafka]

2025-07-25 Thread via GitHub
lucliu1108 opened a new pull request, #20244: URL: https://github.com/apache/kafka/pull/20244 This PR adds: - Integration test for `Admin#describeStreamsGroups` API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] KAFKA-19518: Remove the usage of KafkaMetricsGroup(Class klass) [kafka]

2025-07-25 Thread via GitHub
Mirai1129 opened a new pull request, #20243: URL: https://github.com/apache/kafka/pull/20243 the constructor is error-prone when migrating code, since metrics could get unintentionally changed. We should remove the constructor and use constant strings instead to avoid issues like [KAFKA-17

[PR] KAFKA-19479 Topic replay code does not handle creation and deletion properly if it occurs in the same batch [kafka]

2025-07-25 Thread via GitHub
0x-zhiyan opened a new pull request, #20242: URL: https://github.com/apache/kafka/pull/20242 There is a small logic bug in topic replay. If a topic is created and then removed before the TopicsDelta is applied, we end up with the deleted topic in createdTopics on the delta but not in de

Re: [PR] KAFKA-19354: KRaft observer should fetch from leader after rediscovery [kafka]

2025-07-25 Thread via GitHub
ahuang98 commented on PR #19854: URL: https://github.com/apache/kafka/pull/19854#issuecomment-3120475711 btw, build is green! I'm pushing a commit for a single test fix which I validated still passes locally -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-19354: KRaft observer should fetch from leader after rediscovery [kafka]

2025-07-25 Thread via GitHub
ahuang98 commented on code in PR #19854: URL: https://github.com/apache/kafka/pull/19854#discussion_r2232070935 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2570,7 +2570,7 @@ private void maybeTransition( transitionToUnattached(epoch,

Re: [PR] KAFKA-19354: KRaft observer should fetch from leader after rediscovery [kafka]

2025-07-25 Thread via GitHub
jsancio commented on code in PR #19854: URL: https://github.com/apache/kafka/pull/19854#discussion_r2232057083 ## raft/src/test/java/org/apache/kafka/raft/RequestManagerTest.java: ## @@ -245,6 +245,41 @@ public void testFindReadyWithRequestTimedOut() { assertFalse(cache

Re: [PR] KAFKA-19354: KRaft observer should fetch from leader after rediscovery [kafka]

2025-07-25 Thread via GitHub
jsancio commented on code in PR #19854: URL: https://github.com/apache/kafka/pull/19854#discussion_r2232057083 ## raft/src/test/java/org/apache/kafka/raft/RequestManagerTest.java: ## @@ -245,6 +245,41 @@ public void testFindReadyWithRequestTimedOut() { assertFalse(cache

Re: [PR] KAFKA-19354: KRaft observer should fetch from leader after rediscovery [kafka]

2025-07-25 Thread via GitHub
ahuang98 commented on code in PR #19854: URL: https://github.com/apache/kafka/pull/19854#discussion_r2231846413 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2569,13 +2569,15 @@ private void maybeTransition( } else { trans

Re: [PR] KAFKA-19524: Fix UnsupportedOperationException in connect-plugin-path [kafka]

2025-07-25 Thread via GitHub
sjhajharia commented on PR #20222: URL: https://github.com/apache/kafka/pull/20222#issuecomment-3119862224 gentle ping @chia7712 TIA! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] MINOR: Re-add pageview demo to :streams:examples and remove dependency on :connect:json [kafka]

2025-07-25 Thread via GitHub
mjsax merged PR #20239: URL: https://github.com/apache/kafka/pull/20239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Cleanup Server Module [kafka]

2025-07-25 Thread via GitHub
sjhajharia commented on code in PR #20180: URL: https://github.com/apache/kafka/pull/20180#discussion_r2231662307 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionKey.java: ## @@ -21,23 +21,12 @@ import java.util.Objects; -public class ShareSessionK

Re: [PR] MINOR: Improve Kafka Streams Protocol Upgrade Doc [kafka]

2025-07-25 Thread via GitHub
AndrewJSchofield merged PR #20241: URL: https://github.com/apache/kafka/pull/20241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Improve Kafka Streams Protocol Upgrade Doc [kafka]

2025-07-25 Thread via GitHub
AndrewJSchofield commented on code in PR #20241: URL: https://github.com/apache/kafka/pull/20241#discussion_r2231574494 ## docs/streams/upgrade-guide.html: ## @@ -213,6 +213,11 @@ Early Access of the Streams Rebalance Protocol Set unstable.feature.versions.enable=true f

Re: [PR] MINOR: Improve Kafka Streams Protocol Upgrade Doc [kafka]

2025-07-25 Thread via GitHub
AndrewJSchofield commented on code in PR #20241: URL: https://github.com/apache/kafka/pull/20241#discussion_r2231549770 ## docs/streams/upgrade-guide.html: ## @@ -213,6 +213,11 @@ Early Access of the Streams Rebalance Protocol Set unstable.feature.versions.enable=true f

Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]

2025-07-25 Thread via GitHub
ravikalla commented on code in PR #20219: URL: https://github.com/apache/kafka/pull/20219#discussion_r2231508798 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java: ## @@ -2998,15 +2993,6 @@ private void verifyVersionedTaskConverterFromWorker(Stri

[jira] [Assigned] (KAFKA-19541) KRaft should handle snapshot fetches under slow networks

2025-07-25 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper reassigned KAFKA-19541: Assignee: Jonah Hooper > KRaft should handle snapshot fetches under slow networks > -

[jira] [Created] (KAFKA-19549) network_degrade_test.py failure

2025-07-25 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-19549: -- Summary: network_degrade_test.py failure Key: KAFKA-19549 URL: https://issues.apache.org/jira/browse/KAFKA-19549 Project: Kafka Issue Type: Bug Affec

[PR] MINOR: Improve Kafka Streams Protocol Upgrade Doc [kafka]

2025-07-25 Thread via GitHub
lucliu1108 opened a new pull request, #20241: URL: https://github.com/apache/kafka/pull/20241 As a follow-up on https://github.com/apache/kafka/pull/20029 , add the instructions for upgrading `streams.version` parameter for KIP-1071 EA. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-19425: Stop the server when fail to initialize to avoid local segment never got deleted. [kafka]

2025-07-25 Thread via GitHub
jiafu1115 commented on PR #20007: URL: https://github.com/apache/kafka/pull/20007#issuecomment-3118226302 @kamalcph Hi, kamalcph. I already fix the import sequence issue and squash several commits. you can help to retrigger the build when you free. thanks -- This is an automated message f

[PR] KAFKA-19537 StreamsGroupCommand should return exit code [kafka]

2025-07-25 Thread via GitHub
iddeepak opened a new pull request, #20240: URL: https://github.com/apache/kafka/pull/20240 The newly added `StreamsGroupCommand.java` tool, does not return a popper error code, what might break scripts which use `bin/kafka-streams-group.sh` as they cannot do proper error handling. S

Re: [PR] [Experimental] Add `rewrite` support for `RemoveUnusedPrivateMethods` & `RemoveUnusedImports` [kafka]

2025-07-25 Thread via GitHub
Pankraz76 commented on PR #20219: URL: https://github.com/apache/kafka/pull/20219#issuecomment-3117403438 ``` BUILD SUCCESSFUL in 38m 46s 374 actionable tasks: 90 executed, 284 up-to-date ➜ kafka git:(rewrite-) ./gradlew build -x test ``` Kindly request your feedback.

Re: [PR] MINOR: `kafka-consumer-groups.sh` should not fail when partition offline [kafka]

2025-07-25 Thread via GitHub
TaiJuWu commented on code in PR #20235: URL: https://github.com/apache/kafka/pull/20235#discussion_r2230764127 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -153,6 +155,29 @@ public void testResetOffsetsNotExistingGroup(Cl

Re: [PR] MINOR: `kafka-consumer-groups.sh` should not fail when partition offline [kafka]

2025-07-25 Thread via GitHub
Yunyung commented on code in PR #20235: URL: https://github.com/apache/kafka/pull/20235#discussion_r2230635080 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -153,6 +155,29 @@ public void testResetOffsetsNotExistingGroup(Cl

Re: [PR] MINOR: `kafka-consumer-groups.sh` should not fail when partition offline [kafka]

2025-07-25 Thread via GitHub
TaiJuWu commented on code in PR #20235: URL: https://github.com/apache/kafka/pull/20235#discussion_r2230581343 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -153,6 +154,26 @@ public void testResetOffsetsNotExistingGroup(Cl

Re: [PR] MINOR: Simplify PartitionStates update logic by removing unnecessary grouping [kafka]

2025-07-25 Thread via GitHub
zt52875287 commented on code in PR #19442: URL: https://github.com/apache/kafka/pull/19442#discussion_r2230499616 ## clients/src/main/java/org/apache/kafka/common/internals/PartitionStates.java: ## @@ -129,28 +129,14 @@ public int size() { */ public void set(Map parti

Re: [PR] MINOR: `kafka-consumer-groups.sh` should not fail when partition offline [kafka]

2025-07-25 Thread via GitHub
chia7712 commented on code in PR #20235: URL: https://github.com/apache/kafka/pull/20235#discussion_r2230496206 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -153,6 +154,26 @@ public void testResetOffsetsNotExistingGroup(C

Re: [PR] MINOR: Simplify PartitionStates update logic by removing unnecessary grouping [kafka]

2025-07-25 Thread via GitHub
zt52875287 closed pull request #19442: MINOR: Simplify PartitionStates update logic by removing unnecessary grouping URL: https://github.com/apache/kafka/pull/19442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-19426: Correct the TopicBasedRemoteLogMetadataManager#initializeResources' retry default configure value to reasonable one [kafka]

2025-07-25 Thread via GitHub
jiafu1115 commented on PR #20008: URL: https://github.com/apache/kafka/pull/20008#issuecomment-3116804378 close it due to I already open another one with new approach which can solve the RC. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-19426: Correct the TopicBasedRemoteLogMetadataManager#initializeResources' retry default configure value to reasonable one [kafka]

2025-07-25 Thread via GitHub
jiafu1115 closed pull request #20008: KAFKA-19426: Correct the TopicBasedRemoteLogMetadataManager#initializeResources' retry default configure value to reasonable one URL: https://github.com/apache/kafka/pull/20008 -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] KAFKA-19426: TopicBasedRemoteLogMetadataManager's initial should happen after the broker ready. [kafka]

2025-07-25 Thread via GitHub
jiafu1115 commented on code in PR #20203: URL: https://github.com/apache/kafka/pull/20203#discussion_r2230435337 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java: ## @@ -242,4 +242,18 @@ default Optional nextSegmentWithTxnInd

Re: [PR] MINIOR: Re-add pageview demo to :streams:examples and remove dependency on :connect:json [kafka]

2025-07-25 Thread via GitHub
Yunyung commented on PR #20239: URL: https://github.com/apache/kafka/pull/20239#issuecomment-3116727404 > Hi @mjsax , just found that without the default implementation the code can't pass the test `org.gradle.api.plugins.quality.internal.CheckstyleAction`, so I add it back. Hi, actu

Re: [PR] KAFKA-19498: Add include argument to ConsumerPerformance tool [kafka]

2025-07-25 Thread via GitHub
fvaleri commented on code in PR #20221: URL: https://github.com/apache/kafka/pull/20221#discussion_r2230353006 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -134,8 +136,13 @@ private static void consume(KafkaConsumer consumer, long repor

[jira] [Updated] (KAFKA-19548) Broker Startup: Handle Checkpoint Creation Failure via logDirFailureChannel

2025-07-25 Thread Haozhong Ma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haozhong Ma updated KAFKA-19548: Description: In our production environment, we encountered a scenario where a broker failed to sta

[jira] [Updated] (KAFKA-19548) Broker Startup: Handle Checkpoint Creation Failure via logDirFailureChannel

2025-07-25 Thread Haozhong Ma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haozhong Ma updated KAFKA-19548: Description: In our production environment, we encountered a scenario where a broker failed to sta

Re: [PR] MINOR: fix e2e docs for test that cannot be run directly [kafka]

2025-07-25 Thread via GitHub
Yunyung commented on PR #20145: URL: https://github.com/apache/kafka/pull/20145#issuecomment-3116682848 > @Yunyung the example of section `Run a specific test method with specific parameters` is also broken. Could you please fix it in this PR? Thanks for checking. Done. I saw the m

[jira] [Created] (KAFKA-19548) Broker Startup: Handle Checkpoint Creation Failure via logDirFailureChannel

2025-07-25 Thread Haozhong Ma (Jira)
Haozhong Ma created KAFKA-19548: --- Summary: Broker Startup: Handle Checkpoint Creation Failure via logDirFailureChannel Key: KAFKA-19548 URL: https://issues.apache.org/jira/browse/KAFKA-19548 Project: Ka