AndrewJSchofield commented on code in PR #20241:
URL: https://github.com/apache/kafka/pull/20241#discussion_r2231549770
##########
docs/streams/upgrade-guide.html:
##########
@@ -213,6 +213,11 @@ <h4>Early Access of the Streams Rebalance Protocol</h4>
Set <code>unstable.feature.versions.enable=true</code> for controllers
and brokers, and
set <code>unstable.api.versions.enable=true</code> on the brokers as
well. In your Kafka Streams application
configuration, set <code>group.protocol=streams</code>.
+ Besides, the `streams.version` also needs to be upgraded. To do this,
run
+ <code>kafka-features.sh --bootstrap-server localhost:9092 upgrade
--feature streams.version=1</code>
+ to upgrade, or use Admin#updateFeatures API to update
`streams.version`. After the feature is updated, check
+ <code>kafka-features.sh --bootstrap-server localhost:9092
describe</code>
+ and `streams.version` should now has FinializedVersionLevel 1.
Review Comment:
nit: spelling `FinalizedVersionLevel`.
##########
docs/streams/upgrade-guide.html:
##########
@@ -213,6 +213,11 @@ <h4>Early Access of the Streams Rebalance Protocol</h4>
Set <code>unstable.feature.versions.enable=true</code> for controllers
and brokers, and
set <code>unstable.api.versions.enable=true</code> on the brokers as
well. In your Kafka Streams application
configuration, set <code>group.protocol=streams</code>.
+ Besides, the `streams.version` also needs to be upgraded. To do this,
run
Review Comment:
I suggest "Upgrade the `streams.version` feature to 1" rather than the
sentence which begins "besides".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
