FrankYang0529 commented on code in PR #19802:
URL: https://github.com/apache/kafka/pull/19802#discussion_r2105717603
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##
@@ -582,54 +592,44 @@ public Set currentWarmupTaskProcessIds(
FrankYang0529 opened a new pull request, #19802:
URL: https://github.com/apache/kafka/pull/19802
* Use metadata hash to replace subscription metadata.
* Remove `StreamsGroupPartitionMetadataKey` and
`StreamsGroupPartitionMetadataValue`.
* Check whether `configuredTopology` is empty. If
sjhajharia commented on PR #19775:
URL: https://github.com/apache/kafka/pull/19775#issuecomment-2906407518
No worries @chia7712
This PR is ready for review.
TIA!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on PR #19772:
URL: https://github.com/apache/kafka/pull/19772#issuecomment-2906372317
@showuon @frankvicky The 3.9.1 release is not uploaded to
`https://s3-us-west-2.amazonaws.com/kafka-packages` yet, so this PR break the
e2e tests. Is the upload in progress?
--
This i
FrankYang0529 commented on code in PR #19793:
URL: https://github.com/apache/kafka/pull/19793#discussion_r2105694458
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1006,7 +1026,7 @@ class ReplicaManager(val config: KafkaConfig,
LogAppendInfo.UNKNOWN_LO
[
https://issues.apache.org/jira/browse/KAFKA-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 reassigned KAFKA-19325:
---
Assignee: 黃竣陽
> improve forceComplete() in DelayedOperation
> ---
>
yuxian0908 commented on code in PR #19767:
URL: https://github.com/apache/kafka/pull/19767#discussion_r2105670470
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java:
##
@@ -27,17 +27,16 @@
public final class LogOffsetMetadata {
//TODO
Ed Berezitsky created KAFKA-19327:
-
Summary: MM2 Source Connector Fails at Scale
Key: KAFKA-19327
URL: https://issues.apache.org/jira/browse/KAFKA-19327
Project: Kafka
Issue Type: Bug
rreddy-22 opened a new pull request, #19801:
URL: https://github.com/apache/kafka/pull/19801
There was a small error in setting the throttle time in the InitProducerId
response in this PR
[https://github.com/apache/kafka/commit/53e95ffcdb1cecbba67eb726aa2abcab3ae49c66#diff-1f7f71b4fbeaf6512
[
https://issues.apache.org/jira/browse/KAFKA-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953779#comment-17953779
]
Jun Rao commented on KAFKA-19325:
-
[~m1a2st] : Thanks for your interest. I left the assi
m1a2st commented on PR #19371:
URL: https://github.com/apache/kafka/pull/19371#issuecomment-2905917690
I merge trunk, and retrigger the CI again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953776#comment-17953776
]
黃竣陽 commented on KAFKA-19325:
-
Hello [~junrao], may I take this one, thanks
> improve force
m1a2st commented on PR #19371:
URL: https://github.com/apache/kafka/pull/19371#issuecomment-2905909017
No, I think the fail tes are not related, but the main reason is the hatset
order is different, I will file a PR to fix it.
```
org.opentest4j.AssertionFailedError: expected:
<[C
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2105470732
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -29,10 +28,9 @@
* a delayed fetch operation could be waiting for
fvaleri commented on PR #19780:
URL: https://github.com/apache/kafka/pull/19780#issuecomment-2905840328
@ijuma thanks. It looks like `distributionType` is not used anymore in
`wrapper.gradle`, so I removed it and switched to using "-bin".
--
This is an automated message from the Apache Gi
Yunyung commented on PR #19797:
URL: https://github.com/apache/kafka/pull/19797#issuecomment-2905802482
> Could we also remove `mkMapOfPartitionRacks` in
`GroupCoordinatorRecordHelpersTest.java` ?
Done. Thanks.
--
This is an automated message from the Apache Git Service.
To
AndrewJSchofield commented on code in PR #19800:
URL: https://github.com/apache/kafka/pull/19800#discussion_r2105401772
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -48,7 +48,9 @@
// Version 16 adds the 'NodeEndpoints' field (KIP-951).
//
// Ve
jsancio opened a new pull request, #19800:
URL: https://github.com/apache/kafka/pull/19800
DRAFT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kumarlokesh opened a new pull request, #19799:
URL: https://github.com/apache/kafka/pull/19799
Fixes https://issues.apache.org/jira/browse/KAFKA-19155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sjhajharia commented on PR #19510:
URL: https://github.com/apache/kafka/pull/19510#issuecomment-2905502150
Thanks @mingyen066 and @Yunyung for the review
I have added the suggestions. Please re-review
--
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/KAFKA-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-19326.
-
Fix Version/s: 4.1.0
Resolution: Fixed
It seems this is fixed in [https://github.com/apache/kafka
Mirai1129 commented on PR #19798:
URL: https://github.com/apache/kafka/pull/19798#issuecomment-2905421203
@chia7712 Thank you so much! Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/KAFKA-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-19326:
--
Assignee: Chia-Ping Tsai
> flaky test GroupMetadataManagerTest.testShareGroupInitiali
chia7712 commented on PR #19798:
URL: https://github.com/apache/kafka/pull/19798#issuecomment-2905361137
@Mirai1129 please fix the build by removing the usages of the removed
constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Jun Rao created KAFKA-19326:
---
Summary: flaky test
GroupMetadataManagerTest.testShareGroupInitializeSuccess()
Key: KAFKA-19326
URL: https://issues.apache.org/jira/browse/KAFKA-19326
Project: Kafka
junrao commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2105155776
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -29,10 +28,9 @@
* a delayed fetch operation could be waiting for a given
mingyen066 commented on PR #19797:
URL: https://github.com/apache/kafka/pull/19797#issuecomment-2905266266
Could we also remove `mkMapOfPartitionRacks` in
`GroupCoordinatorRecordHelpersTest.java` ?
https://github.com/apache/kafka/blob/trunk/group-coordinator/src/test/java/org/apache/
sjhajharia commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2905251231
Thanks @Yunyung for the review. I have addressed the comment.
PTAL when possible!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Mirai1129 opened a new pull request, #19798:
URL: https://github.com/apache/kafka/pull/19798
Remove the DelayedOperation constructor that accepts an external lock.
According to this [PR](https://github.com/apache/kafka/pull/19759).
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/KAFKA-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-19325:
Description:
After [https://github.com/apache/kafka/pull/19759/files,]
DelayedOperation.forceComplete() a
Jun Rao created KAFKA-19325:
---
Summary: improve forceComplete() in DelayedOperation
Key: KAFKA-19325
URL: https://issues.apache.org/jira/browse/KAFKA-19325
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-19325:
Description:
After [https://github.com/apache/kafka/pull/19759/files,]
DelayedOperation.forceComplete() a
[
https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953748#comment-17953748
]
Arpit Goyal commented on KAFKA-19259:
-
[~lianetm] I am still not able to reproduce t
[
https://issues.apache.org/jira/browse/KAFKA-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio reassigned KAFKA-14145:
--
Assignee: José Armando García Sancio (was: Jose Armando Garci
apalan60 commented on code in PR #19681:
URL: https://github.com/apache/kafka/pull/19681#discussion_r2105023150
##
storage/src/test/java/org/apache/kafka/admin/RemoteTopicCrudTest.java:
##
@@ -0,0 +1,692 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
apalan60 commented on code in PR #19681:
URL: https://github.com/apache/kafka/pull/19681#discussion_r2105024105
##
storage/src/test/java/org/apache/kafka/admin/RemoteTopicCrudTest.java:
##
@@ -0,0 +1,692 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
[
https://issues.apache.org/jira/browse/KAFKA-19224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio resolved KAFKA-19224.
Assignee: José Armando García Sancio
Resolution: Won't Fix
T
jsancio merged PR #19747:
URL: https://github.com/apache/kafka/pull/19747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
ijuma commented on PR #19780:
URL: https://github.com/apache/kafka/pull/19780#issuecomment-2905031826
> At some point we switched to "all", but I was unable to find any reason.
cc @ijuma
We just use the command that regenerates the file - that used `all` before.
Not sure if that chan
ijuma commented on code in PR #19762:
URL: https://github.com/apache/kafka/pull/19762#discussion_r2104979893
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java:
##
@@ -0,0 +1,843 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contrib
ijuma commented on PR #19762:
URL: https://github.com/apache/kafka/pull/19762#issuecomment-2905019893
The description I wrote in the ticket was the conclusion after a discussion
with a few people including @jsancio and @cmccabe. @jsancio does that approach
still make sense to you?
--
Thi
Yunyung opened a new pull request, #19797:
URL: https://github.com/apache/kafka/pull/19797
The mkMapOfPartitionRacks was introduced in
https://github.com/apache/kafka/commit/8013657f5da99277e7a21177c77d2ef172792aee
and has not been used since
https://github.com/apache/kafka/commit/bb97d63d
chia7712 merged PR #19795:
URL: https://github.com/apache/kafka/pull/19795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #18713:
URL: https://github.com/apache/kafka/pull/18713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #19687:
URL: https://github.com/apache/kafka/pull/19687#discussion_r2104834381
##
core/src/main/scala/kafka/server/ConfigHelper.scala:
##
@@ -130,7 +131,7 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
FrankYang0529 opened a new pull request, #19796:
URL: https://github.com/apache/kafka/pull/19796
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add som
mingyen066 commented on code in PR #19510:
URL: https://github.com/apache/kafka/pull/19510#discussion_r2104803460
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -9332,7 +9316,7 @@ class KafkaApisTest extends Logging {
assertEquals(clusterId, describeClu
[
https://issues.apache.org/jira/browse/KAFKA-19260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19260.
Fix Version/s: 4.1.0
Resolution: Fixed
> Move LoggingController to server module
>
chia7712 merged PR #19687:
URL: https://github.com/apache/kafka/pull/19687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #19767:
URL: https://github.com/apache/kafka/pull/19767#discussion_r2104845326
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java:
##
@@ -27,17 +27,16 @@
public final class LogOffsetMetadata {
//TODO KA
Yunyung commented on code in PR #19510:
URL: https://github.com/apache/kafka/pull/19510#discussion_r2104824058
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -9332,7 +9316,7 @@ class KafkaApisTest extends Logging {
assertEquals(clusterId, describeCluste
Yunyung commented on code in PR #19510:
URL: https://github.com/apache/kafka/pull/19510#discussion_r2104824058
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -9332,7 +9316,7 @@ class KafkaApisTest extends Logging {
assertEquals(clusterId, describeCluste
dongnuo123 commented on code in PR #19790:
URL: https://github.com/apache/kafka/pull/19790#discussion_r2104816489
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2485,8 +2485,6 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
dongnuo123 commented on code in PR #19790:
URL: https://github.com/apache/kafka/pull/19790#discussion_r2104816489
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2485,8 +2485,6 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
Yunyung commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2904765961
Thanks for the PR. Could you also do this cleanup?
Collections.unmodifiableMap -> Map.copyOf
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2104779153
##
core/src/test/java/integration/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
chia7712 commented on code in PR #19699:
URL: https://github.com/apache/kafka/pull/19699#discussion_r2104692237
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java:
##
@@ -0,0 +1,728 @@
+/*
+ * Licensed to the Apache Softwar
smjn opened a new pull request, #19795:
URL: https://github.com/apache/kafka/pull/19795
Currently, we were asserting on records containing set using `assertEquals`
which can fail intermittently. To fix the assertion has been replaced by
`assertRecordEquals`.
--
This is an automated messa
gaurav-narula commented on PR #19607:
URL: https://github.com/apache/kafka/pull/19607#issuecomment-2904320093
CC: @chia7712 can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
smjn closed pull request #19794: HOTFIX: Fix build issue due to alter offsets.
URL: https://github.com/apache/kafka/pull/19794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
apoorvmittal10 commented on PR #19792:
URL: https://github.com/apache/kafka/pull/19792#issuecomment-2904214519
@smjn I have merged the PR for fixing the build. We can discuss the right
approach in your PR as there is this
[open](https://github.com/apache/kafka/pull/19792#discussion_r2104333
apoorvmittal10 commented on PR #19794:
URL: https://github.com/apache/kafka/pull/19794#issuecomment-2904216751
@smjn I have merged the other PR for fixing trunk build. We shall discuss
the better way in your PR, can you please update the PR, if needed.
--
This is an automated message from
apoorvmittal10 merged PR #19792:
URL: https://github.com/apache/kafka/pull/19792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.
fvaleri commented on PR #19780:
URL: https://github.com/apache/kafka/pull/19780#issuecomment-2904147663
@showuon the build is broken due to
https://github.com/apache/kafka/pull/18929/files#r2104172356. An fix was opened
here: https://github.com/apache/kafka/pull/19792/files.
--
This is a
apoorvmittal10 commented on PR #19789:
URL: https://github.com/apache/kafka/pull/19789#issuecomment-2903971300
@ShivsundarR Please avoid force pushing once the PR is under review and has
previous comments.
--
This is an automated message from the Apache Git Service.
To respond to the mess
chia7712 commented on code in PR #19792:
URL: https://github.com/apache/kafka/pull/19792#discussion_r2104333197
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8136,10 +8137,14 @@ public Map.Entry
ShivsundarR commented on PR #19789:
URL: https://github.com/apache/kafka/pull/19789#issuecomment-2904083051
Yes it should not be needed now, I will update the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
smjn commented on PR #19794:
URL: https://github.com/apache/kafka/pull/19794#issuecomment-2904035818
> We have another PR for hotfix: #19792. I am fine merging the other one and
then correcting code, or merging this one directly.
The other fix has unnecessary code.
--
This is an au
chia7712 commented on code in PR #19792:
URL: https://github.com/apache/kafka/pull/19792#discussion_r2104202970
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8136,10 +8136,14 @@ public Map.Entry
apoorvmittal10 commented on PR #19789:
URL: https://github.com/apache/kafka/pull/19789#issuecomment-2904065931
> I thought to have waitedPoll() maybe only for checking 1 record
The `waitdPoll` method also takes recordsCount, so should it not be needed
now?
--
This is an automated m
apoorvmittal10 commented on PR #19794:
URL: https://github.com/apache/kafka/pull/19794#issuecomment-2904060301
@mingyen066 @JimmyWang6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
apoorvmittal10 commented on PR #19794:
URL: https://github.com/apache/kafka/pull/19794#issuecomment-2904059354
> > We have another PR for hotfix: #19792. I am fine merging the other one
and then correcting code, or merging this one directly.
>
> The other fix has unnecessary code.
ShivsundarR commented on PR #19789:
URL: https://github.com/apache/kafka/pull/19789#issuecomment-2904051918
> Some of these modified tests are using "explicit" mode, so we should
> ideally refactor these tests too to expect 1 only record at a time.
> These tests have clean runs in devel
chia7712 commented on PR #19775:
URL: https://github.com/apache/kafka/pull/19775#issuecomment-2904044925
> I had to revert the change suggested by you. The reason is that the method
is used in a different way by the test in that class. Removal led to test
failures.
you are right, Ple
ShivsundarR commented on PR #19789:
URL: https://github.com/apache/kafka/pull/19789#issuecomment-2904040480
We are doing a `producer.flush`, I probably expect its a race condition when
the `ShareFetchBuffer` where both background and application thread are writing
and reading from once the
chirag-wadhwa5 commented on code in PR #19778:
URL: https://github.com/apache/kafka/pull/19778#discussion_r2104316173
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -372,6 +459,110 @@ public void testNewContext() {
assertEquals(0, cache.s
sjhajharia commented on PR #19510:
URL: https://github.com/apache/kafka/pull/19510#issuecomment-2904026879
Thanks @frankvicky
The build looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
smjn commented on PR #19792:
URL: https://github.com/apache/kafka/pull/19792#issuecomment-2904025640
https://github.com/apache/kafka/pull/19794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
smjn opened a new pull request, #19794:
URL: https://github.com/apache/kafka/pull/19794
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sjhajharia commented on PR #19775:
URL: https://github.com/apache/kafka/pull/19775#issuecomment-2904011707
Hey @chia7712 ,
I had to revert the change suggested by you. The reason is that the method
is used in a different way by the test in that class. Removal led to test
failures.
--
smjn commented on code in PR #19792:
URL: https://github.com/apache/kafka/pull/19792#discussion_r2104313411
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8136,10 +8137,14 @@ public Map.Entry
apoorvmittal10 commented on PR #19789:
URL: https://github.com/apache/kafka/pull/19789#issuecomment-2904002520
> * One of the test failed due to a possible race condition
> in`waitedPoll()` where we expect 2 records and we get only 1 record on
> the first `poll()`. This record w
ShivsundarR commented on PR #19789:
URL: https://github.com/apache/kafka/pull/19789#issuecomment-2903993595
Hi @apoorvmittal10 , yes apologies, I was trying to fix the build failure by
rebasing, and then realised should have added a merge commit.
It seems build failure is addressed in th
chia7712 commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2104172356
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8061,6 +8075,74 @@ public
List sharePartitionsEli
ret
ShivsundarR commented on code in PR #19789:
URL: https://github.com/apache/kafka/pull/19789#discussion_r2104252063
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##
@@ -2977,6 +2984,28 @@ private ConsumerRecords waite
Yunyung commented on code in PR #19792:
URL: https://github.com/apache/kafka/pull/19792#discussion_r2104219802
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8136,10 +8136,15 @@ public Map.Entry
mingyen066 opened a new pull request, #19792:
URL: https://github.com/apache/kafka/pull/19792
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some c
mingyen066 commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2104199858
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8061,6 +8075,74 @@ public
List sharePartitionsEli
r
johnny94 opened a new pull request, #19793:
URL: https://github.com/apache/kafka/pull/19793
This PR moves `DelayedProduce` to the server module. One notable change is
that the type of the `responseCallback` parameter in
`ReplicaManager#appendRecords()` has been changed to a Java `Map`. Othe
chia7712 commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2104172772
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8061,6 +8075,74 @@ public
List sharePartitionsEli
ret
apoorvmittal10 commented on code in PR #19789:
URL: https://github.com/apache/kafka/pull/19789#discussion_r2104111224
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##
@@ -2977,6 +2984,28 @@ private ConsumerRecords wa
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2104104199
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -41,7 +40,7 @@
*/
public abstract class DelayedOperation extends
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2104086816
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -68,24 +67,36 @@ public DelayedOperation(long delayMs, Lock lock) {
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2104086816
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -68,24 +67,36 @@ public DelayedOperation(long delayMs, Lock lock) {
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2104086816
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -68,24 +67,36 @@ public DelayedOperation(long delayMs, Lock lock) {
mingyen066 commented on code in PR #19741:
URL: https://github.com/apache/kafka/pull/19741#discussion_r2104087114
##
server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
AndrewJSchofield merged PR #18929:
URL: https://github.com/apache/kafka/pull/18929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
[
https://issues.apache.org/jira/browse/KAFKA-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19069.
Fix Version/s: 4.1.0
Resolution: Fixed
> DumpLogSegments does not dump the LEADER_C
chia7712 merged PR #19729:
URL: https://github.com/apache/kafka/pull/19729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield merged PR #19781:
URL: https://github.com/apache/kafka/pull/19781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
1 - 100 of 101 matches
Mail list logo
