ShivsundarR commented on PR #19789: URL: https://github.com/apache/kafka/pull/19789#issuecomment-2904051918
> Some of these modified tests are using "explicit" mode, so we should > ideally refactor these tests too to expect 1 only record at a time. > These tests have clean runs in develocity though, so I have not modified > these tests in this PR. We can modify them if we observe flakiness for > them in future. There is also this problem where there are a few other tests which expect more than 1 record in a poll using explicit mode. These are are not flaky as of now, but we might need to modify them to test 1 record at a time to be deterministic. If we introduce AcknowledgeType.RETAIN or change the default way to not throw an exception in future, then these tests are good, but for now we can probably monitor and change if required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
