[jira] [Resolved] (KAFKA-19275) client-state and thread-state metrics are always ""Unavailable"

2025-05-13 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan Po Tseng resolved KAFKA-19275. --- Resolution: Fixed > client-state and thread-state metrics are always ""Unavailable" > --

[jira] [Commented] (KAFKA-19275) client-state and thread-state metrics are always ""Unavailable"

2025-05-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951332#comment-17951332 ] Chia-Ping Tsai commented on KAFKA-19275: trunk: https://github.com/apache/kafka

[jira] [Created] (KAFKA-19278) add test to ensure the metric does not use non-java type

2025-05-13 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19278: -- Summary: add test to ensure the metric does not use non-java type Key: KAFKA-19278 URL: https://issues.apache.org/jira/browse/KAFKA-19278 Project: Kafka

[jira] [Resolved] (KAFKA-19145) Move LeaderEndPoint to server module

2025-05-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19145. Fix Version/s: 4.1.0 Resolution: Fixed > Move LeaderEndPoint to server module > ---

[jira] [Commented] (KAFKA-17207) ConnectWorkerIntegrationTest.testRequestTimeouts times out in stop(), leaking clients

2025-05-13 Thread Francis Godinho (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951319#comment-17951319 ] Francis Godinho commented on KAFKA-17207: - [~gharris1727] [~Xuze Yang] saw this

[jira] [Comment Edited] (KAFKA-17207) ConnectWorkerIntegrationTest.testRequestTimeouts times out in stop(), leaking clients

2025-05-13 Thread Francis Godinho (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951319#comment-17951319 ] Francis Godinho edited comment on KAFKA-17207 at 5/14/25 3:33 AM:

[jira] [Commented] (KAFKA-16043) Add Quota configuration for topics

2025-05-13 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951310#comment-17951310 ] zhangzhisheng commented on KAFKA-16043: --- Expecting this feature to go live early.

[jira] [Commented] (KAFKA-16042) Quota Metrics based on per topic-partition produce/fetch byte rate

2025-05-13 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951311#comment-17951311 ] zhangzhisheng commented on KAFKA-16042: --- good > Quota Metrics based on per topic-

[jira] [Commented] (KAFKA-10897) kafka quota optimization

2025-05-13 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951312#comment-17951312 ] zhangzhisheng commented on KAFKA-10897: --- good > kafka quota optimization > --

[jira] [Created] (KAFKA-19277) Introduce `ConsumerGroupMessageFormatter` for the console-consumer

2025-05-13 Thread David Jacot (Jira)
David Jacot created KAFKA-19277: --- Summary: Introduce `ConsumerGroupMessageFormatter` for the console-consumer Key: KAFKA-19277 URL: https://issues.apache.org/jira/browse/KAFKA-19277 Project: Kafka

[jira] [Assigned] (KAFKA-15891) Flaky test: testResetSinkConnectorOffsetsOverriddenConsumerGroupId – org.apache.kafka.connect.integration.OffsetsApiIntegrationTest

2025-05-13 Thread Will Perlichek (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Will Perlichek reassigned KAFKA-15891: -- Assignee: (was: Will Perlichek) > Flaky test: testResetSinkConnectorOffsetsOverri

[jira] [Assigned] (KAFKA-16492) Flaky test: testAlterSinkConnectorOffsetsDifferentKafkaClusterTargeted – org.apache.kafka.connect.integration.OffsetsApiIntegrationTest

2025-05-13 Thread Will Perlichek (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Will Perlichek reassigned KAFKA-16492: -- Assignee: (was: Will Perlichek) > Flaky test: testAlterSinkConnectorOffsetsDiffer

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087028173 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +329,84 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-13 Thread via GitHub
junrao commented on code in PR #19635: URL: https://github.com/apache/kafka/pull/19635#discussion_r2087319995 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -921,8 +923,76 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegrat

[PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-13 Thread via GitHub
ahuang98 opened a new pull request, #19711: URL: https://github.com/apache/kafka/pull/19711 Reviewers: Colin P. McCabe ``` Conflicts: checkstyle/import-control.xml - different surrounding imports clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCreden

[PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-13 Thread via GitHub
ahuang98 opened a new pull request, #19710: URL: https://github.com/apache/kafka/pull/19710 Reviewers: Colin P. McCabe ``` Conflicts: checkstyle/import-control.xml - different surrounding imports clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCreden

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087258500 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +329,84 @@ static void throwIfRegularExpressionIsInvalid(

[PR] KAFKA-19226: Added test_console_share_consumer.py [kafka]

2025-05-13 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19708: URL: https://github.com/apache/kafka/pull/19708 This PR includes the system test file test_console_share_consumer.py which tests the functioning of ConsoleShareConsumer -- This is an automated message from the Apache Git Service. To respon

[jira] [Commented] (KAFKA-18961) Consider time-based refresh for server-side RE2J regex

2025-05-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951240#comment-17951240 ] David Jacot commented on KAFKA-18961: - [~squah-confluent] It is preferable to have i

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087259372 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/UtilsTest.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087257495 ## build.gradle: ## @@ -1414,10 +1414,12 @@ project(':group-coordinator') { implementation project(':coordinator-common') implementation libs.jacksonDatabind

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-13 Thread via GitHub
lianetm merged PR #19622: URL: https://github.com/apache/kafka/pull/19622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-05-13 Thread via GitHub
m1a2st commented on code in PR #19371: URL: https://github.com/apache/kafka/pull/19371#discussion_r2086829441 ## raft/src/main/java/org/apache/kafka/raft/MetadataLogConfig.java: ## @@ -85,14 +82,13 @@ public class MetadataLogConfig { .define(METADATA_SNAPSHOT_MAX_IN

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-13 Thread via GitHub
ahuang98 commented on PR #19692: URL: https://github.com/apache/kafka/pull/19692#issuecomment-2877132412 hm, build was "successful" but still marked unstable ``` BUILD SUCCESSFUL in 3h 42m 34s ``` -- This is an automated message from the Apache Git Service. To respond to the messa

[PR] KAFKA-19267: the min version used by ListOffsetsRequest should be 1 rather than 0 [kafka]

2025-05-13 Thread via GitHub
yunchipang opened a new pull request, #19709: URL: https://github.com/apache/kafka/pull/19709 jira: [KAFKA-19267](https://issues.apache.org/jira/browse/KAFKA-19267) Updates the min version used by `ListOffsetsRequest` to `ApiKeys.LIST_OFFSETS.oldestVersion()` rather than hardcoding `1

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-13 Thread via GitHub
jsancio commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2087113715 ## raft/src/test/java/org/apache/kafka/raft/RequestManagerTest.java: ## @@ -120,10 +131,17 @@ public void testIgnoreUnexpectedResponse() { ); long c

Re: [PR] KAFKA-19253: Improve metadata handling for share version using feature listeners (1/N) [kafka]

2025-05-13 Thread via GitHub
apoorvmittal10 commented on code in PR #19659: URL: https://github.com/apache/kafka/pull/19659#discussion_r2087178807 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -746,6 +747,29 @@ private Consumer> failedShareAcknowledgeMetricsHandler() {

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-13 Thread via GitHub
ahuang98 commented on PR #19690: URL: https://github.com/apache/kafka/pull/19690#issuecomment-2877127401 build failed with ``` * What went wrong: -- Execution failed for task ':connect:json:signMavenJavaPublication'. > Cannot perform signing task ':connect:json:signMavenJavaPu

Re: [PR] KAFKA-19231: Handle fetch request when share session cache is full [kafka]

2025-05-13 Thread via GitHub
chirag-wadhwa5 commented on PR #19637: URL: https://github.com/apache/kafka/pull/19637#issuecomment-2876988834 This PR is obsolete now. This task is now being handled in the PR -> https://github.com/apache/kafka/pull/19701 Will close this PR -- This is an automated message from the Apa

Re: [PR] jprnt01/streams/examples/src/main/java/org/apache/kafka/streams/exampl… [kafka]

2025-05-13 Thread via GitHub
apoorvmittal10 commented on PR #19671: URL: https://github.com/apache/kafka/pull/19671#issuecomment-2876997503 Also not sure if you require the commit history or can cherry-pick your changes on top of current trunk. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] jprnt01/streams/examples/src/main/java/org/apache/kafka/streams/exampl… [kafka]

2025-05-13 Thread via GitHub
apoorvmittal10 commented on PR #19671: URL: https://github.com/apache/kafka/pull/19671#issuecomment-2876992772 Can we please have PR with corrected title and description. Also seems there are a lot conflicts, can we please resolve them. If the PR is work in progress then consider converting

Re: [PR] KAFKA-19231: Handle fetch request when share session cache is full [kafka]

2025-05-13 Thread via GitHub
chirag-wadhwa5 closed pull request #19637: KAFKA-19231: Handle fetch request when share session cache is full URL: https://github.com/apache/kafka/pull/19637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-19231-1: Handle fetch request when share session cache is full [kafka]

2025-05-13 Thread via GitHub
apoorvmittal10 commented on code in PR #19701: URL: https://github.com/apache/kafka/pull/19701#discussion_r2087080717 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -2803,6 +2804,42 @@ public void testFetchMessagesRotatePartitions() { val

Re: [PR] KAFKA-19091: Fix race condition in DelayedFutureTest [kafka]

2025-05-13 Thread via GitHub
UladzislauBlok commented on code in PR #19553: URL: https://github.com/apache/kafka/pull/19553#discussion_r2087104901 ## server/src/test/java/org/apache/kafka/server/purgatory/DelayedFutureTest.java: ## @@ -49,13 +49,11 @@ void testDelayedFuture() throws Exception {

Re: [PR] KAFKA-19091: Fix race condition in DelayedFutureTest [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19553: URL: https://github.com/apache/kafka/pull/19553#discussion_r2087095791 ## server/src/test/java/org/apache/kafka/server/purgatory/DelayedFutureTest.java: ## @@ -49,13 +49,11 @@ void testDelayedFuture() throws Exception {

Re: [PR] KAFKA-19246; OffsetFetch API does not return group level errors correctly with version 1 [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19704: URL: https://github.com/apache/kafka/pull/19704#discussion_r2087068751 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java: ## @@ -239,4 +240,31 @@ public OffsetFetchResponseData data() { public boolean sh

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087024185 ## build.gradle: ## @@ -1414,10 +1414,12 @@ project(':group-coordinator') { implementation project(':coordinator-common') implementation libs.jacksonDat

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
dajac commented on PR #19677: URL: https://github.com/apache/kafka/pull/19677#issuecomment-2876898370 Merged to trunk and 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Resolved] (KAFKA-18688) Uniform homogeneous assignment is not always stable

2025-05-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18688. - Fix Version/s: 4.0.1 4.1.0 Resolution: Fixed > Uniform homogeneous ass

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
dajac merged PR #19677: URL: https://github.com/apache/kafka/pull/19677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087031341 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +329,84 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087037433 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/UtilsTest.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087027573 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +329,84 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087026067 ## build.gradle: ## @@ -1414,10 +1414,12 @@ project(':group-coordinator') { implementation project(':coordinator-common') implementation libs.jacksonDat

Re: [PR] KAFKA-19253: Improve metadata handling for share version using feature listeners (1/N) [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield merged PR #19659: URL: https://github.com/apache/kafka/pull/19659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-13 Thread via GitHub
kirktrue commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2086871765 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/DefaultJwtRetriever.java: ## @@ -86,6 +90,18 @@ public static AccessTokenRetrie

Re: [PR] KAFKA-18904: [1/N] Change ListClientMetricsResources API to ListConfigResources [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19493: URL: https://github.com/apache/kafka/pull/19493#discussion_r2086922412 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -10929,47 +10928,231 @@ class KafkaApisTest extends Logging { } @Test - def testListC

Re: [PR] KAFKA-18904: [1/N] Change ListClientMetricsResources API to ListConfigResources [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19493: URL: https://github.com/apache/kafka/pull/19493#discussion_r2086921570 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2874,16 +2874,55 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleLis

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-13 Thread via GitHub
kirktrue commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2086872075 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/DefaultJwtValidator.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache S

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-13 Thread via GitHub
kirktrue commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2086875757 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerValidatorCallbackHandlerTest.java: ## @@ -106,11 +109,13 @@ public OAuthBearerToken va

Re: [PR] KAFKA-19116, KAFKA-19258: Handling share group member change events [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19666: URL: https://github.com/apache/kafka/pull/19666#discussion_r2086868597 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -143,6 +191,7 @@ public synchronized ShareSessionKey maybeCreateSes

Re: [PR] KAFKA-19206: ConsumerNetworkThread.cleanup() throws NullPointerException if initializeResources() previously failed [kafka]

2025-05-13 Thread via GitHub
kirktrue commented on code in PR #19569: URL: https://github.com/apache/kafka/pull/19569#discussion_r2086890019 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -339,11 +339,20 @@ void cleanup() { log.trace("Closing

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-05-13 Thread via GitHub
lianetm merged PR #19595: URL: https://github.com/apache/kafka/pull/19595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-19201) Handle deletion of a topic which has initialised share-group state

2025-05-13 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19201. -- Fix Version/s: 4.1.0 Resolution: Fixed > Handle deletion of a topic which has i

Re: [PR] KAFKA-19201: Handle deletion of user topics part of share partitions. [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield merged PR #19559: URL: https://github.com/apache/kafka/pull/19559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19201: Handle deletion of user topics part of share partitions. [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19559: URL: https://github.com/apache/kafka/pull/19559#discussion_r2086801802 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinator.java: ## @@ -120,6 +124,14 @@ public interface ShareCoordinator {

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-13 Thread via GitHub
dajac commented on PR #19611: URL: https://github.com/apache/kafka/pull/19611#issuecomment-2876345298 @FrankYang0529 Thanks for the results. Have you also tried to run `ServerSideAssignorBenchmark`? -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086649161 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -44,6 +44,7 @@ public RangeSet(int from, int to) { @O

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-13 Thread via GitHub
lianetm commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2086793268 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerValidatorCallbackHandlerTest.java: ## @@ -106,11 +109,13 @@ public OAuthBearerToken val

[jira] [Resolved] (KAFKA-14691) Add TopicId to OffsetFetch API

2025-05-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14691. - Fix Version/s: 4.1.0 Resolution: Fixed > Add TopicId to OffsetFetch API > ---

Re: [PR] KAFKA-14691; Add TopicId to OffsetFetch API [kafka]

2025-05-13 Thread via GitHub
dajac merged PR #19515: URL: https://github.com/apache/kafka/pull/19515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-19269: `Unexpected error ..` should not happen when the delete.topic.enable is false [kafka]

2025-05-13 Thread via GitHub
xijiu commented on PR #19698: URL: https://github.com/apache/kafka/pull/19698#issuecomment-2876427443 @chia7712 Yeah, it's more appropriate to do it this way. I have fixed it, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-19245: Updated default locks config for share group [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield merged PR #19705: URL: https://github.com/apache/kafka/pull/19705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] changed the default value of metadata_quorum in test methods to quorum.isolted_kraft where quorum.zk was used [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19707: URL: https://github.com/apache/kafka/pull/19707#discussion_r2086734036 ## tests/kafkatest/tests/client/share_consumer_test.py: ## @@ -248,7 +248,7 @@ def test_broker_failure(self, clean_shutdown, metadata_quorum=quorum.isolated_k

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086677598 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -176,8 +185,18 @@ public boolean equals(Object o) { @

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-13 Thread via GitHub
m1a2st commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2086737025 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2994,35 +2992,4 @@ private void waitForAssignment(Str

[jira] [Commented] (KAFKA-17541) Improve handling of delivery count

2025-05-13 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951186#comment-17951186 ] Andrew Schofield commented on KAFKA-17541: -- [~isding_l] I agree that case 2 wil

[jira] [Resolved] (KAFKA-19245) Update defaults for preview of queues configurations

2025-05-13 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19245. -- Resolution: Fixed > Update defaults for preview of queues configurations > ---

Re: [PR] changed the default value of metadata_quorum in test methods to quorum.isolted_kraft where quorum.zk was used [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19707: URL: https://github.com/apache/kafka/pull/19707#discussion_r2086697553 ## tests/kafkatest/tests/client/share_consumer_test.py: ## @@ -248,7 +248,7 @@ def test_broker_failure(self, clean_shutdown, metadata_quorum=quorum.isolated_k

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2086685337 ## build.gradle: ## @@ -1414,10 +1414,12 @@ project(':group-coordinator') { implementation project(':coordinator-common') implementation libs.jacksonDatabind

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-13 Thread via GitHub
m1a2st commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2086701640 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -913,16 +914,16 @@ public void verifyNoCoordinatorLookupForManualAssignmentWith

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086677598 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -176,8 +185,18 @@ public boolean equals(Object o) { @

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086665383 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -163,6 +171,7 @@ public boolean equals(Object o) { if

[PR] changed the default value of metadata_quorum in test methods to quorum.isolted_kraft where quorum.zk was used [kafka]

2025-05-13 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19707: URL: https://github.com/apache/kafka/pull/19707 There were some tests in share_consumer_test, where the default value of metadata_quorum was quorum.zk. That is change to quorum.isolted_kraft in this PR -- This is an automated message from

[jira] [Resolved] (KAFKA-19163) New group coordinator can incorrectly delete groups with pending transactional offsets

2025-05-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-19163. - Fix Version/s: 4.0.1 4.1.0 Resolution: Fixed > New group coordinator c

Re: [PR] KAFKA-19163: Avoid deleting groups with pending transactional offsets [kafka]

2025-05-13 Thread via GitHub
dajac commented on PR #19496: URL: https://github.com/apache/kafka/pull/19496#issuecomment-2876257768 Merged to trunk and 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-19271: Add internal ConsumerWrapper [kafka]

2025-05-13 Thread via GitHub
lucasbru commented on PR #19697: URL: https://github.com/apache/kafka/pull/19697#issuecomment-2876257325 You could consider enabling `KafkaStreamsTelemetryIntegrationTest` with the new wrapper for the new protocol to actually test that your changes work. Wdyt? -- This is an automated mess

Re: [PR] KAFKA-19163: Avoid deleting groups with pending transactional offsets [kafka]

2025-05-13 Thread via GitHub
dajac merged PR #19496: URL: https://github.com/apache/kafka/pull/19496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-19141; Persist topic id in OffsetCommit record [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19683: URL: https://github.com/apache/kafka/pull/19683#discussion_r2086668181 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetAndMetadataTest.java: ## @@ -16,52 +16,69 @@ */ package org.apache.kafka.coordinator.group;

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086647061 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -218,6 +234,15 @@ private void maybeRevokeP

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086663038 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -163,6 +171,7 @@ public boolean equals(Object o) { if

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086645708 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -152,8 +152,13 @@ public GroupAssignment bu

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086658896 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -152,8 +152,13 @@ public GroupAss

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086658896 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -152,8 +152,13 @@ public GroupAss

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on PR #19678: URL: https://github.com/apache/kafka/pull/19678#issuecomment-2876233084 @FrankYang0529 We don't create ranges like that anywhere right now. I think it's easy to do by accident when working with ranges in general. I had a look around at what other rang

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086650043 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeSetTest.java: ## @@ -32,16 +32,30 @@ public class RangeSetTest { +@

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086619092 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -218,6 +234,15 @@ private void ma

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on PR #19611: URL: https://github.com/apache/kafka/pull/19611#issuecomment-2876171380 > Out of curiosity, have you tried to run the benchmarks before and after the change to see the impact? Since previous `SubscribedTopicDescriberImpl` only supports `numOfPart

Re: [PR] KAFKA-19246; OffsetFetch API does not return group level errors correctly with version 1 [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19704: URL: https://github.com/apache/kafka/pull/19704#discussion_r2086497841 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java: ## @@ -239,4 +240,31 @@ public OffsetFetchResponseData data() { public

Re: [PR] KAFKA-19141; Persist topic id in OffsetCommit record [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19683: URL: https://github.com/apache/kafka/pull/19683#discussion_r2086490152 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetAndMetadataTest.java: ## @@ -16,52 +16,69 @@ */ package org.apache.kafka.coordina

[jira] [Assigned] (KAFKA-17853) Console share consumer is not terminated immediately

2025-05-13 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-17853: - Assignee: Shivsundar R (was: Jimmy Wang) > Console share consumer is not terminated im

Re: [PR] KAFKA-19253: Improve metadata handling for share version using feature listeners (1/N) [kafka]

2025-05-13 Thread via GitHub
adixitconfluent commented on code in PR #19659: URL: https://github.com/apache/kafka/pull/19659#discussion_r2086477440 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -455,9 +468,12 @@ public ShareFetchContext newContext( Impli

Re: [PR] MINOR: Add JmxReporter note to metric.reporters [kafka]

2025-05-13 Thread via GitHub
fvaleri commented on PR #19706: URL: https://github.com/apache/kafka/pull/19706#issuecomment-2875838111 cc @mimaison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] MINOR: Add JmxReporter note to metric.reporters [kafka]

2025-05-13 Thread via GitHub
fvaleri opened a new pull request, #19706: URL: https://github.com/apache/kafka/pull/19706 According to KIP-830, in Kafka 4 users currently relying on JmxReporter and that are using additional reporters via metric.reporters will have to include org.apache.kafka.common.metrics.JmxReporter in

[jira] [Commented] (KAFKA-17541) Improve handling of delivery count

2025-05-13 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951151#comment-17951151 ] Apoorv Mittal commented on KAFKA-17541: --- [~isding_l] May be KAFKA-19020 can be hel

Re: [PR] KAFKA-19231-1: Handle fetch request when share session cache is full [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19701: URL: https://github.com/apache/kafka/pull/19701#discussion_r2086392228 ## core/src/main/java/kafka/server/share/IdleShareFetchTimeTask.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[PR] KAFKA-19245: Updated default locks config for share group [kafka]

2025-05-13 Thread via GitHub
apoorvmittal10 opened a new pull request, #19705: URL: https://github.com/apache/kafka/pull/19705 Updated default locks config for share groups from 200 to 2000. The increase in the limit is a result from tests which showed that with default maxFetchRecords of 500 from client and 200 as loc

Re: [PR] MINOR: Improve client error messages for share groups not enabled [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield merged PR #19688: URL: https://github.com/apache/kafka/pull/19688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086378831 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -218,6 +234,15 @@ private void ma

Re: [PR] KAFKA-19163: Avoid deleting groups with pending transactional offsets [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19496: URL: https://github.com/apache/kafka/pull/19496#discussion_r2086375860 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -1006,7 +1006,7 @@ public boolean cleanupExpiredOffsets(

  1   2   >