FrankYang0529 commented on code in PR #19553: URL: https://github.com/apache/kafka/pull/19553#discussion_r2087095791
########## server/src/test/java/org/apache/kafka/server/purgatory/DelayedFutureTest.java: ########## @@ -49,13 +49,11 @@ void testDelayedFuture() throws Exception { .map(Thread::getName) .anyMatch(name -> name.contains("DelayedExecutor-" + purgatoryName)); - Function<List<CompletableFuture<Integer>>, Void> updateResult = futures -> { - result.set(futures.stream() - .filter(Predicate.not(CompletableFuture::isCompletedExceptionally)) - .mapToInt(future -> assertDoesNotThrow(() -> future.get())) - .sum()); - return null; - }; + Consumer<List<CompletableFuture<Integer>>> updateResult = futures -> + result.set(futures.stream() + .filter(Predicate.not(CompletableFuture::isCompletedExceptionally)) + .mapToInt(future -> assertDoesNotThrow(() -> future.get())) + .sum()); Review Comment: Is these change related to race condition fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org