Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
dajac commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1966693057 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2529,9 +2529,24 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrottle(

[jira] [Resolved] (KAFKA-18851) Share RPCs check topic describe permission

2025-02-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18851. Resolution: Duplicate KAFKA-18817 > Share RPCs check topic describe permission >

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1966694050 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2529,9 +2529,24 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrott

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
dajac commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1966693354 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2529,9 +2529,24 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrottle(

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
dajac commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1966692671 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2592,6 +2607,32 @@ class KafkaApis(val requestChannel: RequestChannel, response.groups.addAll(res

[jira] [Commented] (KAFKA-18851) Share RPCs check topic describe permission

2025-02-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929431#comment-17929431 ] Chia-Ping Tsai commented on KAFKA-18851: this is created to prevent us from forg

[jira] [Created] (KAFKA-18851) Share RPCs check topic describe permission

2025-02-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18851: -- Summary: Share RPCs check topic describe permission Key: KAFKA-18851 URL: https://issues.apache.org/jira/browse/KAFKA-18851 Project: Kafka Issue Type: Su

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1966691664 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2529,9 +2529,24 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrott

[jira] [Commented] (KAFKA-16936) Upgrade slf4k to 2.0.9 and integrate "-Dslf4j.provider" to kafka script

2025-02-22 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929430#comment-17929430 ] TengYao Chi commented on KAFKA-16936: - Hi [~muralibasani]  I have read the mail thr

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
dajac commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1966690888 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2529,9 +2529,24 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrottle(

Re: [PR] KAFKA-17937: Use ValueSource to refactor AbstractFetcherThreadTest [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #18900: URL: https://github.com/apache/kafka/pull/18900#discussion_r1966689437 ## core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala: ## @@ -752,22 +752,22 @@ class AbstractFetcherThreadTest { assertEquals(2L, replicaState

[jira] [Commented] (KAFKA-18850) Fix the docs of org.apache.kafka.automatic.config.providers

2025-02-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929426#comment-17929426 ] Chia-Ping Tsai commented on KAFKA-18850: Also, it would be better to add unit te

Re: [PR] KAFKA-18047: Add org.apache.kafka.automatic.config.providers to System Properties section [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #17920: URL: https://github.com/apache/kafka/pull/17920#discussion_r1966687749 ## docs/configuration.html: ## @@ -302,6 +302,22 @@ org.apache.kafka.automatic.config.providers + This system property controls the automatic loading of ConfigPro

[jira] [Created] (KAFKA-18850) Fix the docs of org.apache.kafka.automatic.config.providers

2025-02-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18850: -- Summary: Fix the docs of org.apache.kafka.automatic.config.providers Key: KAFKA-18850 URL: https://issues.apache.org/jira/browse/KAFKA-18850 Project: Kafka

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-02-22 Thread via GitHub
Yunyung commented on code in PR #18918: URL: https://github.com/apache/kafka/pull/18918#discussion_r1966680545 ## build.gradle: ## @@ -2485,7 +2485,9 @@ project(':tools') { from (configurations.runtimeClasspath) { exclude('kafka-clients*') } -from (configura

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-02-22 Thread via GitHub
Yunyung commented on code in PR #18918: URL: https://github.com/apache/kafka/pull/18918#discussion_r1966680545 ## build.gradle: ## @@ -2485,7 +2485,9 @@ project(':tools') { from (configurations.runtimeClasspath) { exclude('kafka-clients*') } -from (configura

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-02-22 Thread via GitHub
Yunyung commented on code in PR #18918: URL: https://github.com/apache/kafka/pull/18918#discussion_r1966680545 ## build.gradle: ## @@ -2485,7 +2485,9 @@ project(':tools') { from (configurations.runtimeClasspath) { exclude('kafka-clients*') } -from (configura

Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on PR #19015: URL: https://github.com/apache/kafka/pull/19015#issuecomment-2676643156 Hi @chia7712 I have run the test three times with different commits, and they all failed due to `Timed out waiting to reach non-zero number of replica lags.` Before this patc

[jira] [Assigned] (KAFKA-18849) add "strict min ISR" to the docs of "min.insync.replicas"

2025-02-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18849: -- Assignee: Wei-Ting Chen (was: Chia-Ping Tsai) > add "strict min ISR" to the docs of

Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on PR #19015: URL: https://github.com/apache/kafka/pull/19015#issuecomment-2676635552 I don't dig in it, but this PR seems to cause another failure ``` TimeoutError("Kafka server didn't finish startup in 60 seconds") Traceback (most recent call last): File

[jira] [Commented] (KAFKA-18849) add "strict min ISR" to the docs of "min.insync.replicas"

2025-02-22 Thread Wei-Ting Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929420#comment-17929420 ] Wei-Ting Chen commented on KAFKA-18849: --- Hi~Chai-Ping Tsai, I can work on this. Ma

[jira] [Created] (KAFKA-18849) add "strict min ISR" to the docs of "min.insync.replicas"

2025-02-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18849: -- Summary: add "strict min ISR" to the docs of "min.insync.replicas" Key: KAFKA-18849 URL: https://issues.apache.org/jira/browse/KAFKA-18849 Project: Kafka

Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on code in PR #19015: URL: https://github.com/apache/kafka/pull/19015#discussion_r1966677024 ## tests/kafkatest/tests/tools/replica_verification_test.py: ## @@ -20,7 +20,6 @@ from ducktape.tests.test import Test from kafkatest.services.verifiable_produce

Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]

2025-02-22 Thread via GitHub
m1a2st commented on code in PR #19015: URL: https://github.com/apache/kafka/pull/19015#discussion_r1966676680 ## tests/kafkatest/tests/tools/replica_verification_test.py: ## @@ -20,7 +20,6 @@ from ducktape.tests.test import Test from kafkatest.services.verifiable_producer im

[jira] [Commented] (KAFKA-18849) add "strict min ISR" to the docs of "min.insync.replicas"

2025-02-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929416#comment-17929416 ] Chia-Ping Tsai commented on KAFKA-18849: https://github.com/apache/kafka/pull/18

Re: [PR] KAFKA-15583: doc update for the "strict min ISR" rule [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on PR #18880: URL: https://github.com/apache/kafka/pull/18880#issuecomment-2676631494 I open https://issues.apache.org/jira/browse/KAFKA-18849 to add similar improvement to docs of "min.insync.replicas" -- This is an automated message from the Apache Git Service. To res

Re: [PR] KAFKA-15583: doc update for the "strict min ISR" rule [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on PR #18880: URL: https://github.com/apache/kafka/pull/18880#issuecomment-2676623525 @dajac it seems you have cherry-pick other PRs to 4.0, so I guess the door is open to cherry-pick to 4.0. Hence, I cherry-pick this doc improvement to 4.0 for now. -- This is an autom

Re: [PR] KAFKA-15583: doc update for the "strict min ISR" rule [kafka]

2025-02-22 Thread via GitHub
chia7712 merged PR #18880: URL: https://github.com/apache/kafka/pull/18880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2676573182 Preview: ![Screenshot from 2025-02-23 12-56-26](https://github.com/user-attachments/assets/cd5f06a2-26dd-4872-865c-bed6324da2d4) -- This is an automated message from the A

[PR] MINOR: Remove zk from replica_verification_test [kafka]

2025-02-22 Thread via GitHub
frankvicky opened a new pull request, #19015: URL: https://github.com/apache/kafka/pull/19015 We could remove zk from the `replica_verification_test` since ak has eliminated zk. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #18918: URL: https://github.com/apache/kafka/pull/18918#discussion_r198518 ## build.gradle: ## @@ -2485,7 +2485,9 @@ project(':tools') { from (configurations.runtimeClasspath) { exclude('kafka-clients*') } -from (configur

[PR] Nilmadhab/co grouped windowed aggrgation [kafka]

2025-02-22 Thread via GitHub
nilmadhab opened a new pull request, #19014: URL: https://github.com/apache/kafka/pull/19014 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testi

Re: [PR] MINOR: update truncation test [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r197621 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_positio

Re: [PR] MINOR: fix flaky TruncationTest.test_offset_truncate [kafka]

2025-02-22 Thread via GitHub
chia7712 closed pull request #19013: MINOR: fix flaky TruncationTest.test_offset_truncate URL: https://github.com/apache/kafka/pull/19013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: fix flaky TruncationTest.test_offset_truncate [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on PR #19013: URL: https://github.com/apache/kafka/pull/19013#issuecomment-2676560016 oh, there is already a PR (#18952) for it - close this as duplicate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r194955 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2592,6 +2607,32 @@ class KafkaApis(val requestChannel: RequestChannel, response.groups.addAll(

Re: [PR] KAFKA-17625: Removing ZK from ducktape [kafka]

2025-02-22 Thread via GitHub
github-actions[bot] closed pull request #17596: KAFKA-17625: Removing ZK from ducktape URL: https://github.com/apache/kafka/pull/17596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-17625: Removing ZK from ducktape [kafka]

2025-02-22 Thread via GitHub
github-actions[bot] commented on PR #17596: URL: https://github.com/apache/kafka/pull/17596#issuecomment-2676542643 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-13361: Support fine-grained compression options [kafka]

2025-02-22 Thread via GitHub
github-actions[bot] commented on PR #11388: URL: https://github.com/apache/kafka/pull/11388#issuecomment-2676542633 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Remove request log space added inadvertently [kafka]

2025-02-22 Thread via GitHub
chia7712 merged PR #19011: URL: https://github.com/apache/kafka/pull/19011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] [MINOR] Clean up share-coordinator [kafka]

2025-02-22 Thread via GitHub
chia7712 merged PR #19007: URL: https://github.com/apache/kafka/pull/19007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: fix flaky TruncationTest.test_offset_truncate [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on PR #19013: URL: https://github.com/apache/kafka/pull/19013#issuecomment-2676539679 This fix will be shipped to trunk only. #18954 disable the ELR for 4.0, so this test is stable in 4.0. Also, the root cause is not related to production code - cc @dajac -- This

Re: [PR] MINOR: TopicIdPartition Records Benchmark [kafka]

2025-02-22 Thread via GitHub
github-actions[bot] commented on PR #18917: URL: https://github.com/apache/kafka/pull/18917#issuecomment-2676533000 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: fix flaky TruncationTest.test_offset_truncate [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on PR #19013: URL: https://github.com/apache/kafka/pull/19013#issuecomment-2676534886 This test is stable if ELR is disabled, since the last replica is still in the ISR so it can trigger election when it is fenced - even though the origin replica leader does NOT see the u

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-02-22 Thread via GitHub
github-actions[bot] commented on PR #18789: URL: https://github.com/apache/kafka/pull/18789#issuecomment-2676533027 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18606: Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest [kafka]

2025-02-22 Thread via GitHub
github-actions[bot] commented on PR #18861: URL: https://github.com/apache/kafka/pull/18861#issuecomment-2676533009 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18477 remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread [kafka]

2025-02-22 Thread via GitHub
github-actions[bot] commented on PR #18489: URL: https://github.com/apache/kafka/pull/18489#issuecomment-2676533138 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18576: Convert ConfigType to Enum [kafka]

2025-02-22 Thread via GitHub
github-actions[bot] commented on PR #18711: URL: https://github.com/apache/kafka/pull/18711#issuecomment-2676533039 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: fix flaky TruncationTest.test_offset_truncate [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #19013: URL: https://github.com/apache/kafka/pull/19013#discussion_r1966656027 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -145,6 +145,6 @@ def none_consumed(this, consumer): err_msg="Timed out waiting for the consum

[PR] MINOR: fix flaky TruncationTest.test_offset_truncate [kafka]

2025-02-22 Thread via GitHub
FrankYang0529 opened a new pull request, #19013: URL: https://github.com/apache/kafka/pull/19013 The case `TruncationTest.test_offset_truncate` is flaky some time on my laptop. I can reproduce the error once every ten attempts. The production code is fine, because in both successful and fai

[jira] [Created] (KAFKA-18848) Flaky test CooperativeConsumerCoordinatorTest#testOutdatedCoordinatorAssignment

2025-02-22 Thread Jira
黃竣陽 created KAFKA-18848: --- Summary: Flaky test CooperativeConsumerCoordinatorTest#testOutdatedCoordinatorAssignment Key: KAFKA-18848 URL: https://issues.apache.org/jira/browse/KAFKA-18848 Project: Kafka

Re: [PR] KAFKA-18844: Fix flaky QuorumControllerTest.testBalancePartitionLeaders() [kafka]

2025-02-22 Thread via GitHub
FrankYang0529 commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2676491844 @ijuma, it looks like `TimelineObject` initial value cannot be `null`, so we can't remove metadata version from `FeatureControlManager.Builder`. https://github.com/apache/kaf

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
dajac commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1966467863 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json: ## @@ -30,6 +30,7 @@ // - UNSUPPORTED_ASSIGNOR (version 0+) // - UNRELEASED_INSTAN

Re: [PR] Feature/arch analysis [kafka]

2025-02-22 Thread via GitHub
Jacck commented on PR #18356: URL: https://github.com/apache/kafka/pull/18356#issuecomment-2676423880 My intent is to analyse Kafka architecture, especially to measure coupling, after each commit -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966611062 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant Change

[PR] MINOR: MetadataLoader test to show it waits until the metadata is set [kafka]

2025-02-22 Thread via GitHub
ijuma opened a new pull request, #19012: URL: https://github.com/apache/kafka/pull/19012 TODO: Check that the event queue is empty before the following line: `assertFalse(publishers.get(0).firstPublish.isDone());` ### Committer Checklist (excluded from commit message) - [ ] V

[PR] MINOR: Remove request log space added inadvertently [kafka]

2025-02-22 Thread via GitHub
ijuma opened a new pull request, #19011: URL: https://github.com/apache/kafka/pull/19011 This was done as part of #18313. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

Re: [PR] KAFKA-18827: Initialize share group state persister impl [2/N]. [kafka]

2025-02-22 Thread via GitHub
smjn commented on PR #18992: URL: https://github.com/apache/kafka/pull/18992#issuecomment-2676412798 > @smjn Please resolve the conflicts. @AndrewJSchofield synced with trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-18844: Fix flaky QuorumControllerTest.testBalancePartitionLeaders() [kafka]

2025-02-22 Thread via GitHub
ijuma commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2676396427 > So, it does seem reasonable to initialize it to null. @cmccabe : What do you think? It looks like this would basically always be `null` outside of tests and it would fail in the fo

Re: [PR] KAFKA-18827: Initialize share group state persister impl [2/N]. [kafka]

2025-02-22 Thread via GitHub
AndrewJSchofield commented on PR #18992: URL: https://github.com/apache/kafka/pull/18992#issuecomment-2676390314 @smjn Please resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (KAFKA-18733) Implement share group metrics for share fetch

2025-02-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-18733: -- Fix Version/s: 4.1.0 > Implement share group metrics for share fetch > ---

[jira] [Updated] (KAFKA-18734) Implement share partition metrics for share fetch

2025-02-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-18734: -- Fix Version/s: 4.1.0 > Implement share partition metrics for share fetch > ---

[jira] [Updated] (KAFKA-18732) Implement broker topic metrics for share fetch

2025-02-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-18732: -- Fix Version/s: 4.1.0 > Implement broker topic metrics for share fetch > --

[jira] [Resolved] (KAFKA-18733) Implement share group metrics for share fetch

2025-02-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-18733. --- Resolution: Fixed > Implement share group metrics for share fetch >

[PR] KAFKA-17351: Improved handling of compacted topics in share partition (2/N) [kafka]

2025-02-22 Thread via GitHub
apoorvmittal10 opened a new pull request, #19010: URL: https://github.com/apache/kafka/pull/19010 The PR handles fetch for `compacted` topics. The fix was required only when complete batch disappears from the topic log, and same batch is marked re-available in Share Partition state cache. S

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
dajac commented on PR #18989: URL: https://github.com/apache/kafka/pull/18989#issuecomment-2676362289 @dongnuo123 Thanks for the update. The patch looks pretty good to me. There are some test failures which are related. Could you please check them with @lianetm? -- This is an automated m

Re: [PR] KAFKA-18748 Run new tests separately in PRs [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #18770: URL: https://github.com/apache/kafka/pull/18770#discussion_r1966585438 ## build.gradle: ## @@ -578,45 +562,6 @@ subprojects { finalizedBy("copyTestXml") } - task quarantinedTest(type: Test, dependsOn: compileJava) { -// Dis

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-22 Thread via GitHub
dongnuo123 commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1966547291 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeTest.java: ## @@ -522,6 +524,13 @@ public CoordinatorShardBuilder w

[jira] [Commented] (KAFKA-18648) kafka-python requires metadata request version 0

2025-02-22 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929382#comment-17929382 ] Ismael Juma commented on KAFKA-18648: - [~dana.powers] good to hear kafka-python has

[jira] [Commented] (KAFKA-18648) kafka-python requires metadata request version 0

2025-02-22 Thread Dana Powers (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929378#comment-17929378 ] Dana Powers commented on KAFKA-18648: - fwiw, kafka-python is not abandoned. I'm plan

Re: [PR] KAFKA-18792 Add workflow to check PR format [kafka]

2025-02-22 Thread via GitHub
jolshan commented on PR #18985: URL: https://github.com/apache/kafka/pull/18985#issuecomment-2676326460 I ran the command on this PR and it seems to have passed. Is that expected? ``` GITHUB_ACTIONS=1 PR_NUMBER=18985 python .github/scripts/pr-format.py Read env GITHUB_ACTIONS: 1

[PR] [MINOR] Clean up coordinator-common and server modules [kafka]

2025-02-22 Thread via GitHub
sjhajharia opened a new pull request, #19009: URL: https://github.com/apache/kafka/pull/19009 Given that now we support Java 17 on our brokers, this PR replace the use of : Collections.singletonList() and Collections.emptyList() with List.of() Collections.singletonMap() and Collect

[jira] [Updated] (KAFKA-15995) Mechanism for plugins and connectors to register metrics

2025-02-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-15995: --- Description: Ticket for [KIP-877|https://cwiki.apache.org/confluence/display/KAFKA/KIP-877%3

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966538143 ## docs/upgrade.html: ## @@ -61,8 +61,7 @@ Notable changes in 4 Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, broker

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-02-22 Thread via GitHub
wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r1966554660 ## metadata/src/main/java/org/apache/kafka/metadata/VersionRange.java: ## @@ -56,13 +56,6 @@ public boolean contains(short version) { return version >= min &&

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-02-22 Thread via GitHub
wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r1966554660 ## metadata/src/main/java/org/apache/kafka/metadata/VersionRange.java: ## @@ -56,13 +56,6 @@ public boolean contains(short version) { return version >= min &&

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-02-22 Thread via GitHub
wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r1966554092 ## metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java: ## @@ -466,11 +466,4 @@ public String toString() { ", partitionEpoch="

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-02-22 Thread via GitHub
wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r1966553844 ## metadata/src/main/java/org/apache/kafka/metadata/LeaderAndIsr.java: ## @@ -75,10 +72,6 @@ public LeaderAndIsr( this.partitionEpoch = partitionEpoch; }

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-02-22 Thread via GitHub
wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r1966553603 ## metadata/src/main/java/org/apache/kafka/image/ClusterImage.java: ## @@ -66,10 +66,6 @@ public Map controllers() { return controllers; } -public

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-02-22 Thread via GitHub
wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r1966552907 ## metadata/src/main/java/org/apache/kafka/metadata/LeaderAndIsr.java: ## @@ -133,20 +126,6 @@ public List isr() { .collect(Collectors.toList());

Re: [PR] [MINOR] Clean up share-coordinator [kafka]

2025-02-22 Thread via GitHub
AndrewJSchofield commented on PR #19007: URL: https://github.com/apache/kafka/pull/19007#issuecomment-2676290641 @sjhajharia Please merge the latest changes from trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [MINOR] Clean up share-coordinator [kafka]

2025-02-22 Thread via GitHub
sjhajharia commented on PR #19007: URL: https://github.com/apache/kafka/pull/19007#issuecomment-2676294091 Done Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-02-22 Thread via GitHub
wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r1966550827 ## metadata/src/main/java/org/apache/kafka/controller/errors/ControllerExceptions.java: ## @@ -40,21 +40,6 @@ public static boolean isTimeoutException(Throwable excep

Re: [PR] MINOR: Update version is doc [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on PR #19006: URL: https://github.com/apache/kafka/pull/19006#issuecomment-2676291608 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] [MINOR] Clean up group-coordinator [kafka]

2025-02-22 Thread via GitHub
sjhajharia opened a new pull request, #19008: URL: https://github.com/apache/kafka/pull/19008 Given that now we support Java 17 on our brokers, this PR replace the use of : - `Collections.singletonList()` and `Collections.emptyList()` with `List.of()` - `Collections.singletonMap()` an

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-02-22 Thread via GitHub
wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r1966548309 ## metadata/src/main/java/org/apache/kafka/image/TopicDelta.java: ## @@ -129,20 +129,6 @@ public TopicImage apply() { return new TopicImage(image.name(), imag

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-02-22 Thread via GitHub
wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r1966548309 ## metadata/src/main/java/org/apache/kafka/image/TopicDelta.java: ## @@ -129,20 +129,6 @@ public TopicImage apply() { return new TopicImage(image.name(), imag

Re: [PR] KAFKA-18629: ShareGroupDeleteState admin client impl. [kafka]

2025-02-22 Thread via GitHub
AndrewJSchofield merged PR #18928: URL: https://github.com/apache/kafka/pull/18928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-17351: Update tests and acquire API to allow discard batches from compacted topics (1/N) [kafka]

2025-02-22 Thread via GitHub
AndrewJSchofield merged PR #18978: URL: https://github.com/apache/kafka/pull/18978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18827: Initialize share state, share coordinator impl. [1/N] [kafka]

2025-02-22 Thread via GitHub
AndrewJSchofield merged PR #18968: URL: https://github.com/apache/kafka/pull/18968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Updated] (KAFKA-14560) Remove old client protocol API versions in Kafka 4.0 (KIP-896)

2025-02-22 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14560: Fix Version/s: (was: 4.0.0) > Remove old client protocol API versions in Kafka 4.0 (KIP-896) >

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
m1a2st commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966539348 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966539300 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant C

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966539300 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant C

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966538457 ## docs/upgrade.html: ## @@ -61,8 +61,7 @@ Notable changes in 4 Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, b

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966538256 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant Change

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966538017 ## docs/upgrade.html: ## @@ -62,7 +62,6 @@ Notable changes in 4 the software and metadata versions must be at least 3.3.x (the first version when KRaft mode

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966533946 ## docs/upgrade.html: ## @@ -62,7 +62,6 @@ Notable changes in 4 the software and metadata versions must be at least 3.3.x (the first version when KRaft

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2676263110 Preview: ![image](https://github.com/user-attachments/assets/8656a660-4dd7-4aba-881f-d0c12a472b79) ![Screenshot from 2025-02-22 23-30-22](https://github.com/user-attachments/asse

[PR] [MINOR] Clean up share-coordinator [kafka]

2025-02-22 Thread via GitHub
sjhajharia opened a new pull request, #19007: URL: https://github.com/apache/kafka/pull/19007 Given that now we support Java 17 on our brokers, this PR replace the use of `Collections.singletonList()` and `Collections.emptyList()` with `List.of()` -- This is an automated message from the

  1   2   >