dajac commented on code in PR #18989:
URL: https://github.com/apache/kafka/pull/18989#discussion_r1966690888
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2529,9 +2529,24 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendMaybeThrottle(request,
consumerGroupHeartbeatRequest.getErrorResponse(Errors.GROUP_AUTHORIZATION_FAILED.exception))
CompletableFuture.completedFuture[Unit](())
} else {
+ if (consumerGroupHeartbeatRequest.data.subscribedTopicNames != null &&
Review Comment:
Yes but it will be treated separately. This is a critical blocker for 4.0
for the new consumer protocol whereas it is not for share group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
