[PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-02-19 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #18976: URL: https://github.com/apache/kafka/pull/18976 This PR contains the implementation of KafkaAdminClient and GroupCoordinator for DeleteShareGroupOffsets RPC. This PR is a followup on [this](https://github.com/apache/kafka/pull/18927).

[jira] [Comment Edited] (KAFKA-18820) CVE-2025-24970 [netty-handler]

2025-02-19 Thread Vishal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928662#comment-17928662 ] Vishal edited comment on KAFKA-18820 at 2/20/25 7:01 AM: - Hi [~c

[jira] [Commented] (KAFKA-18820) CVE-2025-24970 [netty-handler]

2025-02-19 Thread Vishal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928662#comment-17928662 ] Vishal commented on KAFKA-18820: Hi [~chia7712] , you had helped with a similar issue la

Re: [PR] MINOR: cleanup SinkNode generics [kafka]

2025-02-19 Thread via GitHub
mjsax commented on code in PR #18975: URL: https://github.com/apache/kafka/pull/18975#discussion_r1962942277 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/WrappingNullableUtils.java: ## @@ -62,25 +62,25 @@ private static Serde prepareSerde(final Serde spe

Re: [PR] MINOR: disallow rawtypes and fail build [kafka]

2025-02-19 Thread via GitHub
mjsax commented on code in PR #18877: URL: https://github.com/apache/kafka/pull/18877#discussion_r1962940507 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java: ## @@ -56,18 +56,19 @@ public void addChild(final ProcessorNode child) { th

[PR] MINOR: cleanup SinkNode generics [kafka]

2025-02-19 Thread via GitHub
mjsax opened a new pull request, #18975: URL: https://github.com/apache/kafka/pull/18975 Follow up to https://github.com/apache/kafka/pull/18877#discussion_r1961407894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [WIP]KAFKA-18331: Migrating to log4j2 introduce behavior changes of adjusting level dynamically [kafka]

2025-02-19 Thread via GitHub
frankvicky commented on code in PR #18969: URL: https://github.com/apache/kafka/pull/18969#discussion_r1962907658 ## core/src/main/scala/kafka/utils/LoggingController.scala: ## @@ -112,24 +112,30 @@ private class Log4jCoreController extends LoggingControllerDelegate { val

[jira] [Assigned] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ukpa Uchechi reassigned KAFKA-18836: Assignee: Ukpa Uchechi > Make ConsumerGroupMetadata an interface > --

[jira] [Commented] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928643#comment-17928643 ] Matthias J. Sax commented on KAFKA-18836: - Sure. :)  > Make ConsumerGroupMetada

Re: [PR] KAFKA-18713: Fix left join bug by using DELETE_KEY_NO_PROPAGATE [kafka]

2025-02-19 Thread via GitHub
nilmadhab commented on PR #18887: URL: https://github.com/apache/kafka/pull/18887#issuecomment-2670380898 @mjsax it makes sense to me. 1. I can remove the` KTableKTableForeignKeyLeftJoinDistributedTest.java` in this MR. 2. I will check if I can reproduce the issue `KTableKTableFor

Re: [PR] [DO NOT MERGE] introduce FactoryWrappingStoreBuilder [kafka]

2025-02-19 Thread via GitHub
github-actions[bot] commented on PR #17891: URL: https://github.com/apache/kafka/pull/17891#issuecomment-2670383960 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-10462: Add ability to pass headers to ProducerPerformance. [kafka]

2025-02-19 Thread via GitHub
github-actions[bot] closed pull request #17462: KAFKA-10462: Add ability to pass headers to ProducerPerformance. URL: https://github.com/apache/kafka/pull/17462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-17981:add Integration test for ConfigCommand to add config `key=[val1,val2]` [kafka]

2025-02-19 Thread via GitHub
github-actions[bot] commented on PR #17771: URL: https://github.com/apache/kafka/pull/17771#issuecomment-2670383859 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] [DO NOT MERGE] convert aggregate API to ProcessorSupplier#stores method [kafka]

2025-02-19 Thread via GitHub
github-actions[bot] commented on PR #17833: URL: https://github.com/apache/kafka/pull/17833#issuecomment-2670383936 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-10462: Add ability to pass headers to ProducerPerformance. [kafka]

2025-02-19 Thread via GitHub
github-actions[bot] commented on PR #17462: URL: https://github.com/apache/kafka/pull/17462#issuecomment-2670383789 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

[jira] [Comment Edited] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928629#comment-17928629 ] Ukpa Uchechi edited comment on KAFKA-18836 at 2/20/25 3:30 AM: ---

[jira] [Comment Edited] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928629#comment-17928629 ] Ukpa Uchechi edited comment on KAFKA-18836 at 2/20/25 3:29 AM: ---

[jira] [Commented] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928629#comment-17928629 ] Ukpa Uchechi commented on KAFKA-18836: -- Hi, @Matthias, can I pick this up? > Make

Re: [PR] KAFKA-18332: fix ClassDataAbstractionCoupling problem in KafkaRaftClientTest(1/2) [kafka]

2025-02-19 Thread via GitHub
leaf-soba commented on PR #18926: URL: https://github.com/apache/kafka/pull/18926#issuecomment-2670367999 Hi @ijuma, @chia7712, @gongxuanzhang, could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-02-19 Thread via GitHub
mjsax commented on PR #15615: URL: https://github.com/apache/kafka/pull/15615#issuecomment-2670306856 @AyoubOm -- I am finally spending time on this. I am still muling over the problem etc... Not sure if you are still interested to contribute a fix? If not, also ok with me, and I can submit

[jira] [Created] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-19 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-18836: --- Summary: Make ConsumerGroupMetadata an interface Key: KAFKA-18836 URL: https://issues.apache.org/jira/browse/KAFKA-18836 Project: Kafka Issue Type: Imp

Re: [PR] KAFKA-18713: Fix left join bug by using DELETE_KEY_NO_PROPAGATE [kafka]

2025-02-19 Thread via GitHub
mjsax commented on PR #18887: URL: https://github.com/apache/kafka/pull/18887#issuecomment-2670317669 @nilmadhab -- I am actively working on my side to dig into FK join to refresh my memory and to fully understand the problem and fix, and will cycle back soon. One thing I noticed is,

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
m1a2st commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1962771254 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant Chang

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
frankvicky commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2670312682 In order to the future section of `Kraft related-features`, I have slightly modified the content of `zk2kraft`: ![Screenshot from 2025-02-20 10-27-52](https://github.com/user-attach

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2025-02-19 Thread via GitHub
mjsax commented on PR #15607: URL: https://github.com/apache/kafka/pull/15607#issuecomment-2670309222 Btw, there is also https://github.com/apache/kafka/pull/18887 which fixes something similar... We need to coordinate the two PRs. -- This is an automated message from the Apache Git Servi

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2025-02-19 Thread via GitHub
mjsax commented on PR #15607: URL: https://github.com/apache/kafka/pull/15607#issuecomment-2670307552 @AyoubOm -- I am finally spending time on this. I am still muling over the problem etc... Not sure if you are still interested to contribute a fix? If not, also ok with me, and I can submit

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2670280840 > Create a page with a title: "Differences between kraft mode and zk mode". This page exists in trunk/4.0 and describes the differences between both. This is useful for anyone that is fa

[jira] [Updated] (KAFKA-18791) Set default commit message to PR title + body

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18791: --- Fix Version/s: 4.1.0 > Set default commit message to PR title + body > -

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-19 Thread via GitHub
frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1962729391 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java: ## @@ -123,8 +123,7 @@ public class ConsumerMembershipManager ex

[jira] [Assigned] (KAFKA-18791) Set default commit message to PR title + body

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18791: -- Assignee: David Arthur > Set default commit message to PR title + body >

[jira] [Resolved] (KAFKA-17420) Fix flaky StreamThreadTest.tearDown

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17420. Resolution: Duplicate agree to close this ticket. loop it 500times on my local. all pass

Re: [PR] KAFKA-18834 Fix testSetLevelWithValidRootLoggerNames for testSetLevel… [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on PR #18972: URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669615037 Hi maintainers, could you please approve this workflow when you have a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-19 Thread via GitHub
junrao commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1962522903 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1817,14 +1839,15 @@ private void appendAsFollower( partitionState.updateState();

[jira] [Updated] (KAFKA-10902) IllegalMonitorStateException in KafkaProducer.waitOnMetadata

2025-02-19 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-10902: -- Component/s: clients > IllegalMonitorStateException in KafkaProducer.waitOnMetadata >

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-19 Thread via GitHub
ahuang98 commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1962415345 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1086,63 +1088,79 @@ class UnifiedLog(@volatile var logStartOffset: Long, var shallowOffsetOfMaxTimestamp

[jira] [Resolved] (KAFKA-18835) Remove redundant kraft quorum param from consumer integration tests

2025-02-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-18835. Resolution: Duplicate > Remove redundant kraft quorum param from consumer integration test

[jira] [Commented] (KAFKA-18835) Remove redundant kraft quorum param from consumer integration tests

2025-02-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928599#comment-17928599 ] Lianet Magrans commented on KAFKA-18835: It's a dup indeed, I wasn't aware of th

[jira] [Resolved] (KAFKA-16918) TestUtils#assertFutureThrows should use future.get with timeout

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16918. Fix Version/s: 4.1.0 Resolution: Fixed > TestUtils#assertFutureThrows should use fu

Re: [PR] KAFKA-16918: TestUtils#assertFutureThrows should use future.get with timeout [kafka]

2025-02-19 Thread via GitHub
chia7712 merged PR #18891: URL: https://github.com/apache/kafka/pull/18891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-18835) Remove redundant kraft quorum param from consumer integration tests

2025-02-19 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928589#comment-17928589 ] 黃竣陽 commented on KAFKA-18835: - Hello [~lianetm], It is a dulpicate of KAFKA-18695? Or should

Re: [PR] MINOR: Rearrange configs in GroupCoordinatorConfigs [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on code in PR #18970: URL: https://github.com/apache/kafka/pull/18970#discussion_r1962493256 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfigTest.java: ## @@ -46,8 +46,8 @@ public class GroupCoordinatorConfigTest

Re: [PR] KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on PR #18972: URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669973567 Another way is to reset the log level in `testSetLevelWithValidRootLoggerNames`. It changes "all" loggers, so it may impact other tests too. -- This is an automated message from the A

[jira] [Resolved] (KAFKA-18822) Fail test LoggingResourceTest#testSetLevelDefaultScope, testSetLevelInvalidScope

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18822. Resolution: Duplicate see KAFKA-18834 > Fail test LoggingResourceTest#testSetLevelDefault

[jira] [Commented] (KAFKA-17420) Fix flaky StreamThreadTest.tearDown

2025-02-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928582#comment-17928582 ] Matthias J. Sax commented on KAFKA-17420: - Just stumbled across this ticket. Loo

Re: [PR] KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on code in PR #18972: URL: https://github.com/apache/kafka/pull/18972#discussion_r1962485553 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResourceTest.java: ## @@ -113,7 +113,7 @@ public void setLevelWithInvalidArgTes

Re: [PR] MINOR: fix Kafka Streams "smoke test" pass criteria [kafka]

2025-02-19 Thread via GitHub
mjsax merged PR #18835: URL: https://github.com/apache/kafka/pull/18835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-19 Thread via GitHub
dongnuo123 opened a new pull request, #18974: URL: https://github.com/apache/kafka/pull/18974 This patch filters out the topic describe unauthorized topics from the ConsumerGroupHeartbeat and ConsumerGroupDescribe response. ### Committer Checklist (excluded from commit message) - [

Re: [PR] KAFKA-18748 Run new tests separately in PRs [kafka]

2025-02-19 Thread via GitHub
mumrah commented on PR #18770: URL: https://github.com/apache/kafka/pull/18770#issuecomment-2669850896 @chia7712 can you take another look at this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-19 Thread via GitHub
ahuang98 commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1962425394 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1159,6 +1180,25 @@ class UnifiedLog(@volatile var logStartOffset: Long, validBytesCount, lastOffsetOfF

Re: [PR] KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on PR #18972: URL: https://github.com/apache/kafka/pull/18972#issuecomment-2669837799 Personally, I prefer to adjust the level for the testSetLevelDefaultScope. Please see my comment on the jira -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-18572: Update Kafka Streams metric documenation [kafka]

2025-02-19 Thread via GitHub
bbejeck commented on code in PR #18673: URL: https://github.com/apache/kafka/pull/18673#discussion_r1962348788 ## docs/ops.html: ## @@ -2888,6 +2898,21 @@ Review Comment: ```suggestion The fraction of time the thread spends performing punctuating actions on acti

Re: [PR] MINOR: disallow rawtypes and fail build [kafka]

2025-02-19 Thread via GitHub
mjsax merged PR #18877: URL: https://github.com/apache/kafka/pull/18877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] Test another PR with multiple commits [kafka]

2025-02-19 Thread via GitHub
mumrah closed pull request #18973: Test another PR with multiple commits URL: https://github.com/apache/kafka/pull/18973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[jira] [Updated] (KAFKA-18835) Remove redundant kraft quorum param from consumer integration tests

2025-02-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18835: --- Component/s: consumer > Remove redundant kraft quorum param from consumer integration tests

Re: [PR] MIINOR: Remove redundant quorum parameter from *AdminIntegrationTest classes [kafka]

2025-02-19 Thread via GitHub
lianetm merged PR #18965: URL: https://github.com/apache/kafka/pull/18965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: disallow rawtypes and fail build [kafka]

2025-02-19 Thread via GitHub
mjsax commented on code in PR #18877: URL: https://github.com/apache/kafka/pull/18877#discussion_r1962363168 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java: ## @@ -56,18 +56,19 @@ public void addChild(final ProcessorNode child) { th

[jira] [Created] (KAFKA-18835) Remove redundant kraft quorum param from consumer integration tests

2025-02-19 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-18835: -- Summary: Remove redundant kraft quorum param from consumer integration tests Key: KAFKA-18835 URL: https://issues.apache.org/jira/browse/KAFKA-18835 Project: Kafk

[jira] [Resolved] (KAFKA-18791) Set default commit message to PR title + body

2025-02-19 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-18791. -- Resolution: Fixed > Set default commit message to PR title + body > --

[PR] KAFKA-18834 Fix testSetLevelWithValidRootLoggerNames for testSetLevel… [kafka]

2025-02-19 Thread via GitHub
mingdaoy opened a new pull request, #18972: URL: https://github.com/apache/kafka/pull/18972 https://issues.apache.org/jira/browse/KAFKA-18834 ``` ./gradlew cleanTest connect:runtime:test --tests LoggersTest.testSetLevelWithValidRootLoggerNames --tests LoggingResourceTest.testSetLe

Re: [PR] KAFKA-18791 Set default commit to PR title and description [2/n] [kafka]

2025-02-19 Thread via GitHub
mumrah merged PR #18967: URL: https://github.com/apache/kafka/pull/18967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18791 Set default commit to PR title and description [2/n] [kafka]

2025-02-19 Thread via GitHub
mumrah commented on PR #18967: URL: https://github.com/apache/kafka/pull/18967#issuecomment-2669615504 Here is a PR with one commit: https://github.com/user-attachments/assets/02bb13d3-ef33-44c4-a0fe-c0f6ba6cdfd3"; /> And one with multiple commits: https://github.com/use

[PR] Test another PR with multiple commits [kafka]

2025-02-19 Thread via GitHub
mumrah opened a new pull request, #18973: URL: https://github.com/apache/kafka/pull/18973 Hopefully we see this message instead of the individual commits in a list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Testing a PR with one commit [kafka]

2025-02-19 Thread via GitHub
mumrah closed pull request #18971: Testing a PR with one commit URL: https://github.com/apache/kafka/pull/18971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Testing a PR with one commit [kafka]

2025-02-19 Thread via GitHub
mumrah opened a new pull request, #18971: URL: https://github.com/apache/kafka/pull/18971 Hopefully this shows as the commit message and not "commit one" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-18834) Fix LoggingResourceTest#testSetLevelDefaultScope

2025-02-19 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928553#comment-17928553 ] Mingdao Yang commented on KAFKA-18834: -- Hi Chia-Ping, I'd be interested in working

[jira] [Assigned] (KAFKA-18834) Fix LoggingResourceTest#testSetLevelDefaultScope

2025-02-19 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingdao Yang reassigned KAFKA-18834: Assignee: Mingdao Yang (was: Chia-Ping Tsai) > Fix LoggingResourceTest#testSetLevelDefau

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2669547889 I merged a change to `upgrade.html`, it would be good to resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-19 Thread via GitHub
junrao commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1962213079 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java: ## @@ -123,8 +123,7 @@ public class ConsumerMembershipManager extend

[jira] [Commented] (KAFKA-18834) Fix LoggingResourceTest#testSetLevelDefaultScope

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928509#comment-17928509 ] Chia-Ping Tsai commented on KAFKA-18834: `testSetLevelDefaultScope` should set t

Re: [PR] MINOR: update truncation test [kafka]

2025-02-19 Thread via GitHub
CalvinConfluent commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r1962165856 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_

[jira] [Updated] (KAFKA-18579) Add TransactionAbortableException instruction in docs

2025-02-19 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina updated KAFKA-18579: -- Fix Version/s: 4.0.0 (was: 4.1.0) > Add TransactionAbortableException i

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-19 Thread via GitHub
jsancio commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1960729769 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1159,6 +1177,25 @@ class UnifiedLog(@volatile var logStartOffset: Long, validBytesCount, lastOffsetOfFi

[jira] [Resolved] (KAFKA-18579) Add TransactionAbortableException instruction in docs

2025-02-19 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina resolved KAFKA-18579. --- Resolution: Fixed > Add TransactionAbortableException instruction in docs >

Re: [PR] MIINOR: Remove redundant quorum parameter from *AdminIntegrationTest classes [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18965: URL: https://github.com/apache/kafka/pull/18965#issuecomment-2669452444 > We could remove the quorum, and just update the check for isShareGroupTest here I pushed a commit that tries to address this - it's a bit odd, but aligned with the current mechanis

Re: [PR] MIINOR: Remove redundant quorum parameter from *AdminIntegrationTest classes [kafka]

2025-02-19 Thread via GitHub
lianetm commented on code in PR #18965: URL: https://github.com/apache/kafka/pull/18965#discussion_r1961868457 ## core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala: ## @@ -131,10 +130,10 @@ class SaslSslAdminIntegrationTest extends BaseAdminIntegration

Re: [PR] KIP-966 part 1 release doc [kafka]

2025-02-19 Thread via GitHub
cmccabe commented on code in PR #18898: URL: https://github.com/apache/kafka/pull/18898#discussion_r1962157974 ## docs/ops.html: ## @@ -4281,6 +4281,32 @@ 6.12 Eligible Leader Replicas + + Overview + + Starting from Apache Kafka 4.0, Eligible Leader Replicas (https://cwiki.ap

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961901627 ## docs/toc.html: ## @@ -27,6 +27,9 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading + +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2668763269 I was thinking that this information is related to the migration from zk to kraft more so than the upgrade to 4.0. We removed the zk to kraft migration docs from trunk and instead, link to

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-19 Thread via GitHub
cmccabe commented on PR #18954: URL: https://github.com/apache/kafka/pull/18954#issuecomment-2669387382 @dajac I commented that this is probably not the right approach. We probably need some kind of custom logic for what you are trying to do since the framework treats the associated MV of

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-02-19 Thread via GitHub
ahuang98 commented on PR #18600: URL: https://github.com/apache/kafka/pull/18600#issuecomment-2669367334 Perhaps we can leave my suggestions in https://github.com/apache/kafka/pull/18600#pullrequestreview-2587264814 as out of scope - I'll give another review today and see if @jsancio has ti

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-02-19 Thread via GitHub
ahuang98 commented on PR #18600: URL: https://github.com/apache/kafka/pull/18600#issuecomment-2669365217 > the easiest way is to test all protocols since the key difference between these protocols is support re-config or not. WDYT? I don't disagree it would be easy/fine to test all

Re: [PR] MINOR: Fix incorrect return value from upgradeFeatures [kafka]

2025-02-19 Thread via GitHub
cmccabe merged PR #18958: URL: https://github.com/apache/kafka/pull/18958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18829: Added check before converting to IMPLICIT mode [kafka]

2025-02-19 Thread via GitHub
AndrewJSchofield merged PR #18964: URL: https://github.com/apache/kafka/pull/18964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[PR] MINOR: Rearrange configs in GroupCoordinatorConfigs [kafka]

2025-02-19 Thread via GitHub
dajac opened a new pull request, #18970: URL: https://github.com/apache/kafka/pull/18970 I was looking into GroupCoordinatorConfigs to review configurations that we will ship with Apache Kafka 4.0. I found out that it was pretty disorganised. This patch cleans up the format and re-groups th

Re: [PR] MINOR: Update upgrade notes for 4.0.0 [kafka]

2025-02-19 Thread via GitHub
ijuma merged PR #18960: URL: https://github.com/apache/kafka/pull/18960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-18834) Fix LoggingResourceTest#testSetLevelDefaultScope

2025-02-19 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928510#comment-17928510 ] Chia-Ping Tsai commented on KAFKA-18834: {code:java} Gradle Test Run :connect:r

[jira] [Created] (KAFKA-18834) Fix LoggingResourceTest#testSetLevelDefaultScope

2025-02-19 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18834: -- Summary: Fix LoggingResourceTest#testSetLevelDefaultScope Key: KAFKA-18834 URL: https://issues.apache.org/jira/browse/KAFKA-18834 Project: Kafka Issue Ty

[jira] [Commented] (KAFKA-18833) Infinite loop on authenticcation error with AWS MSK AIM

2025-02-19 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928507#comment-17928507 ] Greg Harris commented on KAFKA-18833: - Hi [~sergeykad] Thanks for the ticket! Unfor

[jira] [Resolved] (KAFKA-18833) Infinite loop on authenticcation error with AWS MSK AIM

2025-02-19 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-18833. - Resolution: Invalid > Infinite loop on authenticcation error with AWS MSK AIM >

Re: [PR] Add TransactionAbortableException and Timeout Exception handling instruction in docs [kafka]

2025-02-19 Thread via GitHub
jolshan merged PR #18942: URL: https://github.com/apache/kafka/pull/18942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2669244820 > Create a page with a title: "Differences between kraft mode and zk mode". This page exists in trunk/4.0 and describes the differences between both. This is useful for anyone that is fa

[jira] [Comment Edited] (KAFKA-15636) Investigate FetcherTest's/FetchRequestManager's testFetchResponseMetrics

2025-02-19 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928493#comment-17928493 ] Shivsundar R edited comment on KAFKA-15636 at 2/19/25 4:30 PM: ---

Re: [PR] KAFKA-17544: Fix for loading big files while performing load tests [kafka]

2025-02-19 Thread via GitHub
manoj-mathivanan commented on PR #18391: URL: https://github.com/apache/kafka/pull/18391#issuecomment-2669113214 > @manoj-mathivanan could you please merge trunk to run CI again? @chia7712 Thank you soo much for looking into this. The CI has completed. Can you help with the next st

Re: [PR] MINOR: update truncation test [kafka]

2025-02-19 Thread via GitHub
dajac commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r1962052021 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_position(t

Re: [PR] MINOR: deflake EligibleLeaderReplicasIntegrationTest [kafka]

2025-02-19 Thread via GitHub
dajac commented on code in PR #18923: URL: https://github.com/apache/kafka/pull/18923#discussion_r1962047980 ## core/src/test/java/kafka/server/integration/EligibleLeaderReplicasIntegrationTest.java: ## @@ -417,11 +417,21 @@ public void testLastKnownLeaderShouldBeElectedIfEmpty

[PR] [WIP]KAFKA-18331: Migrating to log4j2 introduce behavior changes of adjusting level dynamically [kafka]

2025-02-19 Thread via GitHub
frankvicky opened a new pull request, #18969: URL: https://github.com/apache/kafka/pull/18969 JIRA: KAFKA-18331 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify do

[jira] [Created] (KAFKA-18833) Infinite loop on authenticcation error with AWS MSK AIM

2025-02-19 Thread Sergey Kadaner (Jira)
Sergey Kadaner created KAFKA-18833: -- Summary: Infinite loop on authenticcation error with AWS MSK AIM Key: KAFKA-18833 URL: https://issues.apache.org/jira/browse/KAFKA-18833 Project: Kafka I

[PR] KAFKA-18827: Initialize share state RPC, share coordinator impl. [1/N] [kafka]

2025-02-19 Thread via GitHub
smjn opened a new pull request, #18968: URL: https://github.com/apache/kafka/pull/18968 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing st

[jira] [Comment Edited] (KAFKA-15636) Investigate FetcherTest's/FetchRequestManager's testFetchResponseMetrics

2025-02-19 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928493#comment-17928493 ] Shivsundar R edited comment on KAFKA-15636 at 2/19/25 4:30 PM: ---

[jira] [Commented] (KAFKA-15636) Investigate FetcherTest's/FetchRequestManager's testFetchResponseMetrics

2025-02-19 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928493#comment-17928493 ] Shivsundar R commented on KAFKA-15636: -- Hi [~kirktrue] , I was looking into this. Y

  1   2   >