Re: [PR] KAFAK-18451: Flaky RemoteLogManagerTest#testRLMOpsWhenMetadataIsNotReady [kafka]

2025-01-14 Thread via GitHub
FrankYang0529 commented on PR #18520: URL: https://github.com/apache/kafka/pull/18520#issuecomment-2591860352 Hi @showuon, thanks for trigger CI again. There are some flaky test cases which are not related to this PR. I can't reproduce on my laptop as well. * PlaintextConsumerPollTest

[jira] [Created] (KAFKA-18536) Flaky ReplicationQuotasTest.shouldBootstrapTwoBrokersWithFollowerThrottle

2025-01-14 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18536: - Summary: Flaky ReplicationQuotasTest.shouldBootstrapTwoBrokersWithFollowerThrottle Key: KAFKA-18536 URL: https://issues.apache.org/jira/browse/KAFKA-18536 Project: Kafka

[jira] [Created] (KAFKA-18535) Flaky PlaintextConsumerPollTest.testMaxPollIntervalMsDelayInRevocation

2025-01-14 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18535: - Summary: Flaky PlaintextConsumerPollTest.testMaxPollIntervalMsDelayInRevocation Key: KAFKA-18535 URL: https://issues.apache.org/jira/browse/KAFKA-18535 Project: Kafka

[jira] [Created] (KAFKA-18534) docker build fail because log4j

2025-01-14 Thread TaiJuWu (Jira)
TaiJuWu created KAFKA-18534: --- Summary: docker build fail because log4j Key: KAFKA-18534 URL: https://issues.apache.org/jira/browse/KAFKA-18534 Project: Kafka Issue Type: Bug Reporter: T

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

2025-01-14 Thread via GitHub
m1a2st commented on PR #18050: URL: https://github.com/apache/kafka/pull/18050#issuecomment-2591697583 Thanks for @ijuma, I will take a look which test timeout and make build error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Revert "KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors (#18050)" [kafka]

2025-01-14 Thread via GitHub
ijuma commented on PR #18544: URL: https://github.com/apache/kafka/pull/18544#issuecomment-2591660301 Besides the screenshot in #18050, you can also see that the build was last green just before the relevant commit was merged: https://github.com/user-attachments/assets/861105fc-64e1-4

[PR] Revert "KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors (#18050)" [kafka]

2025-01-14 Thread via GitHub
ijuma opened a new pull request, #18544: URL: https://github.com/apache/kafka/pull/18544 This reverts commit 70d6312a3a69496a949cc87055e9b5ea73f1e6c5. The tests timed out in #18050 and the same has been happening in trunk since. ### Committer Checklist (excluded from commit mess

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

2025-01-14 Thread via GitHub
ijuma commented on PR #18050: URL: https://github.com/apache/kafka/pull/18050#issuecomment-2591655321 This PR didn't pass the tests and trunk (and likely 4.0, but I didn't check) have been broken since https://github.com/user-attachments/assets/9cead107-cad2-46d2-b4be-775f4e19415a";

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

2025-01-14 Thread via GitHub
ijuma commented on PR #18050: URL: https://github.com/apache/kafka/pull/18050#issuecomment-2591655707 Note that it said the PR timed out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-18513: Validate share state topic record count in tests. [kafka]

2025-01-14 Thread via GitHub
smjn commented on PR #18521: URL: https://github.com/apache/kafka/pull/18521#issuecomment-2591651340 > I also had a failure locally in `testConsumerCloseInGroupSequential` because the number of records was incorrect. I expect it's unpredictable for the more complex tests. Then maybe

[jira] [Updated] (KAFKA-18533) Remove KafkaConfig zookeeper related logic

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18533: Parent: KAFKA-17611 Issue Type: Sub-task (was: Improvement) > Remove KafkaConfig zookeeper related logic

[jira] [Created] (KAFKA-18533) Remove KafkaConfig zookeeper related logic

2025-01-14 Thread Jira
黃竣陽 created KAFKA-18533: --- Summary: Remove KafkaConfig zookeeper related logic Key: KAFKA-18533 URL: https://issues.apache.org/jira/browse/KAFKA-18533 Project: Kafka Issue Type: Improvement

[jira] [Resolved] (KAFKA-18531) Remove ZooKeeperClientException

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-18531. - Resolution: Duplicate > Remove ZooKeeperClientException > --- > > Ke

[jira] [Updated] (KAFKA-18427) Remove KafkaZkClient and ZooKeeperClient, ZooKeeperClientException

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18427: Summary: Remove KafkaZkClient and ZooKeeperClient, ZooKeeperClientException (was: Remove KafkaZkClient and ZooKee

[jira] [Commented] (KAFKA-18531) Remove ZooKeeperClientException

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913157#comment-17913157 ] 黃竣陽 commented on KAFKA-18531: - You are right I missed it > Remove ZooKeeperClientException

[jira] [Commented] (KAFKA-18531) Remove ZooKeeperClientException

2025-01-14 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913154#comment-17913154 ] TengYao Chi commented on KAFKA-18531: - Is this ticket a duplicate of [18427|https:/

Re: [PR] KAFKA-18026: KIP-1112, clean up graph node grace period resolution [kafka]

2025-01-14 Thread via GitHub
guozhangwang commented on code in PR #18342: URL: https://github.com/apache/kafka/pull/18342#discussion_r1915899685 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphGraceSearchUtil.java: ## @@ -70,27 +61,4 @@ private static long findAndVerifyWindowG

[jira] [Updated] (KAFKA-18532) Clean Partition.scala zookeeper logic

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18532: Parent: KAFKA-17611 Issue Type: Sub-task (was: Improvement) > Clean Partition.scala zookeeper logic > ---

[jira] [Created] (KAFKA-18532) Clean Partition.scala zookeeper logic

2025-01-14 Thread Jira
黃竣陽 created KAFKA-18532: --- Summary: Clean Partition.scala zookeeper logic Key: KAFKA-18532 URL: https://issues.apache.org/jira/browse/KAFKA-18532 Project: Kafka Issue Type: Improvement Repor

Re: [PR] KAFKA-17572: Clear build scan PR status when re-running the tests [kafka]

2025-01-14 Thread via GitHub
github-actions[bot] commented on PR #17489: URL: https://github.com/apache/kafka/pull/17489#issuecomment-2591573210 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-4915: do not use word "error" while logging with non-error level [kafka]

2025-01-14 Thread via GitHub
github-actions[bot] commented on PR #3751: URL: https://github.com/apache/kafka/pull/3751#issuecomment-2591571621 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

[jira] [Created] (KAFKA-18531) Remove ZooKeeperClientException

2025-01-14 Thread Jira
黃竣陽 created KAFKA-18531: --- Summary: Remove ZooKeeperClientException Key: KAFKA-18531 URL: https://issues.apache.org/jira/browse/KAFKA-18531 Project: Kafka Issue Type: Improvement Reporter: 黃

[jira] [Updated] (KAFKA-18531) Remove ZooKeeperClientException

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18531: Parent: KAFKA-17611 Issue Type: Sub-task (was: Improvement) > Remove ZooKeeperClientException > -

[jira] [Updated] (KAFKA-18530) Remove ZooKeeperInternals

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18530: Parent: KAFKA-17611 Issue Type: Sub-task (was: Improvement) > Remove ZooKeeperInternals > ---

[jira] [Created] (KAFKA-18530) Remove ZooKeeperInternals

2025-01-14 Thread Jira
黃竣陽 created KAFKA-18530: --- Summary: Remove ZooKeeperInternals Key: KAFKA-18530 URL: https://issues.apache.org/jira/browse/KAFKA-18530 Project: Kafka Issue Type: Improvement Reporter: 黃竣陽

Re: [PR] [KAFKA-18442] Remove broken upgrade-downgrade-upgrade path. [kafka]

2025-01-14 Thread via GitHub
github-actions[bot] commented on PR #18424: URL: https://github.com/apache/kafka/pull/18424#issuecomment-2591546089 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18026: KIP-1112, clean up graph node grace period resolution [kafka]

2025-01-14 Thread via GitHub
ableegoldman commented on code in PR #18342: URL: https://github.com/apache/kafka/pull/18342#discussion_r1915858876 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GracePeriodGraphNode.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] KAFKA-18026: KIP-1112, clean up StatefulProcessorNode [kafka]

2025-01-14 Thread via GitHub
ableegoldman commented on PR #18195: URL: https://github.com/apache/kafka/pull/18195#issuecomment-2591490942 Merged to trunk and cherrypicked to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-18026: KIP-1112 migrate KTableSuppressProcessorSupplier [kafka]

2025-01-14 Thread via GitHub
ableegoldman commented on PR #18150: URL: https://github.com/apache/kafka/pull/18150#issuecomment-2591490824 Forgot to cherrypick this earlier -- cherrypicked to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-18476: KafkaStreams should swallow TransactionAbortedException [kafka]

2025-01-14 Thread via GitHub
mjsax commented on PR #18487: URL: https://github.com/apache/kafka/pull/18487#issuecomment-2591491011 Merged to `trunk` and cherry-picked to `4.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-18026: KIP-1112, clean up graph node grace period resolution [kafka]

2025-01-14 Thread via GitHub
agavra commented on code in PR #18342: URL: https://github.com/apache/kafka/pull/18342#discussion_r1915851802 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GracePeriodGraphNode.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] KAFAK-18451: Flaky RemoteLogManagerTest#testRLMOpsWhenMetadataIsNotReady [kafka]

2025-01-14 Thread via GitHub
showuon commented on PR #18520: URL: https://github.com/apache/kafka/pull/18520#issuecomment-2591470261 Re-running CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] KAFKA-18476: KafkaStreams should swallow TransactionAbortedException [kafka]

2025-01-14 Thread via GitHub
mjsax merged PR #18487: URL: https://github.com/apache/kafka/pull/18487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18023: Enforcing Explicit Naming for Kafka Streams Internal Topics [kafka]

2025-01-14 Thread via GitHub
mjsax commented on PR #18233: URL: https://github.com/apache/kafka/pull/18233#issuecomment-2591478643 Just one high level comment: can we add the necessary docs update to this PR (ie, adding the new config to the config section, and adding a new `4.1` upgrade section and list the KIP there

Re: [PR] KAFKA-18026: KIP-1112, clean up graph node grace period resolution [kafka]

2025-01-14 Thread via GitHub
ableegoldman commented on code in PR #18342: URL: https://github.com/apache/kafka/pull/18342#discussion_r1915845539 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphGraceSearchUtil.java: ## @@ -70,27 +61,4 @@ private static long findAndVerifyWindowG

Re: [PR] Add an option for ignoring tombstone records while a get on VersionedKeyValueStore [kafka]

2025-01-14 Thread via GitHub
mjsax commented on PR #18398: URL: https://github.com/apache/kafka/pull/18398#issuecomment-2591465863 @Armadindon Thanks for the PR. However, changes to public interface require a KIP (cf https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals). We can keep this

[jira] [Resolved] (KAFKA-18380) Remove KafkaApisTest `raftSupport` and change test to Kraft mode

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-18380. - Resolution: Duplicate > Remove KafkaApisTest `raftSupport` and change test to Kraft mode > -

Re: [PR] KAFKA-18026: KIP-1112, clean up StatefulProcessorNode [kafka]

2025-01-14 Thread via GitHub
ableegoldman merged PR #18195: URL: https://github.com/apache/kafka/pull/18195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Assigned] (KAFKA-18527) SaslClientsWithInvalidCredentialsTest.java and SaslClientsWithInvalidCredentialsTest.scala should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18527: --- Assignee: TengYao Chi > SaslClientsWithInvalidCredentialsTest.java and > SaslClientsWithInvalidCredentials

[jira] [Assigned] (KAFKA-18528) MultipleListenersWithSameSecurityProtocolBaseTest and GssapiAuthenticationTest should run for async consumer

2025-01-14 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18528: --- Assignee: TaiJuWu > MultipleListenersWithSameSecurityProtocolBaseTest and > GssapiAuthenticationTe

[jira] [Assigned] (KAFKA-18526) CustomQuotaCallbackTest should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18526: --- Assignee: 黃竣陽 (was: TaiJuWu) > CustomQuotaCallbackTest should run for async consumer > ---

[jira] [Updated] (KAFKA-18529) PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18529: Parent: KAFKA-18525 Issue Type: Sub-task (was: Test) > PlaintextAdminIntegrationTest and ConsumerRebootst

[jira] [Assigned] (KAFKA-18525) Update the Test should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18525: --- Assignee: 黃竣陽 > Update the Test should run for async consumer > ---

[jira] [Assigned] (KAFKA-18526) CustomQuotaCallbackTest should run for async consumer

2025-01-14 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18526: --- Assignee: TaiJuWu > CustomQuotaCallbackTest should run for async consumer > ---

[jira] [Assigned] (KAFKA-18529) PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer

2025-01-14 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18529: --- Assignee: TaiJuWu > PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for > asy

[jira] [Updated] (KAFKA-18526) CustomQuotaCallbackTest should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18526: Summary: CustomQuotaCallbackTest should run for async consumer (was: PlaintextConsumerAssignorsTest should run fo

Re: [PR] KAFKA-17894: Implemented broker topic metrics for Share Group 1/N (KIP-1103) [kafka]

2025-01-14 Thread via GitHub
junrao commented on code in PR #18444: URL: https://github.com/apache/kafka/pull/18444#discussion_r1915800593 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -693,6 +717,38 @@ private static void removeSharePartitionFromCache( } } +

Re: [PR] MINOR: add KafkaStreams 4.0 information to top-level upgrade section [kafka]

2025-01-14 Thread via GitHub
mjsax commented on code in PR #18543: URL: https://github.com/apache/kafka/pull/18543#discussion_r1915799160 ## docs/upgrade.html: ## @@ -33,9 +33,10 @@ Upgrading to 4.0.0 from any vers Notable changes in 4.0.0 -Old protocol API versions have b

[jira] [Updated] (KAFKA-18528) MultipleListenersWithSameSecurityProtocolBaseTest and GssapiAuthenticationTest should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18528: Parent: KAFKA-18525 Issue Type: Sub-task (was: Test) > MultipleListenersWithSameSecurityProtocolBaseTest

[jira] [Updated] (KAFKA-18527) SaslClientsWithInvalidCredentialsTest.java and SaslClientsWithInvalidCredentialsTest.scala should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18527: Parent: KAFKA-18525 Issue Type: Sub-task (was: Test) > SaslClientsWithInvalidCredentialsTest.java and >

[jira] [Created] (KAFKA-18529) PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer

2025-01-14 Thread Jira
黃竣陽 created KAFKA-18529: --- Summary: PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer Key: KAFKA-18529 URL: https://issues.apache.org/jira/browse/KAFKA-18529 Project: Kafka

[jira] [Created] (KAFKA-18528) MultipleListenersWithSameSecurityProtocolBaseTest and GssapiAuthenticationTest should run for async consumer

2025-01-14 Thread Jira
黃竣陽 created KAFKA-18528: --- Summary: MultipleListenersWithSameSecurityProtocolBaseTest and GssapiAuthenticationTest should run for async consumer Key: KAFKA-18528 URL: https://issues.apache.org/jira/browse/KAFKA-18528

[jira] [Updated] (KAFKA-18527) SaslClientsWithInvalidCredentialsTest.java and SaslClientsWithInvalidCredentialsTest.scala should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18527: Labels: kip-848-client-support (was: ) > SaslClientsWithInvalidCredentialsTest.java and > SaslClientsWithInvalid

[jira] [Updated] (KAFKA-18527) SaslClientsWithInvalidCredentialsTest.java and SaslClientsWithInvalidCredentialsTest.scala should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18527: Fix Version/s: 4.0.0 > SaslClientsWithInvalidCredentialsTest.java and > SaslClientsWithInvalidCredentialsTest.sca

[jira] [Updated] (KAFKA-18527) SaslClientsWithInvalidCredentialsTest.java and SaslClientsWithInvalidCredentialsTest.scala should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18527: Priority: Blocker (was: Major) > SaslClientsWithInvalidCredentialsTest.java and > SaslClientsWithInvalidCredenti

[jira] [Created] (KAFKA-18527) SaslClientsWithInvalidCredentialsTest.java and SaslClientsWithInvalidCredentialsTest.scala should run for async consumer

2025-01-14 Thread Jira
黃竣陽 created KAFKA-18527: --- Summary: SaslClientsWithInvalidCredentialsTest.java and SaslClientsWithInvalidCredentialsTest.scala should run for async consumer Key: KAFKA-18527 URL: https://issues.apache.org/jira/browse/KAFKA-1

[jira] [Created] (KAFKA-18526) PlaintextConsumerAssignorsTest should run for async consumer

2025-01-14 Thread Jira
黃竣陽 created KAFKA-18526: --- Summary: PlaintextConsumerAssignorsTest should run for async consumer Key: KAFKA-18526 URL: https://issues.apache.org/jira/browse/KAFKA-18526 Project: Kafka Issue Type: Test

[jira] [Updated] (KAFKA-18526) PlaintextConsumerAssignorsTest should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18526: Parent: KAFKA-18525 Issue Type: Sub-task (was: Test) > PlaintextConsumerAssignorsTest should run for asyn

[jira] [Updated] (KAFKA-18525) Update the Test should run for async consumer

2025-01-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18525: -- Component/s: clients > Update the Test should run for async consumer > ---

[jira] [Updated] (KAFKA-18517) ConsumerBounceTest should run for async consumer

2025-01-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18517: Parent: KAFKA-18525 Issue Type: Sub-task (was: Test) > ConsumerBounceTest should run for async consumer >

[jira] [Created] (KAFKA-18525) Update the Test should run for async consumer

2025-01-14 Thread Jira
黃竣陽 created KAFKA-18525: --- Summary: Update the Test should run for async consumer Key: KAFKA-18525 URL: https://issues.apache.org/jira/browse/KAFKA-18525 Project: Kafka Issue Type: Test Compon

Re: [PR] KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (#18435) [kafka]

2025-01-14 Thread via GitHub
FrankYang0529 closed pull request #18503: KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (#18435) URL: https://github.com/apache/kafka/pull/18503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (#18435) [kafka]

2025-01-14 Thread via GitHub
FrankYang0529 commented on PR #18502: URL: https://github.com/apache/kafka/pull/18502#issuecomment-2591355588 Thanks, close the issue as we all agree to fix this in 4.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (#18435) [kafka]

2025-01-14 Thread via GitHub
FrankYang0529 closed pull request #18502: KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (#18435) URL: https://github.com/apache/kafka/pull/18502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (#18435) [kafka]

2025-01-14 Thread via GitHub
FrankYang0529 commented on PR #18503: URL: https://github.com/apache/kafka/pull/18503#issuecomment-2591355087 @divijvaidya, thanks, close the issue as we all agree to fix this in 4.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Resolved] (KAFKA-18440) Admin does not convert the AuthorizationException to fatal error in using bootstrap controllers

2025-01-14 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-18440. --- Reviewer: Divij Vaidya Resolution: Fixed > Admin does not convert the AuthorizationException t

[jira] [Updated] (KAFKA-18440) Admin does not convert the AuthorizationException to fatal error in using bootstrap controllers

2025-01-14 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18440: -- Fix Version/s: (was: 3.9.1) (was: 3.8.2) > Admin does not convert the Autho

[jira] [Assigned] (KAFKA-18523) Improve default.replication.factor docs

2025-01-14 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18523: --- Assignee: TengYao Chi > Improve default.replication.factor docs > -

[jira] [Commented] (KAFKA-18523) Improve default.replication.factor docs

2025-01-14 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913108#comment-17913108 ] TengYao Chi commented on KAFKA-18523: - Hi [~mjsax]  I would take a look 😺 > Improv

[PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (12/N): clean up ZKMetadataCacha and raftSuport [kafka]

2025-01-14 Thread via GitHub
TaiJuWu opened a new pull request, #18542: URL: https://github.com/apache/kafka/pull/18542 As title. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (includ

Re: [PR] KAFKA-18479: Remove keepPartitionMetadataFile in UnifiedLog and LogMan… [kafka]

2025-01-14 Thread via GitHub
junrao commented on code in PR #18491: URL: https://github.com/apache/kafka/pull/18491#discussion_r1915704367 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -190,40 +182,26 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Initialize topic ID infor

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-14 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1915718054 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -466,51 +423,39 @@ class KafkaApisTest extends Logging { val configs = Map(authorizedResource -

[jira] [Commented] (KAFKA-18196) Reuse window store for stream-stream self-join

2025-01-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913091#comment-17913091 ] Matthias J. Sax commented on KAFKA-18196: - What are we doing about this now? >

Re: [PR] KAFKA-18452: Implemented batch size in acquired records [kafka]

2025-01-14 Thread via GitHub
apoorvmittal10 commented on code in PR #18459: URL: https://github.com/apache/kafka/pull/18459#discussion_r1915702844 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1104,6 +1116,201 @@ public void testAcquireWithEmptyFetchRecords() { assertEqua

Re: [PR] KAFKA-18513: Validate share state topic record count in tests. [kafka]

2025-01-14 Thread via GitHub
AndrewJSchofield commented on PR #18521: URL: https://github.com/apache/kafka/pull/18521#issuecomment-2591243922 I also had a failure locally in `testConsumerCloseInGroupSequential` because the number of records was incorrect. I expect it's unpredictable for the more complex tests. -- Th

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-01-14 Thread via GitHub
apoorvmittal10 commented on code in PR #17870: URL: https://github.com/apache/kafka/pull/17870#discussion_r1915699751 ## share/src/test/java/org/apache/kafka/server/share/fetch/PartitionMaxBytesStrategyTest.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-18452: Implemented batch size in acquired records [kafka]

2025-01-14 Thread via GitHub
junrao commented on code in PR #18459: URL: https://github.com/apache/kafka/pull/18459#discussion_r1915699553 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1104,6 +1116,201 @@ public void testAcquireWithEmptyFetchRecords() { assertEquals(0, sh

[jira] [Commented] (KAFKA-17580) Java 21 spurious compilation failure in streams:compileTestJava

2025-01-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913088#comment-17913088 ] Matthias J. Sax commented on KAFKA-17580: - [~davidarthur] It's a few month now.

[PR] MINOR: Fixing unchecked warning in partition strategy test [kafka]

2025-01-14 Thread via GitHub
apoorvmittal10 opened a new pull request, #18541: URL: https://github.com/apache/kafka/pull/18541 Addresses: https://github.com/apache/kafka/pull/17870#discussion_r1915653030 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Veri

Re: [PR] KAFKA 16720 : AdminClient support for ListShareGroupOffsets [kafka]

2025-01-14 Thread via GitHub
apoorvmittal10 commented on code in PR #17775: URL: https://github.com/apache/kafka/pull/17775#discussion_r1915646369 ## clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsResult.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-18401: Transaction version 2 does not support commit transaction without records [kafka]

2025-01-14 Thread via GitHub
jolshan commented on code in PR #18448: URL: https://github.com/apache/kafka/pull/18448#discussion_r1915693722 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIntegrationTest.scala: ## @@ -85,6 +88,50 @@ class ProducerIntegrationTest { } finally if

Re: [PR] KAFKA-18405: Remove ZooKeeper logic from DynamicBrokerConfig [kafka]

2025-01-14 Thread via GitHub
chia7712 commented on code in PR #18508: URL: https://github.com/apache/kafka/pull/18508#discussion_r1915664998 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -986,37 +966,13 @@ class DynamicListenerConfig(server: KafkaBroker) extends BrokerReconfigurable

Re: [PR] KAFKA-18401: Transaction version 2 does not support commit transaction without records [kafka]

2025-01-14 Thread via GitHub
brandboat commented on code in PR #18448: URL: https://github.com/apache/kafka/pull/18448#discussion_r1915660816 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIntegrationTest.scala: ## @@ -85,6 +88,50 @@ class ProducerIntegrationTest { } finally i

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-01-14 Thread via GitHub
chia7712 commented on code in PR #17870: URL: https://github.com/apache/kafka/pull/17870#discussion_r1915653030 ## share/src/test/java/org/apache/kafka/server/share/fetch/PartitionMaxBytesStrategyTest.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Resolved] (KAFKA-18502) Remove kafka.controller.Election

2025-01-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18502. Resolution: Fixed trunk: [https://github.com/apache/kafka/commit/118e1835cc58fe4518df5e49

Re: [PR] KAFKA-18514: Remove server dependency from share coordinator [kafka]

2025-01-14 Thread via GitHub
apoorvmittal10 commented on PR #18536: URL: https://github.com/apache/kafka/pull/18536#issuecomment-2591166467 Unrelated tests failure, re-triggering build though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Updated] (KAFKA-18502) Remove kafka.controller.Election

2025-01-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18502: --- Summary: Remove kafka.controller.Election (was: Remove Election) > Remove kafka.controller.

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-01-14 Thread via GitHub
srdo commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2591164571 The example I posted above isn't showing a real oscillation, it's showing that we might report the metric default value (in the example, this is 1.0) if `measure` is called twice without a p

Re: [PR] KAFKA-18502: Remove Election [kafka]

2025-01-14 Thread via GitHub
chia7712 merged PR #18518: URL: https://github.com/apache/kafka/pull/18518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-17853) Console share consumer is not terminated immediately

2025-01-14 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913078#comment-17913078 ] Apoorv Mittal commented on KAFKA-17853: --- Please go ahead, also it might be that th

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-01-14 Thread via GitHub
ahuang98 commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2591153916 Basically the metric can oscillate if the reporting window is consistently skewed with when polls end. I think the same issue could occur even with pre-determined window sizes right?

[PR] KAFKA-18399 Remove-ZooKeeper-from-KafkaApis 6 Tedd [kafka]

2025-01-14 Thread via GitHub
tedyyan opened a new pull request, #18540: URL: https://github.com/apache/kafka/pull/18540 *More detailed description of your change, Changed the following KafkaApi handler handleCreateAcls handleDeleteAcls In Kraft mode, all requests are forwarded to the controller, and all

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS [kafka]

2025-01-14 Thread via GitHub
tedyyan closed pull request #18528: KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS URL: https://github.com/apache/kafka/pull/18528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [KAFKA-18454] Publish build scans to develocity.apache.org [kafka]

2025-01-14 Thread via GitHub
clayburn opened a new pull request, #18539: URL: https://github.com/apache/kafka/pull/18539 This PR migrates the Kafka project to publish Build Scans to the the new Develocity instance at develocity.apache.org. https://issues.apache.org/jira/browse/KAFKA-18454 *More detailed de

Re: [PR] KAFKA-18330: Update documentation to remove controller deployment limitations [kafka]

2025-01-14 Thread via GitHub
jsancio merged PR #18281: URL: https://github.com/apache/kafka/pull/18281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS [kafka]

2025-01-14 Thread via GitHub
chia7712 commented on PR #18528: URL: https://github.com/apache/kafka/pull/18528#issuecomment-2591135212 @tedyyan please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINOR: Update 4.0.0 documentation for Kafka Streams [kafka]

2025-01-14 Thread via GitHub
mjsax commented on PR #18124: URL: https://github.com/apache/kafka/pull/18124#issuecomment-2591123320 Merged to `trunk` and cherry-picked to `4.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-18494: Minor bug fix, added new available state batches for gaps in cachedState during share partition initialization [kafka]

2025-01-14 Thread via GitHub
apoorvmittal10 commented on code in PR #18514: URL: https://github.com/apache/kafka/pull/18514#discussion_r1915595741 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -456,6 +456,17 @@ public CompletableFuture maybeInitialize() { state

Re: [PR] MINOR: Update 4.0.0 documentation for Kafka Streams [kafka]

2025-01-14 Thread via GitHub
mjsax merged PR #18124: URL: https://github.com/apache/kafka/pull/18124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18517: Enable ConsumerBounceTest to run for new async consumer [kafka]

2025-01-14 Thread via GitHub
lianetm commented on PR #18532: URL: https://github.com/apache/kafka/pull/18532#issuecomment-259972 Back to draft to investigate timeout failure on close test that showed up on CI, not locally -- This is an automated message from the Apache Git Service. To respond to the message, plea

  1   2   3   >